From 0fffae7bb590a7497e541926dcb51ecf32a8b1d4 Mon Sep 17 00:00:00 2001
From: Sadie Powell <sadie@witchery.services>
Date: Wed, 12 Nov 2025 21:33:59 +0000
Subject: [PATCH] Centralise logic for determining if a mode needs a param in
 cs_mode.

---
 modules/chanserv/cs_mode.cpp | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/modules/chanserv/cs_mode.cpp b/modules/chanserv/cs_mode.cpp
index 349f9c982..b0131cef1 100644
--- a/modules/chanserv/cs_mode.cpp
+++ b/modules/chanserv/cs_mode.cpp
@@ -288,6 +288,23 @@ class CommandCSMode final
 		return source.AccessFor(ci).HasPriv(cm->name + (self ? "ME" : ""));
 	}
 
+	static bool NeedsParam(ChannelMode *cm, bool adding)
+	{
+		switch (cm->type)
+		{
+			case MODE_REGULAR:
+				return false;
+
+			case MODE_LIST:
+			case MODE_STATUS:
+				return true;
+
+			case MODE_PARAM:
+				return !anope_dynamic_static_cast<ChannelModeParam *>(cm)->minus_no_arg;
+		}
+		return false;
+	}
+
 	void DoLock(CommandSource &source, ChannelInfo *ci, const std::vector<Anope::string> &params)
 	{
 		User *u = source.GetUser();
@@ -351,7 +368,7 @@ class CommandCSMode final
 						}
 
 						Anope::string mode_param;
-						if (((cm->type == MODE_STATUS || cm->type == MODE_LIST) && !sep.GetToken(mode_param)) || (cm->type == MODE_PARAM && adding && !sep.GetToken(mode_param)))
+						if (NeedsParam(cm, adding) && !sep.GetToken(mode_param))
 						{
 							source.Reply(_("Missing parameter for mode %c."), cm->mchar);
 							continue;
@@ -430,7 +447,7 @@ class CommandCSMode final
 						}
 
 						Anope::string mode_param;
-						if ((cm->type == MODE_LIST || cm->type == MODE_STATUS) && !sep.GetToken(mode_param))
+						if (NeedsParam(cm, adding) && !sep.GetToken(mode_param))
 							source.Reply(_("Missing parameter for mode %c."), cm->mchar);
 						else
 						{