Store modules in a list and xlines in a vector, not deques. We need to be able to keep iterators valid.

include/modules.h

@@ -158,7 +158,7 @@ enum MODType { CORE, PROTOCOL, THIRD, SUPPORTED, QATESTED, ENCRYPTION, DATABASE
 struct Message;
 extern CoreExport std::multimap<std::string, Message *> MessageMap;
 class Module;
-extern CoreExport std::deque<Module *> Modules;
+extern CoreExport std::list<Module *> Modules;
 
 /*************************************************************************/
 /* Structure for information about a *Serv command. */

include/operserv.h

@@ -69,7 +69,7 @@ class CoreExport XLineManager
 
  protected:
 	/* List of XLines in this XLineManager */
-	std::deque<XLine *> XLines;
+	std::vector<XLine *> XLines;
  public:
 	/** Constructor
 	 */
@@ -103,10 +103,10 @@ class CoreExport XLineManager
 	 */
 	const size_t GetCount() const;
 
-	/** Get the XLine list
-	 * @return The list
+	/** Get the XLine vector
+	 * @return The vector
 	 */
-	const std::deque<XLine *>& GetList() const;
+	const std::vector<XLine *>& GetList() const;
 
 	/** Add an entry to this XLineManager
 	 * @param x The entry
@@ -125,7 +125,7 @@ class CoreExport XLineManager
 	 */
 	XLine *GetEntry(unsigned index) const;
 
-	/** Clear the XLine list
+	/** Clear the XLine vector
 	 */
 	void Clear();