mirror of
https://github.com/anope/anope.git
synced 2026-07-05 00:33:12 +02:00
Replace convertTo/stringify with non-throwing alternatives.
Having these throw is terrible for ergonomics and there are loads of places where the exception was either silently ignored or not handled at all. Having a function which returns an optional and another that returns a default works a lot better imo.
This commit is contained in:
@@ -166,14 +166,8 @@ private:
|
||||
return;
|
||||
}
|
||||
|
||||
int l;
|
||||
try
|
||||
{
|
||||
l = convertTo<int>(l_str);
|
||||
if (l < 0)
|
||||
throw ConvertException();
|
||||
}
|
||||
catch (const ConvertException &)
|
||||
auto l = Anope::Convert<int>(l_str, -1);
|
||||
if (l < 0)
|
||||
{
|
||||
source.Reply(_("The limit on %s is not valid."), ci->name.c_str());
|
||||
return;
|
||||
|
||||
Reference in New Issue
Block a user