pegasus/anope
1
0
Fork 0
mirror of https://github.com/anope/anope.git synced 2026-06-26 14:16:39 +02:00
Code Activity

Replace convertTo/stringify with non-throwing alternatives.

Browse Source 
Having these throw is terrible for ergonomics and there are loads
of places where the exception was either silently ignored or not
handled at all. Having a function which returns an optional and
another that returns a default works a lot better imo.
This commit is contained in:
Sadie Powell
2024-03-11 13:53:05 +00:00
parent e2df7d4d01
commit 29e7674e56
76 changed files with 572 additions and 810 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/httpd.cpp
+3 -6
View File
@@ -216,11 +216,8 @@ public:
}
else if (buf.find_ci("Content-Length: ") == 0)
{
try
{
this->content_length = convertTo<unsigned>(buf.substr(16));
}
catch (const ConvertException &ex) { }
if (auto len = Anope::TryConvert<unsigned>(buf.substr(16)))
this->content_length = len.value();
}
else if (buf.find(':') != Anope::string::npos)
{
@@ -252,7 +249,7 @@ public:
this->WriteClient("Content-Type: text/html");
else
this->WriteClient("Content-Type: " + msg->content_type);
this->WriteClient("Content-Length: " + stringify(msg->length));
this->WriteClient("Content-Length: " + Anope::ToString(msg->length));
for (const auto &cookie : msg->cookies)
{