From 2f004c2aab8eb33afd958b7dfe05cd89703a1129 Mon Sep 17 00:00:00 2001 From: Thomas Fargeix Date: Fri, 24 Oct 2014 23:45:25 +0200 Subject: [PATCH] Keep the akiller's name when updating the reason. The name of the oper issuing an akill or a sxline could be removed by updating the reason, even though addkiller was enabled. --- modules/commands/os_akill.cpp | 6 +++--- modules/commands/os_sxline.cpp | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/modules/commands/os_akill.cpp b/modules/commands/os_akill.cpp index af8573752..fc2558f2c 100644 --- a/modules/commands/os_akill.cpp +++ b/modules/commands/os_akill.cpp @@ -153,6 +153,9 @@ class CommandOSAKill : public Command if (targ) mask = "*@" + targ->host; + if (Config->GetModule("operserv")->Get("addakiller", "yes") && !source.GetNick().empty()) + reason = "[" + source.GetNick() + "] " + reason; + if (!akills->CanAdd(source, mask, expires, reason)) return; else if (mask.find_first_not_of("/~@.*?") == Anope::string::npos) @@ -166,9 +169,6 @@ class CommandOSAKill : public Command return; } - if (Config->GetModule("operserv")->Get("addakiller", "yes") && !source.GetNick().empty()) - reason = "[" + source.GetNick() + "] " + reason; - XLine *x = new XLine(mask, source.GetNick(), expires, reason); if (Config->GetModule("operserv")->Get("akillids")) x->id = XLineManager::GenerateUID(); diff --git a/modules/commands/os_sxline.cpp b/modules/commands/os_sxline.cpp index 455422845..6b05ad241 100644 --- a/modules/commands/os_sxline.cpp +++ b/modules/commands/os_sxline.cpp @@ -351,6 +351,9 @@ class CommandOSSNLine : public CommandOSSXLineBase if (mask[masklen - 1] == ' ') mask.erase(masklen - 1); + if (Config->GetModule("operserv")->Get("addakiller", "yes") && !source.GetNick().empty()) + reason = "[" + source.GetNick() + "] " + reason; + if (!this->xlm()->CanAdd(source, mask, expires, reason)) return; else if (mask.find_first_not_of("/.*?") == Anope::string::npos) @@ -359,9 +362,6 @@ class CommandOSSNLine : public CommandOSSXLineBase return; } - if (Config->GetModule("operserv")->Get("addakiller", "yes") && !source.GetNick().empty()) - reason = "[" + source.GetNick() + "] " + reason; - XLine *x = new XLine(mask, source.GetNick(), expires, reason); if (Config->GetModule("operserv")->Get("akillids")) x->id = XLineManager::GenerateUID(); @@ -558,6 +558,9 @@ class CommandOSSQLine : public CommandOSSXLineBase } } + if (Config->GetModule("operserv")->Get("addakiller", "yes") && !source.GetNick().empty()) + reason = "[" + source.GetNick() + "] " + reason; + if (!this->sqlines->CanAdd(source, mask, expires, reason)) return; else if (mask.find_first_not_of("./?*") == Anope::string::npos) @@ -566,9 +569,6 @@ class CommandOSSQLine : public CommandOSSXLineBase return; } - if (Config->GetModule("operserv")->Get("addakiller", "yes") && !source.GetNick().empty()) - reason = "[" + source.GetNick() + "] " + reason; - XLine *x = new XLine(mask, source.GetNick(), expires, reason); if (Config->GetModule("operserv")->Get("akillids")) x->id = XLineManager::GenerateUID();