pegasus/anope
1
0
Fork 0
mirror of https://github.com/anope/anope.git synced 2026-07-07 06:33:13 +02:00
Code Activity

Compare access entries created with the levels access system by access level and not by privilege set, as two entries can have the same privset but different levels, but still represent two different levels of access. This prevented users from adding other users at a lower access level when that level had the same privset as them. Spotted by TSG.

Browse Source
This commit is contained in:
Adam
2013-11-01 04:58:38 -04:00
parent c8db362bca
commit 4ee9021adb
4 changed files with 49 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/commands/cs_access.cpp
+21 -1
View File
@@ -43,13 +43,32 @@ class AccessChanAccess : public ChanAccess
{
this->level = convertTo<int>(data);
}
bool operator>(const ChanAccess &other) const anope_override
{
if (this->provider != other.provider)
return ChanAccess::operator>(other);
else
return this->level > anope_dynamic_static_cast<const AccessChanAccess &>(other).level;
}
bool operator<(const ChanAccess &other) const anope_override
{
if (this->provider != other.provider)
return ChanAccess::operator<(other);
else
return this->level < anope_dynamic_static_cast<const AccessChanAccess &>(other).level;
}
};
class AccessAccessProvider : public AccessProvider
{
public:
static AccessAccessProvider *me;
AccessAccessProvider(Module *o) : AccessProvider(o, "access/access")
{
me = this;
}
ChanAccess *Create() anope_override
@@ -57,6 +76,7 @@ class AccessAccessProvider : public AccessProvider
return new AccessChanAccess(this);
}
};
AccessAccessProvider* AccessAccessProvider::me;
class CommandCSAccess : public Command
{
@@ -91,7 +111,7 @@ class CommandCSAccess : public Command
AccessGroup u_access = source.AccessFor(ci);
const ChanAccess *highest = u_access.Highest();
AccessChanAccess tmp_access(NULL);
AccessChanAccess tmp_access(AccessAccessProvider::me);
tmp_access.ci = ci;
tmp_access.level = level;