From 67b76fadca2c3af105e7aff862242971960fa5d5 Mon Sep 17 00:00:00 2001 From: Sadie Powell Date: Fri, 7 Jun 2024 22:36:52 +0100 Subject: [PATCH] Fix a memory leak in os_akill and os_sxline. --- modules/operserv/os_akill.cpp | 3 +++ modules/operserv/os_sxline.cpp | 3 +++ 2 files changed, 6 insertions(+) diff --git a/modules/operserv/os_akill.cpp b/modules/operserv/os_akill.cpp index 7fcacd9ad..26936cc2c 100644 --- a/modules/operserv/os_akill.cpp +++ b/modules/operserv/os_akill.cpp @@ -188,7 +188,10 @@ private: } if (!akills->CanAdd(source, mask, expires, reason)) + { + delete x; return; + } EventReturn MOD_RESULT; FOREACH_RESULT(OnAddXLine, MOD_RESULT, (source, x, akills)); diff --git a/modules/operserv/os_sxline.cpp b/modules/operserv/os_sxline.cpp index 2460a5fe8..e18a21f9c 100644 --- a/modules/operserv/os_sxline.cpp +++ b/modules/operserv/os_sxline.cpp @@ -389,7 +389,10 @@ class CommandOSSNLine final } if (!this->xlm()->CanAdd(source, mask, expires, reason)) + { + delete x; return; + } EventReturn MOD_RESULT; FOREACH_RESULT(OnAddXLine, MOD_RESULT, (source, x, this->xlm()));