From f03e802f580d83d0b4cfc41c27c71e0040d35fbc Mon Sep 17 00:00:00 2001 From: crazycatdevs <44431938+crazycatdevs@users.noreply.github.com> Date: Fri, 5 Sep 2025 15:45:57 +0200 Subject: [PATCH 1/2] Fix creating channel entries in irc2sql. Related to #526 : MySQL doesn't accept the timestamp in topictime, must use FROM_UNIXTIME() like it's done in OnTopicUpdated --- modules/extra/stats/irc2sql/irc2sql.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/extra/stats/irc2sql/irc2sql.cpp b/modules/extra/stats/irc2sql/irc2sql.cpp index e1af50ae5..59e1982e0 100644 --- a/modules/extra/stats/irc2sql/irc2sql.cpp +++ b/modules/extra/stats/irc2sql/irc2sql.cpp @@ -198,7 +198,7 @@ void IRC2SQL::OnSetDisplayedHost(User *u) void IRC2SQL::OnChannelCreate(Channel *c) { query = "INSERT INTO `" + prefix + "chan` (channel, topic, topicauthor, topictime, modes) " - "VALUES (@channel@,@topic@,@topicauthor@,@topictime@,@modes@) " + "VALUES (@channel@,@topic@,@topicauthor@,FROM_UNIXTIME(@topictime@),@modes@) " "ON DUPLICATE KEY UPDATE channel=VALUES(channel), topic=VALUES(topic)," "topicauthor=VALUES(topicauthor), topictime=VALUES(topictime), modes=VALUES(modes)"; query.SetValue("channel", c->name); From f4c565aa08fcb2bd34c5b16a69b4a5ce2fb9f81c Mon Sep 17 00:00:00 2001 From: Sadie Powell Date: Sun, 9 Nov 2025 15:56:30 +0000 Subject: [PATCH 2/2] Fix reading the settings in m_dns. --- modules/m_dns.cpp | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/modules/m_dns.cpp b/modules/m_dns.cpp index fbd2cb96b..4d1317127 100644 --- a/modules/m_dns.cpp +++ b/modules/m_dns.cpp @@ -1011,12 +1011,6 @@ class ModuleDNS : public Module { MyManager manager; - Anope::string nameserver; - Anope::string ip; - int port; - - std::vector > notify; - public: ModuleDNS(const Anope::string &modname, const Anope::string &creator) : Module(modname, creator, EXTRA | VENDOR), manager(this) { @@ -1039,14 +1033,15 @@ class ModuleDNS : public Module { Configuration::Block *block = conf->GetModule(this); - nameserver = block->Get("nameserver", "127.0.0.1"); - timeout = block->Get("timeout", "5"); - ip = block->Get("ip", "0.0.0.0"); - port = block->Get("port", "53"); + Anope::string nameserver = block->Get("nameserver", "127.0.0.1"); + timeout = block->Get("timeout", "5"); + Anope::string ip = block->Get("ip", "0.0.0.0"); + int port = block->Get("port", "53"); admin = block->Get("admin", "admin@example.com"); nameservers = block->Get("nameservers", "ns1.example.com"); refresh = block->Get("refresh", "3600"); + std::vector > notify; for (int i = 0; i < block->CountBlock("notify"); ++i) { Configuration::Block *n = block->GetBlock("notify", i);