pegasus/anope
1
0
Fork 0
mirror of https://github.com/anope/anope.git synced 2026-07-10 19:03:13 +02:00
Code Activity

Remove undefined behaviour around checking if this is null.

Browse Source
This commit is contained in:
Sadie Powell
2021-11-30 10:54:10 +00:00
parent 17fa704278
commit 754c82d047
6 changed files with 17 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/commands/os_config.cpp
+5 -8
View File
@@ -57,15 +57,12 @@ class CommandOSConfig : public Command
for (unsigned i = 0; !show_blocks[i].empty(); ++i)
{
Configuration::Block *block = Config->GetBlock(show_blocks[i]);
const Configuration::Block::item_map *items = block->GetItems();
if (!items)
continue;
const Configuration::Block::item_map &items = block->GetItems();
ListFormatter lflist(source.GetAccount());
lflist.AddColumn(_("Name")).AddColumn(_("Value"));
for (Configuration::Block::item_map::const_iterator it = items->begin(), it_end = items->end(); it != it_end; ++it)
for (Configuration::Block::item_map::const_iterator it = items.begin(), it_end = items.end(); it != it_end; ++it)
{
ListFormatter::ListEntry entry;
entry["Name"] = it->first;
@@ -90,15 +87,15 @@ class CommandOSConfig : public Command
for (int i = 0; i < Config->CountBlock("module"); ++i)
{
Configuration::Block *block = Config->GetBlock("module", i);
const Configuration::Block::item_map *items = block->GetItems();
const Configuration::Block::item_map &items = block->GetItems();
if (!items || items->size() <= 1)
if (items.size() <= 1)
continue;
ListFormatter::ListEntry entry;
entry["Module Name"] = block->Get<Anope::string>("name");
for (Configuration::Block::item_map::const_iterator it = items->begin(), it_end = items->end(); it != it_end; ++it)
for (Configuration::Block::item_map::const_iterator it = items.begin(), it_end = items.end(); it != it_end; ++it)
{
entry["Name"] = it->first;
entry["Value"] = it->second;