pegasus/anope
1
0
Fork 0
mirror of https://github.com/anope/anope.git synced 2026-07-04 11:03:14 +02:00
Code Activity

Destroyed Command::help_param* and rewrote the help part of os_news to be much better

Browse Source 
git-svn-id: http://anope.svn.sourceforge.net/svnroot/anope/trunk@2538 5417fbe8-f217-4b02-8779-1006273d7864
This commit is contained in:
Adam-
2009-10-06 21:54:55 +00:00
parent 6ac61a1852
commit fb5356ccbc
15 changed files with 30 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/command.cpp
-4
View File
@@ -14,10 +14,6 @@
Command::Command(const std::string &sname, size_t min_params, size_t max_params, const std::string &spermission) : MaxParams(max_params), MinParams(min_params), name(sname), permission(spermission)
{
this->flags = 0;
this->help_param1 = NULL;
this->help_param2 = NULL;
this->help_param3 = NULL;
this->help_param4 = NULL;
this->core = 0;
this->mod_name = NULL;
this->service = NULL;
src/core/os_news.c
+6 -53
View File
@@ -240,14 +240,6 @@ class CommandOSLogonNews : public NewsBase
public:
CommandOSLogonNews() : NewsBase("LOGONNEWS")
{
this->help_param1 = NULL;
this->UpdateHelpParam();
}
~CommandOSLogonNews()
{
delete [] this->help_param1;
}
CommandReturn Execute(User *u, std::vector<ci::string> &params)
@@ -257,7 +249,7 @@ class CommandOSLogonNews : public NewsBase
bool OnHelp(User *u, const ci::string &subcommand)
{
notice_help(s_OperServ, u, NEWS_HELP_LOGON, this->help_param1);
notice_help(s_OperServ, u, NEWS_HELP_LOGON, NewsCount);
return true;
}
@@ -265,32 +257,13 @@ class CommandOSLogonNews : public NewsBase
{
syntax_error(s_OperServ, u, "LOGONNEWS", NEWS_LOGON_SYNTAX);
}
void UpdateHelpParam()
{
if (this->help_param1)
delete [] this->help_param1;
char buf[BUFSIZE];
snprintf(buf, BUFSIZE, "%d", NewsCount),
this->help_param1 = sstrdup(buf);
}
} *OSLogonNews = NULL;
};
class CommandOSOperNews : public NewsBase
{
public:
CommandOSOperNews() : NewsBase("OPERNEWS")
{
this->help_param1 = NULL;
this->UpdateHelpParam();
}
~CommandOSOperNews()
{
delete [] this->help_param1;
}
CommandReturn Execute(User *u, std::vector<ci::string> &params)
@@ -300,7 +273,7 @@ class CommandOSOperNews : public NewsBase
bool OnHelp(User *u, const ci::string &subcommand)
{
notice_help(s_OperServ, u, NEWS_HELP_OPER, this->help_param1);
notice_help(s_OperServ, u, NEWS_HELP_OPER, NewsCount);
return true;
}
@@ -308,18 +281,7 @@ class CommandOSOperNews : public NewsBase
{
syntax_error(s_OperServ, u, "OPERNEWS", NEWS_OPER_SYNTAX);
}
void UpdateHelpParam()
{
if (this->help_param1)
delete [] this->help_param1;
char buf[BUFSIZE];
snprintf(buf, BUFSIZE, "%d", NewsCount),
this->help_param1 = sstrdup(buf);
}
} *OSOperNews = NULL;
};
class CommandOSRandomNews : public NewsBase
{
@@ -354,12 +316,9 @@ class OSNews : public Module
this->SetVersion("$Id$");
this->SetType(CORE);
OSLogonNews = new CommandOSLogonNews();
this->AddCommand(OPERSERV, OSLogonNews);
OSOperNews = new CommandOSOperNews();
this->AddCommand(OPERSERV, OSOperNews);
this->AddCommand(OPERSERV, new CommandOSLogonNews());
this->AddCommand(OPERSERV, new CommandOSOperNews());
this->AddCommand(OPERSERV, new CommandOSRandomNews());
ModuleManager::Attach(I_OnReload, this);
}
void OperServHelp(User *u)
@@ -368,12 +327,6 @@ class OSNews : public Module
notice_lang(s_OperServ, u, OPER_HELP_CMD_OPERNEWS);
notice_lang(s_OperServ, u, OPER_HELP_CMD_RANDOMNEWS);
}
void OnReload(bool starting)
{
OSLogonNews->UpdateHelpParam();
OSOperNews->UpdateHelpParam();
}
};
MODULE_INIT(OSNews)