From 017c87cd4d5db4a93eca47cd867ddd2fe610e177 Mon Sep 17 00:00:00 2001 From: stskeeps Date: Thu, 26 Apr 2007 12:55:18 +0000 Subject: [PATCH] - #0002095 removing /helpop broadcasting --- Changes | 2 +- doc/unreal32docs.html | 18 ++------- help.conf | 2 +- src/modules/m_help.c | 86 ++++--------------------------------------- src/modules/m_tkl.c | 2 +- 5 files changed, 13 insertions(+), 97 deletions(-) diff --git a/Changes b/Changes index 05a90722b..214f99701 100644 --- a/Changes +++ b/Changes @@ -1631,4 +1631,4 @@ MOTDs Devel.WolfSage.org[192.168.2.97] instead of @1 ] :Server Devel.WolfSage.org[192.168.2.97] closed the connection. This would probably have caused netsplits to go unnoticed. - +- #0002095 removing /helpop broadcasting diff --git a/doc/unreal32docs.html b/doc/unreal32docs.html index 091dba6d0..1b0bbf21b 100644 --- a/doc/unreal32docs.html +++ b/doc/unreal32docs.html @@ -301,9 +301,7 @@ because otherwise you will not understand concepts such as 'cloaking', 'snomasks the help block in the configuration file. Additionally, a help.conf is included which contains some basic help for all commands.
For example /helpop chmodes gives you a overview of all channel modes UnrealIRCd has.
- Remember that if you are an ircop (helpop) you will have to prefix the keyword with a '?' character, - so /helpop becomes /helpop ? and - /helpop chmodes becomes /helpop ?chmodes etc..

+

3.6 - Oper access levels

There are several oper levels in UnrealIRCd and you can add additional rights (like to use /gline) to @@ -1019,7 +1017,7 @@ listen *:6601 {

h
helpop
- Oper receives umode +h (helpop) + Oper is marked as "availiable for help" when he/she is not away
w
@@ -2810,7 +2808,7 @@ AU). Requests to these servers are sent in parallel, fastest reply wins.

7 – User & Oper Commands Table

-

NOTE: the /helpop documentation is more up to date, use /helpop command (or /helpop ?command if you are oper) +

NOTE: the /helpop documentation is more up to date, use /helpop command to get more information on a command.

@@ -2950,16 +2948,6 @@ to get more information on a command.

to an IRC server.
- - - - -
All
helpop ?<topic> or !<topic>
HelpOp is a new system of getting IRC Server help. You type either /HELPOP - ? <help system topic> or /HELPOP ! <question> The "?" - in /HELPOP means query the help system and if you get no response you can - choose '!' to send it to the Help Operators online. Using neither ? nor ! - will mean the command will be first queried within the help system and if - no match if found , it will be forwarded to the help operatorsAll
list <search string> diff --git a/help.conf b/help.conf index 6ef5d0b84..1efc04061 100644 --- a/help.conf +++ b/help.conf @@ -264,7 +264,7 @@ help Oflags { " r (can_rehash) Access to /REHASH server"; " R (can_restart) Access to /RESTART server"; " D (can_die) Access to /DIE server"; - " h (helpop) Oper receives umode +h (helpop)"; + " h (helpop) Oper is marked as availiable for help is not away"; " g (can_globops) Oper can send /GLOBOPS"; " w (can_wallops) Oper can send /WALLOPS"; " n (can_localnotice) Oper can send Local Server Notices"; diff --git a/src/modules/m_help.c b/src/modules/m_help.c index 4ffeb39b6..6624e33e6 100644 --- a/src/modules/m_help.c +++ b/src/modules/m_help.c @@ -99,88 +99,16 @@ CMD_FUNC(m_help) message = parc > 1 ? parv[1] : NULL; -/* Drags along from wallops code... I'm not sure what it's supposed to do, - at least it won't do that gracefully, whatever it is it does - but - checking whether or not it's a person _is_ good... -Donwulff */ + if (!MyConnect(sptr)) + return 0; - if (IsServer(sptr) || IsHelpOp(sptr)) - { - if (BadPtr(message)) { - if (MyClient(sptr)) { - parse_help(sptr, parv[0], NULL); - sendto_one(sptr, - ":%s NOTICE %s :*** NOTE: As a helpop you have to prefix your text with ? to query the help system, like: /helpop ?usercmds", - me.name, sptr->name); - } - return 0; - } - if (message[0] == '?') - { - parse_help(sptr, parv[0], message + 1); - return 0; - } - if (!myncmp(message, "IGNORE ", 7)) - { - tmpl = make_link(); - DupString(tmpl->value.cp, message + 7); - tmpl->next = helpign; - helpign = tmpl; - return 0; - } - if (message[0] == '!') - message++; - if (BadPtr(message)) - return 0; - sendto_serv_butone_token(IsServer(cptr) ? cptr : NULL, - parv[0], MSG_HELP, TOK_HELP, "%s", message); - sendto_umode(UMODE_HELPOP, "*** HelpOp -- from %s (HelpOp): %s", - parv[0], message); + if (BadPtr(message)) { + parse_help(sptr, parv[0], NULL); + return 0; } - else if (MyConnect(sptr)) - { - /* New syntax: ?... never goes out, !... always does. */ - if (BadPtr(message)) { - parse_help(sptr, parv[0], NULL); + else { + if (parse_help(sptr, parv[0], message)) return 0; - } - else if (message[0] == '?') { - parse_help(sptr, parv[0], message+1); - return 0; - } - else if (message[0] == '!') { - message++; - } - else { - if (parse_help(sptr, parv[0], message)) - return 0; - } - if (BadPtr(message)) - return 0; - s = make_nick_user_host(cptr->name, cptr->user->username, - cptr->user->realhost); - for (tmpl = helpign; tmpl; tmpl = tmpl->next) - if (match(tmpl->value.cp, s) == 0) - { - sendto_one(sptr, rpl_str(RPL_HELPIGN), me.name, - parv[0]); - return 0; - } - - sendto_serv_butone_token(IsServer(cptr) ? cptr : NULL, - parv[0], MSG_HELP, TOK_HELP, "%s", message); - sendto_umode(UMODE_HELPOP, "*** HelpOp -- from %s (Local): %s", - parv[0], message); - sendto_one(sptr, rpl_str(RPL_HELPFWD), me.name, parv[0]); } - else - { - if (BadPtr(message)) - return 0; - sendto_serv_butone_token(IsServer(cptr) ? cptr : NULL, - parv[0], MSG_HELP, TOK_HELP, "%s", message); - sendto_umode(UMODE_HELPOP, "*** HelpOp -- from %s: %s", parv[0], - message); - } - return 0; } diff --git a/src/modules/m_tkl.c b/src/modules/m_tkl.c index a109b4834..ad1cd569d 100644 --- a/src/modules/m_tkl.c +++ b/src/modules/m_tkl.c @@ -705,7 +705,7 @@ DLLFUNC int m_tkl_line(aClient *cptr, aClient *sptr, int parc, char *parv[], ch int spamfilter_usage(aClient *sptr) { sendnotice(sptr, "Use: /spamfilter [add|del|remove|+|-] [type] [action] [tkltime] [tklreason] [regex]"); - sendnotice(sptr, "See '/helpop ?spamfilter' for more information."); + sendnotice(sptr, "See '/helpop spamfilter' for more information."); return 0; }