From 43da14f7c6a7012a947802f2b435aff06dfdaef3 Mon Sep 17 00:00:00 2001 From: Bram Matthys Date: Sun, 22 Feb 2026 08:03:23 +0100 Subject: [PATCH] Get rid of old confusing comment in src/parse.c regarding commands with 0 flags if (cmptr->flags != 0) { /* temporary until all commands are updated */ But that is impossible, as CommandAdd()->CommandAddInternal() already has: if (!flags) { config_error("CommandAdd(): Could not add command '%s': flags are 0", cmd); And this is the case since commit ceb04cc3eb98df92d686f9e068cdb371aed17152 from July 15, 2015. --- src/parse.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/parse.c b/src/parse.c index 93e303f90..fb8b4166a 100644 --- a/src/parse.c +++ b/src/parse.c @@ -443,7 +443,6 @@ static void parse2(Client *cptr, Client **fromptr, MessageTag *mtags, int mtags_ ircstats.is_unco++; return; } - if (cmptr->flags != 0) { /* temporary until all commands are updated */ /* Logic in comparisons below is a bit complicated, see notes */ @@ -460,7 +459,6 @@ static void parse2(Client *cptr, Client **fromptr, MessageTag *mtags, int mtags_ /* If you're a server, but command doesn't want servers, deny */ if ((flags & CMD_SERVER) && !(cmptr->flags & CMD_SERVER)) return; - } /* If you're a user, but not an operator, and this requires operators, deny */ if ((cmptr->flags & CMD_OPER) && (flags & CMD_USER) && !(flags & CMD_OPER))