From 7641d85d2fbebfaef05b5e14e8be9cbcf8380d2a Mon Sep 17 00:00:00 2001
From: William Pitcock <nenolod@dereferenced.org>
Date: Wed, 26 Dec 2012 12:52:48 -0600
Subject: [PATCH] - Remove arbitrary helpops messaging stuff like in 3.3. 
 (#2095)   HelpOp usermode is kept around for vanity for right now.

---
 src/modules/m_help.c | 69 +-------------------------------------------
 1 file changed, 1 insertion(+), 68 deletions(-)

diff --git a/src/modules/m_help.c b/src/modules/m_help.c
index e4e359967..02912b432 100644
--- a/src/modules/m_help.c
+++ b/src/modules/m_help.c
@@ -99,48 +99,7 @@ CMD_FUNC(m_help)
 
 	message = parc > 1 ? parv[1] : NULL;
 
-/* Drags along from wallops code... I'm not sure what it's supposed to do,
-   at least it won't do that gracefully, whatever it is it does - but
-   checking whether or not it's a person _is_ good... -Donwulff */
-
-	if (!IsServer(sptr) && MyConnect(sptr) && !IsPerson(sptr))
-	{
-	}
-
-	if (IsServer(sptr) || IsHelpOp(sptr))
-	{
-		if (BadPtr(message)) {
-			if (MyClient(sptr)) {
-				parse_help(sptr, parv[0], NULL);
-				sendto_one(sptr,
-					":%s NOTICE %s :*** NOTE: As a helpop you have to prefix your text with ? to query the help system, like: /helpop ?usercmds",
-					me.name, sptr->name);
-			}
-			return 0;
-		}
-		if (message[0] == '?')
-		{
-			parse_help(sptr, parv[0], message + 1);
-			return 0;
-		}
-		if (!myncmp(message, "IGNORE ", 7))
-		{
-			tmpl = make_link();
-			DupString(tmpl->value.cp, message + 7);
-			tmpl->next = helpign;
-			helpign = tmpl;
-			return 0;
-		}
-		if (message[0] == '!')
-			message++;
-		if (BadPtr(message))
-			return 0;
-		sendto_serv_butone_token(IsServer(cptr) ? cptr : NULL,
-		    parv[0], MSG_HELP, TOK_HELP, "%s", message);
-		sendto_umode(UMODE_HELPOP, "*** HelpOp -- from %s (HelpOp): %s",
-		    parv[0], message);
-	}
-	else if (MyConnect(sptr))
+	if (MyConnect(sptr))
 	{
 		/* New syntax: ?... never goes out, !... always does. */
 		if (BadPtr(message)) {
@@ -158,32 +117,6 @@ CMD_FUNC(m_help)
 			if (parse_help(sptr, parv[0], message))
 				return 0;
 		}
-		if (BadPtr(message))
-			return 0;
-		s = make_nick_user_host(cptr->name, cptr->user->username,
-		    cptr->user->realhost);
-		for (tmpl = helpign; tmpl; tmpl = tmpl->next)
-			if (match(tmpl->value.cp, s) == 0)
-			{
-				sendto_one(sptr, rpl_str(RPL_HELPIGN), me.name,
-				    parv[0]);
-				return 0;
-			}
-
-		sendto_serv_butone_token(IsServer(cptr) ? cptr : NULL,
-		    parv[0], MSG_HELP, TOK_HELP, "%s", message);
-		sendto_umode(UMODE_HELPOP, "*** HelpOp -- from %s (Local): %s",
-		    parv[0], message);
-		sendto_one(sptr, rpl_str(RPL_HELPFWD), me.name, parv[0]);
-	}
-	else
-	{
-		if (BadPtr(message))
-			return 0;
-		sendto_serv_butone_token(IsServer(cptr) ? cptr : NULL,
-		    parv[0], MSG_HELP, TOK_HELP, "%s", message);
-		sendto_umode(UMODE_HELPOP, "*** HelpOp -- from %s: %s", parv[0],
-		    message);
 	}
 
 	return 0;