From 9c0f1f3505ffcc12cf80fc0ce3017bbdc7e2e866 Mon Sep 17 00:00:00 2001 From: Bram Matthys Date: Wed, 6 Feb 2019 19:31:10 +0100 Subject: [PATCH] Fix OOB read in m_whox. Strange order for a compare, first the 2nd byte, then the 1st byte ;) Anyway, this issue can only be triggered since rc1, no big issue. --- src/modules/m_whox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/m_whox.c b/src/modules/m_whox.c index 9e754216a..b26586915 100644 --- a/src/modules/m_whox.c +++ b/src/modules/m_whox.c @@ -359,7 +359,7 @@ CMD_FUNC(m_whox) * request a full list. I presume its because of too many typos * with "/who" ;) --fl */ - if ((*(mask + 1) == '\0') && (*mask == '0')) + if (!strcmp(mask, "0")) who_global(sptr, NULL, 0, &fmt); else who_global(sptr, mask, operspy, &fmt);