pegasus/unrealircd
1
0
Fork 0
mirror of https://github.com/unrealircd/unrealircd.git synced 2026-07-05 03:13:14 +02:00
Code Activity

Make SVSLOGIN a broadcast, so all servers have the same svid information

Browse Source 
for the user. Otherwise with post-connect SASL authentication you will
have different login information on server X compared to server Y
(the server with the user on it was always correct, though).

Also, add a function called user_account_login() which is used by both
SVSMODE/SVS2MODE and SVSLOGIN to send ACCOUNT messages to the channel.
This too was missing for SVSLOGIN (post-authentication SASL).

For this fix to be 100% effective, you need 100% UnrealIRCd 5.
This commit is contained in:
Bram Matthys
2019-11-18 15:35:41 +01:00
parent 54513307ec
commit ab42e12002
4 changed files with 39 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/modules/sasl.c
+24 -16
View File
@@ -73,34 +73,42 @@ long CAP_SASL = 0L;
*/
CMD_FUNC(cmd_svslogin)
{
Client *target;
if (!SASL_SERVER || MyUser(client) || (parc < 3) || !parv[3])
return;
if (!strcasecmp(parv[1], me.name) || !strncmp(parv[1], me.id, 3))
/* We actually ignore parv[1] since this is a broadcast message.
* It is a broadcast message because we want ALL servers to know
* that the user is now logged in under account xyz.
*/
target = find_client(parv[2], NULL);
if (!target)
return; /* client not found */
if (IsServer(target))
return;
if (target->user == NULL)
make_user(target);
strlcpy(target->user->svid, parv[3], sizeof(target->user->svid));
if (MyConnect(target))
{
Client *target;
target = find_client(parv[2], NULL);
if (!target || !MyConnect(target))
return;
if (target->user == NULL)
make_user(target);
strlcpy(target->user->svid, parv[3], sizeof(target->user->svid));
/* Notify user */
sendnumeric(target, RPL_LOGGEDIN,
BadPtr(target->name) ? "*" : target->name,
BadPtr(target->user->username) ? "*" : target->user->username,
BadPtr(target->user->realhost) ? "*" : target->user->realhost,
target->user->svid, target->user->svid);
return;
}
/* not for us; propagate. */
user_account_login(recv_mtags, target);
/* Propagate to the rest of the network */
sendto_server(client, 0, 0, NULL, ":%s SVSLOGIN %s %s %s",
client->name, parv[1], parv[2], parv[3]);
client->name, parv[1], parv[2], parv[3]);
}
/*
src/modules/svsmode.c
+1 -8
View File
@@ -406,15 +406,8 @@ void do_svsmode(Client *client, MessageTag *recv_mtags, int parc, char *parv[],
case 'd':
if (parv[3])
{
MessageTag *mtags = NULL;
strlcpy(target->user->svid, parv[3], sizeof(target->user->svid));
new_message(target, recv_mtags, &mtags);
sendto_local_common_channels(target, target,
ClientCapabilityBit("account-notify"), mtags,
":%s ACCOUNT %s",
target->name,
!isdigit(*target->user->svid) ? target->user->svid : "*");
free_message_tags(mtags);
user_account_login(recv_mtags, target);
}
else
{