pegasus/unrealircd
1
0
Fork 0
mirror of https://github.com/unrealircd/unrealircd.git synced 2026-07-09 01:03:13 +02:00
Code Activity

- example.conf: added +i in modes-on-connect.

Browse Source 
- Temporarely added fdlist debugcode, please report any bugreports it gives,
  it would especially be helpful if you know _what_ triggered the error :).
This commit is contained in:
Bram Matthys
2003-11-30 23:17:33 +00:00
parent b27e04b7a1
commit b537553d2e
4 changed files with 68 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/fdlist.c
+41
View File
@@ -33,9 +33,14 @@ extern fdlist busycli_fdlist;
extern fdlist serv_fdlist;
extern fdlist oper_fdlist;
#define FDLIST_DEBUG
void addto_fdlist(int fd, fdlist * listp)
{
int index;
#ifdef FDLIST_DEBUG
int i;
#endif
/* I prefer this little 5-cpu-cycles-check over memory corruption. -- Syzop */
if ((fd < 0) || (fd >= MAXCONNECTIONS))
@@ -49,6 +54,21 @@ void addto_fdlist(int fd, fdlist * listp)
return;
}
#ifdef FDLIST_DEBUG
for (i = listp->last_entry; i; i--)
{
if (listp->entry[i] == fd)
{
char buf[2048];
ircsprintf(buf, "[BUG] addto_fdlist() called for duplicate entry! fd=%d, fdlist=%p, client=%s (%p/%p/%p/%p)",
fd, listp, local[fd] ? local[fd]->name : "<null>", &default_fdlist, &busycli_fdlist, &serv_fdlist, &oper_fdlist);
sendto_realops("%s", buf);
ircd_log(LOG_ERROR, "%s", buf);
return;
}
}
#endif
if ((index = ++listp->last_entry) >= MAXCONNECTIONS)
{
/*
@@ -66,6 +86,9 @@ void addto_fdlist(int fd, fdlist * listp)
void delfrom_fdlist(int fd, fdlist * listp)
{
int i;
#ifdef FDLIST_DEBUG
int cnt = 0;
#endif
/* I prefer this little 5-cpu-cycles-check over memory corruption. -- Syzop */
if ((fd < 0) || (fd >= MAXCONNECTIONS))
@@ -79,6 +102,24 @@ void delfrom_fdlist(int fd, fdlist * listp)
return;
}
#ifdef FDLIST_DEBUG
for (i = listp->last_entry; i; i--)
{
if (listp->entry[i] == fd)
cnt++;
}
if (cnt > 1)
{
char buf[2048];
ircsprintf(buf, "[BUG] delfrom_fdlist() called, duplicate entries detected! fd=%d, fdlist=%p, client=%s (%p/%p/%p/%p)",
fd, listp, local[fd] ? local[fd]->name : "<null>", &default_fdlist, &busycli_fdlist, &serv_fdlist, &oper_fdlist);
sendto_realops("%s", buf);
ircd_log(LOG_ERROR, "%s", buf);
return;
}
#endif
for (i = listp->last_entry; i; i--)
{
if (listp->entry[i] == fd)
src/s_misc.c
+23
View File
@@ -385,6 +385,29 @@ int exit_client(aClient *cptr, aClient *sptr, aClient *from, char *comment)
if (MyConnect(sptr))
{
#ifndef NO_FDLIST
#define FDLIST_DEBUG
#ifdef FDLIST_DEBUG
{
int i;
int cnt = 0;
if (!IsAnOper(sptr))
{
for (i = oper_fdlist.last_entry; i; i--)
{
if (oper_fdlist.entry[i] == sptr->slot)
{
sendto_realops("[BUG] exit_client: oper_fdlist entry while not oper, fd=%d, user='%s'",
sptr->slot, sptr->name);
ircd_log(LOG_ERROR, "[BUG] exit_client: oper_fdlist entry while not oper, fd=%d, user='%s'",
sptr->slot, sptr->name);
delfrom_fdlist(sptr->slot, &oper_fdlist); /* be kind of enough to fix the problem.. */
break; /* MUST break here */
}
}
}
}
#endif
if (IsAnOper(sptr))
delfrom_fdlist(sptr->slot, &oper_fdlist);
if (IsServer(sptr))