From c2db2715c09526aad0afe03070bc57433dbe1d9c Mon Sep 17 00:00:00 2001 From: Bram Matthys Date: Fri, 23 Jan 2026 07:44:36 +0100 Subject: [PATCH] Fix post-registration SASL not working due to change from a few days ago. (commit 0cf0c0faa27ccfc4308834cb98ae92dcc0c31b64) This was caused by register_user() being called twice, while it should only have been called if !IsUser(). Reported by ProgVal in https://bugs.unrealircd.org/view.php?id=6606 My BuildBot screen was also all red :D. --- src/modules/sasl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/sasl.c b/src/modules/sasl.c index 7daef244e..0546eea06 100644 --- a/src/modules/sasl.c +++ b/src/modules/sasl.c @@ -195,8 +195,8 @@ CMD_FUNC(cmd_sasl) sasl_failed(target); else if (*parv[4] == 'S') sasl_succeeded(target); - /* Now that SASL response came in, check if handshake is finished */ - if (is_handshake_finished(target)) + /* Now that SASL response came in, check if user is unregistered and handshake finished now */ + if (!IsUser(target) && is_handshake_finished(target)) { register_user(target); /* User MAY be killed now, that's okay, we don't deal with 'target' below */