From ca6630a2fb622ce59b8b59a20ea6f5fdb69c337b Mon Sep 17 00:00:00 2001 From: Bram Matthys Date: Fri, 26 Jun 2020 15:11:01 +0200 Subject: [PATCH] Fix "called a function you should not call" server linking error that happens if all of the following are true: 1) You use link::outgoing::tls-options (or ssl-options) 2) You do a REHASH -tls (or REHASH -ssl) 3) You do NOT do a regular REHASH 4) You try to link to the server in such a link block (outgoing!) In other words: the problem may happen if you try to link after a Let's Encrypt cert renewal, unless there has been a regular REHASH between that and the outgoing linking attempt. Reported by k4be and Le_Coyoto in https://bugs.unrealircd.org/view.php?id=5607 --- src/tls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tls.c b/src/tls.c index f7e75c746..a0d830ebb 100644 --- a/src/tls.c +++ b/src/tls.c @@ -625,7 +625,7 @@ void reinit_ssl(Client *client) { if (link->tls_options) { - tmp = init_ctx(link->tls_options, 1); + tmp = init_ctx(link->tls_options, 0); if (!tmp) { config_error("SSL Reload partially failed. link::outgoing::tls-options error in link %s { }, see above",