From f59b937f3b3e4593bdd406d61d71983a4cc18eff Mon Sep 17 00:00:00 2001 From: Bram Matthys Date: Sat, 21 Feb 2026 13:45:47 +0100 Subject: [PATCH] Fix leak if central-blocklist returns "error" JSON string (very rare) --- src/modules/central-blocklist.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/modules/central-blocklist.c b/src/modules/central-blocklist.c index fd45cc9f7..31eefefcc 100644 --- a/src/modules/central-blocklist.c +++ b/src/modules/central-blocklist.c @@ -954,6 +954,7 @@ void cbl_download_complete(OutgoingWebRequest *request, OutgoingWebResponse *res if ((str = json_object_get_string(result, "error"))) { cbl_error_response(transfer, str); + json_decref(result); return; } @@ -972,8 +973,8 @@ void cbl_download_complete(OutgoingWebRequest *request, OutgoingWebResponse *res responses = json_object_get(result, "responses"); if (!responses) { - json_decref(result); cbl_error_response(transfer, "no spam scores calculated for users"); + json_decref(result); return; /* Nothing to do */ }