From ff967957f408a71ae1e36d369cff3e3de401b557 Mon Sep 17 00:00:00 2001 From: Bram Matthys Date: Sat, 6 Nov 2021 12:45:07 +0100 Subject: [PATCH] Fix two small memory leaks in extjwt (sfilename, b64sig) and change another one (extjwt_hash_val) to just a simply safe_free() as well which is less error prone (just needs the value to be initialized to NULL at the beginning but that is already done). --- src/modules/extjwt.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/modules/extjwt.c b/src/modules/extjwt.c index 4873ebd45..d1e1529f9 100644 --- a/src/modules/extjwt.c +++ b/src/modules/extjwt.c @@ -596,6 +596,7 @@ int extjwt_configtest(ConfigFile *cf, ConfigEntry *ce, int type, int *errs) extjwt_free_services(&services); if (errors) safe_free(cfg_state.key_filename); + safe_free(sfilename); return errors ? -1 : 1; } @@ -1141,15 +1142,11 @@ char *extjwt_generate_token(const char *payload, struct extjwt_config *config) safe_free(header); safe_free(b64header); safe_free(b64payload); - if (config->method != EXTJWT_METHOD_NONE) - { - safe_free(b64sig); - safe_free(extjwt_hash_val); - } + safe_free(b64sig); + safe_free(extjwt_hash_val); if (retval != b64data) safe_free(b64data); return retval; } -