Bram Matthys
8e3ba03752
Convert remaining GLOBOPS to sendto_umode_global().
...
Yeah, don't worry, the GLOBOPS command will stay too, this is just
an internal cleanup.
2019-10-19 11:50:35 +02:00
Bram Matthys
e0533c5f80
Use client id in SAJOIN and SAPART.
...
This will break logging and oper notices on U4, but we'll deal with that
later in some U4 release.
2019-10-19 11:45:08 +02:00
Bram Matthys
5960c76102
Fix SETNAME not working, reported by s and The_Myth in
...
https://bugs.unrealircd.org/view.php?id=5453
It had the match_spamfilter() logic reversed. I audited all other
calls to the function as well and they are fine.
Also, CHGHOST CHGIDENT CHGNAME SETHOST SETIDENT SETNAME are now
tested by the test framework.
2019-10-19 08:52:59 +02:00
Bram Matthys
04171f7f20
Clean up m_message a bit
2019-10-18 15:00:52 +02:00
Bram Matthys
a72482bbb2
Fix PRIVMSG/NOTICE showing send UID/SID to end-user due to change from
...
a few days ago. Reported by westor.
2019-10-18 14:10:01 +02:00
Bram Matthys
5cd7134cc2
Reject invalid SID from PROTOCTL.
2019-10-18 14:00:46 +02:00
Bram Matthys
9171d58ad0
Some unimportant changes
...
[skip ci]
2019-10-18 13:54:40 +02:00
Bram Matthys
ff067cd826
More kill path stuff gone now.
2019-10-17 07:32:45 +02:00
Bram Matthys
49c2f7c2c3
Get rid of this whole kill path nonsense.
2019-10-16 11:11:46 +02:00
Bram Matthys
d0b9b02d05
We no longer use a blacklist for stats (set::oper-only-stats) but
...
have a whitelist now instead (set::allow-user-stats).
Suggested by tabrisnet, The_Myth and Jobe in
https://bugs.unrealircd.org/view.php?id=3375 and
https://bugs.unrealircd.org/view.php?id=5109
2019-10-14 18:46:14 +02:00
Bram Matthys
63298af6b2
Get rid of BREPORT_xx mess.
2019-10-14 17:36:04 +02:00
Bram Matthys
446f9a89c3
Assume password is sent when allow::password is cert/certfp and client
...
has a SSL/TLS fingerprint. Reported by Stealth in:
https://bugs.unrealircd.org/view.php?id=3372
2019-10-14 15:08:37 +02:00
Bram Matthys
43593d12cb
netinfo.c & server.c: use sendto_umode_global() rather than 2 functions.
2019-10-14 12:23:09 +02:00
Bram Matthys
cc36b34f93
Remove unnecessary (void) casts everywhere.
...
Only use (void) for system/library calls that you want to ignore
explicitly, eg (void)close, if the return value is irrelevant.
2019-10-14 08:23:30 +02:00
Bram Matthys
c60bd2e441
Try to use more me.id where possible (rather than me.name)
2019-10-14 08:09:57 +02:00
Bram Matthys
d724bdc492
Finish up changes from yesterday.
2019-10-14 07:49:23 +02:00
Bram Matthys
f40c9f3c88
Change various client->name to client->id in S2S traffic. More to
...
follow tomorrow, including me.name to me.id changes (though these
are far less important) and send.c + non-sendto_server hunts...
2019-10-13 20:41:13 +02:00
Bram Matthys
44f9423e13
Remove ID() macro as client->id always contains a proper UID now.
2019-10-13 20:11:58 +02:00
Bram Matthys
1dde1721ad
Reorder functions in nick.c in a more logical way. No actual code changes.
...
[skip ci]
2019-10-13 19:47:26 +02:00
Bram Matthys
b9a0f938c0
Cleanup cmd_user since it's now client-only and move the server-bits into cmd_uid.
2019-10-13 19:43:41 +02:00
Bram Matthys
2c337dc58b
Split off cmd_nick in cmd_nick_local and cmd_nick_remote and clean it up.
...
Also, partially cleanup cmd_uid, but still work to be done there (the
last part).
2019-10-13 18:39:10 +02:00
Bram Matthys
746ea5b558
Clean up cmd_server / cmd_sid now that 100% of the network is SID.
2019-10-13 16:22:56 +02:00
Bram Matthys
bcfd2ab529
Rip out support for servers lacking TKLEXT/TKLEXT2 (always send TKLEXT2 format)
2019-10-13 09:39:00 +02:00
Bram Matthys
560b73b6f7
Similar to previous commits, but for UMODE2. Actually no change, though,
...
since lack of UMODE2 was not supported in U4 anyway (maybe even 3.2.x).
2019-10-13 09:35:31 +02:00
Bram Matthys
a9890448d8
Rip out support for servers lacking SJ3
2019-10-13 09:33:39 +02:00
Bram Matthys
545c2560e6
Rip out support for servers lacking SIDs/UIDs.
...
More cleanups will follow later for this one.
2019-10-13 09:24:26 +02:00
Bram Matthys
930ede1c86
Rip out support for servers lacking SJOIN/SJOIN2
2019-10-13 09:09:59 +02:00
Bram Matthys
0670bfffb9
Rip out support for servers lacking NICKIP
2019-10-13 08:59:26 +02:00
Bram Matthys
fb4d994f40
Rip out support for servers lacking NOQUIT.
2019-10-13 08:56:05 +02:00
Bram Matthys
8d5f896790
Rip out support for servers lacking NICKv2
2019-10-13 08:54:16 +02:00
Bram Matthys
c9b88343e2
Fix not seeing own nick change if not in any channels. Reported by westor.
2019-10-12 17:26:29 +02:00
Bram Matthys
8383b714ce
Fix crash on SASL. Reported by westor.
2019-10-12 15:41:58 +02:00
Bram Matthys
d55eb642e5
Fix 421 in restrict-commands, again.
2019-10-11 20:42:05 +02:00
Bram Matthys
139e5faae6
UnrealIRCd 5.0.0-alpha4 (release tomorrow)
2019-10-11 20:31:15 +02:00
Bram Matthys
03645750f1
Protect against services that don't reply to SASL: time out the SASL
...
session after a 15 seconds timeout. The exact timeout value can be
changed by adjusting set::sasl-timeout, which should be (quite a bit)
less than set::handshake-timeout by the way. 15<30 now, so fine.
2019-10-11 19:17:59 +02:00
Bram Matthys
9f2530fdb7
Fix 421 numeric syntax if command is blocked (commit from yesterday).
...
Reported by westor.
2019-10-11 17:07:28 +02:00
Bram Matthys
65f6b97ea7
Advertise as "draft/labeled-response-0.2" rather than "draft/labeled-response".
...
[skip ci]
2019-10-11 15:58:23 +02:00
Bram Matthys
98f1974c8f
Don't fall through (fix for previous commit).
2019-10-11 15:01:19 +02:00
Bram Matthys
77bee69951
Fix Windows build
2019-10-11 14:46:13 +02:00
Bram Matthys
394168c288
Style fixes: "char* " -> "char *" etc.
2019-10-11 12:23:45 +02:00
Bram Matthys
ccaec871bb
And some fixes, to previous commits and older issues.
2019-10-11 12:19:04 +02:00
Bram Matthys
aec54db360
Add is_extended_ban() which does a quick check for "~x:". This, rather
...
than scattered checks - which are sometimes different - everywhere in
the source code.
Also extban handler "is_ok" was being called with EXBTYPE_EXCEPT
rather than EXBTYPE_INVEX for +I. (Not reported by anyone)
2019-10-11 11:17:50 +02:00
Bram Matthys
1d0fa3278f
Protect against flawed S2S traffic: more checks for bad base64
...
encoded IP addresses.
2019-10-11 11:16:16 +02:00
Bram Matthys
3d81c7101c
Merge branch 'unreal50' of github.com:unrealircd/unrealircd into unreal50
2019-10-10 19:51:56 +02:00
Bram Matthys
f7a35bd77e
Fix for change from yesterday in JOIN: parv[1] would point to
...
a stack buffer in do_join but it goes out of scope after a return
from that function, still pointing to invalid data. Duh.
2019-10-10 19:46:08 +02:00
GottemHams
be571f81c6
Changed snotice to numeric 421 for commands disabled/restricted by the restrict-commands module
2019-10-09 21:00:41 +02:00
Bram Matthys
80353cd7d3
Win......
...
[skip ci]
2019-10-09 19:24:09 +02:00
Bram Matthys
e1fdba7931
Windows.......................
2019-10-09 19:16:34 +02:00
Bram Matthys
04334f022e
Fixes for Windows build
2019-10-09 18:20:06 +02:00
Bram Matthys
22dec96f9a
No clean_channelname() anymore but a valid_channelname() function. Also,
...
deal with servers with different set::allowed-channelchars settings:
* We reject the link if set::allowed-channelchars settings differ between
UnrealIRCd 5 servers.
* For the case where you have a mixed network consisting of UnrealIRCd 4.x
and UnrealIRCd 5.x servers we try not to desync, BUT will not allow
anyone to join the invalid channels locally. For IRCOps a message is
printed with additional information on such a failed JOIN attempt.
See https://www.unrealircd.org/docs/Set_block#set::allowed-channelchars
for the different settings, which are best and U4<->U5 advice.
2019-10-09 18:11:02 +02:00