Bram Matthys
447555e044
More consts in stats.c
2021-09-10 15:07:17 +02:00
Bram Matthys
f085173d46
More const char * stuff... mostly in conf.c but also elsewhere.
2021-09-10 15:01:23 +02:00
Bram Matthys
2e82ab0eca
Make CommandOverrideAddEx() the new CommandOverrideAdd():
...
IOTW, change CommandOverrideAdd() to require a priority argument:
- CommandOverrideAdd(modinfo->handle, "TEST", override_test);
+ CommandOverrideAdd(modinfo->handle, "TEST", 0, override_test);
2021-09-10 14:13:07 +02:00
Bram Matthys
bba0124bd3
Drop the Ex... CallbackAdd*Ex() -> CallbackAdd*()
2021-09-10 14:09:22 +02:00
Bram Matthys
6ebddc8817
Update channel mode API to use more consts
2021-09-10 14:06:57 +02:00
Bram Matthys
08a32429ff
Update extban API to use more consts
2021-09-10 13:39:26 +02:00
Bram Matthys
d4d4da6a8d
Add another const to ValidatePermissionsForPath. Fix Windows build, maybe?
2021-09-10 12:58:15 +02:00
Bram Matthys
66a51fb659
Massive conversions from 'char *' to 'const char *' and 'char **' to 'const char **'
2021-09-10 12:46:31 +02:00
Bram Matthys
edfdfe4a03
Add HookAddConstString() and friends.
...
Also EfunctionAddPChar() -> EfunctionAddString(), and callbacks etc.
2021-09-10 11:59:14 +02:00
Bram Matthys
a3bfa210e9
HookAddPChar() -> HookAddString()
...
and .pcharfunc -> .stringfunc
2021-09-10 11:49:06 +02:00
Bram Matthys
fe3907f153
Use more const char *
2021-09-10 11:39:04 +02:00
Bram Matthys
d648cd0729
Use strlncpy() everywhere where we previously used strlncat() with a empty
...
buffer (due to the lack of strlncpy before...).
2021-09-10 11:26:36 +02:00
Bram Matthys
c550d95619
Add strlncpy(): works just like strlcpy except that it has an extra
...
argument which specifies how many characters to copy max.
strlncpy(dest, src, sizeof(dest), maxcopybytes);
vs
strlcpy(dest, src, MIN(sizeof(dest),maxcopybytes+1));
We already had a strlncat() vs strlcat()
2021-09-10 11:19:57 +02:00
Bram Matthys
cd88e02f3d
Use more const char *
2021-09-10 11:11:54 +02:00
Bram Matthys
463c7d4ddf
Spoof remote connecting/disconnecting notices with sender being the
...
server where the client is (or was) on. Just like we did in UnrealIRCd 5.
Not sure if API-wise and variable-name-wise I want to do it this way,
but whatever...
2021-09-10 08:54:29 +02:00
k4be
59888af8db
Fix crash on failed file download while rehashing
2021-09-05 19:56:41 +02:00
Bram Matthys
4ef3b9f000
Add BSDmakefile with a note to run 'gmake' for BSD users.
...
Also, check for GNU make (which can be either 'make' or 'gmake')
early in ./Config and print out an error to install prerequisites
from https://www.unrealircd.org/docs/Installing_from_source
This also replaces 'make' with ${MAKE} (and such) everywhere.
2021-09-04 09:31:30 +02:00
Bram Matthys
894b7e5461
Makefiles: switch from suffix rules to pattern rules. As suffix rules
...
can't have dependencies, so if you change a .h file, it fails to
recompile the other dependencies. Grmpf!
This does mean that we require GNU Make (gmake) from now on.
2021-09-04 08:25:18 +02:00
Bram Matthys
9ef1d06afd
Remove more unused stuff in dynconf.h, and drop set::dns which did
...
nothing since 3.2 or so.
2021-09-03 21:17:51 +02:00
Bram Matthys
13dc17f5dc
Code cleanup: remove unused structs and variables.
2021-09-03 21:07:38 +02:00
Bram Matthys
617288991e
Remove find_except(), conf_except and struct ConfigItem_except.
...
These are all unused since the addition of ELINE.
2021-09-03 20:46:06 +02:00
k4be
8c6f94ffef
metadata debug: remove command logging and replace last sendto_snomask with unreal_log.
...
Also get rid of unused trylater variable.
2021-09-03 18:54:19 +02:00
Bram Matthys
4a82b89793
Code cleanup in tkl.c: get rid of confusing 'whattodo' and use 'add'
...
which is 1/0 so that the meaning is straightforward.
2021-09-03 11:05:19 +02:00
Bram Matthys
16179b9c00
Don't log add_config_resource() debug code by default.
2021-09-03 10:37:51 +02:00
Bram Matthys
a9833ebedf
Fix crash on empty remote METADATA (bad S2S traffic).
2021-09-03 08:50:16 +02:00
Bram Matthys
c4a4867ca5
More goto's make the world a better place.
...
Oh and also fix a memory leak in parse_extended_server_ban().
2021-09-03 08:06:03 +02:00
Bram Matthys
1f2e79b64c
Fix missing return after exit_client() in PROTOCTL.
...
This caused client->server to be NULL and then when processing
another PROTOCTL parameter this would cause a crash.
2021-09-02 18:15:12 +02:00
Bram Matthys
725e03e1e9
Simplify identical_ban(), it was never perfect anyway.
2021-09-02 17:20:54 +02:00
Bram Matthys
9cdd90e848
Ignore remote MONITOR requests.
...
(Fixes crash with faulty S2S traffic)
2021-09-02 17:08:10 +02:00
Bram Matthys
5b9c419041
Add parse_extended_server_ban(). This makes named extended server bans
...
working now (eg ELINE ~certfp:xyz etc).
Also fixes a crash due to an OOB read.
2021-09-02 17:01:20 +02:00
Bram Matthys
9952a8e98f
Be more careful in json_expand_client() when called for a server that is
...
only partially a server yet: IsServer() is true but client->server is NULL.
Fixes a crash when called from PROTOCTL.
Actually not entirely sure if this happens in practice, but better safe
than sorry.
2021-09-02 15:59:43 +02:00
Bram Matthys
fa5c9039a2
Put the same extban rule checks in extban_is_ok_nuh_extban() as they
...
already were in extban_conv_param_nuh_or_extban().
The recursion check was already there, but not the "rule 2 violation"
if ((extban->options & EXTBOPT_ACTMODIFIER) || (extban->options & EXTBOPT_NOSTACKCHILD))
This also backs out the temporary fix 5df1b1b889 .
2021-09-02 15:51:11 +02:00
k4be
459deb3084
Actually, ignore all s2s PROTOCTL from users
2021-08-31 16:35:59 +02:00
k4be
45775d1929
Fix crash on bad s2s INVITE command
2021-08-31 15:18:21 +02:00
k4be
f4ad2416a7
Make server name check a bit more strict
...
(% characters made sendnumeric generate invalid format strings)
2021-08-31 13:38:14 +02:00
k4be
5df1b1b889
Workaround crash with stacked multiple ~f bans
...
This should probably be fixed properly later.
2021-08-31 13:00:47 +02:00
k4be
7f958b7dad
Fix crash for setting channel metadata by unregistered connections
2021-08-31 12:59:46 +02:00
k4be
c711bc6dfb
Fix named extban name comparison
...
(was accepting names with extra stuff after a valid name)
2021-08-30 18:35:58 +02:00
k4be
228f6f05af
Ignore PROTOCTL EAUTH from users
2021-08-30 09:29:32 +02:00
Bram Matthys
8caeae6f82
Fix crash on PROTOCTL EAUTH=
2021-08-29 14:08:12 +02:00
k4be
420ebd7900
Get rid of NULL va_list compiler error
2021-08-29 12:35:29 +02:00
Bram Matthys
07390d093f
Remove modules/mdex which is an example that shouldn't be used/built
...
(with UnrealIRCd anyway)
[skip ci]
2021-08-29 12:04:54 +02:00
Bram Matthys
c28239dd68
Set User-Agent in url_curl as well (already done in url_unreal).
2021-08-28 20:37:09 +02:00
Bram Matthys
be67bdc342
Update Windows installer to include Jansson
...
[skip ci]
2021-08-28 17:30:38 +02:00
Bram Matthys
c455c1ae52
unrealircd-5-libs -> unrealircd-6-libs
...
[skip ci]
2021-08-28 17:26:15 +02:00
Bram Matthys
4c2aeab75e
Windows compile fixes
2021-08-28 16:35:37 +02:00
Bram Matthys
4cee60840a
Compile oldcloak.so now that it was moved from R_MODULES to MODULES
...
in the src/modules/Makefile
2021-08-27 19:43:18 +02:00
Bram Matthys
1b096b5146
Use good ol suffix rules in Makefile so we can get rid of writing out
...
every .o and .so rule. Writing each of them out manually is useless
for all except 3 of the ~250 objects.
2021-08-27 19:36:07 +02:00
k4be
211995f703
geoip_maxmind: fix indentations
2021-08-27 15:00:20 +02:00
k4be
9c3d5dffb0
Add libmaxminddb support
2021-08-27 14:49:13 +02:00