From 0845911c6b60177d17808d35e387205d40a6df5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Helleu?= Date: Sun, 31 Aug 2014 17:00:47 +0200 Subject: [PATCH] core: change comment about linker and circular references problems with static libs --- src/gui/curses/CMakeLists.txt | 2 +- src/gui/curses/Makefile.am | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gui/curses/CMakeLists.txt b/src/gui/curses/CMakeLists.txt index 57148d31b..23a977a46 100644 --- a/src/gui/curses/CMakeLists.txt +++ b/src/gui/curses/CMakeLists.txt @@ -81,7 +81,7 @@ add_executable(${EXECUTABLE} ${WEECHAT_CURSES_MAIN_SRC}) add_dependencies(${EXECUTABLE} weechat_gui_curses) -# Because of a linker bug, we have to link 2 times with libweechat_core.a +# Due to circular references, we must link two times with libweechat_core.a target_link_libraries(${EXECUTABLE} ${STATIC_LIBS} weechat_gui_curses ${EXTRA_LIBS} ${STATIC_LIBS}) install(TARGETS ${EXECUTABLE} RUNTIME DESTINATION bin) diff --git a/src/gui/curses/Makefile.am b/src/gui/curses/Makefile.am index b31073f39..18afc2fd3 100644 --- a/src/gui/curses/Makefile.am +++ b/src/gui/curses/Makefile.am @@ -33,8 +33,8 @@ lib_weechat_gui_curses_a_SOURCES = gui-curses-bar-window.c \ bin_PROGRAMS = weechat -# Because of a linker bug, we have to link 2 times with lib_weechat_core.a -# (and it must be 2 different path/names to be kept by linker) +# Due to circular references, we must link two times with libweechat_core.a +# (and with two different path/names to be kept by linker) weechat_LDADD = ./../../core/lib_weechat_core.a \ ../../plugins/lib_weechat_plugins.a \ ../lib_weechat_gui_common.a \