pegasus/weechat
1
0
Fork 0
mirror of https://github.com/weechat/weechat.git synced 2026-07-02 07:46:38 +02:00
Code Activity

logger: remove check of NULL pointers before calling free() (issue #865)

Browse Source
This commit is contained in:
Sébastien Helleu
2024-04-24 23:34:00 +02:00
parent 846c785531
commit 128d2a4e12
4 changed files with 20 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/plugins/logger/logger-buffer.c
+5 -10
View File
@@ -325,10 +325,8 @@ logger_buffer_create_log_file (struct t_logger_buffer *logger_buffer)
weechat_iconv_from_internal (charset, buf_beginning) : NULL;
fprintf (logger_buffer->log_file,
"%s\n", (message) ? message : buf_beginning);
if (charset)
free (charset);
if (message)
free (message);
free (charset);
free (message);
logger_buffer->flush_needed = 1;
}
logger_buffer->write_start_info_line = 0;
@@ -635,10 +633,8 @@ logger_buffer_write_line (struct t_logger_buffer *logger_buffer,
weechat_iconv_from_internal (charset, vbuffer) : NULL;
fprintf (logger_buffer->log_file,
"%s\n", (message) ? message : vbuffer);
if (charset)
free (charset);
if (message)
free (message);
free (charset);
free (message);
logger_buffer->flush_needed = 1;
if (!logger_hook_timer)
{
@@ -878,8 +874,7 @@ logger_buffer_free (struct t_logger_buffer *logger_buffer)
(logger_buffer->next_buffer)->prev_buffer = logger_buffer->prev_buffer;
/* free data */
if (logger_buffer->log_filename)
free (logger_buffer->log_filename);
free (logger_buffer->log_filename);
if (logger_buffer->log_file)
fclose (logger_buffer->log_file);