From 4fe1ba70168ee1eb93b5d0b3d057f464ac03f2f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Helleu?= Date: Fri, 18 Aug 2023 07:34:52 +0200 Subject: [PATCH] tests: fix tests on function irc_join_compare_join_channel (issue #1997) --- ChangeLog.adoc | 4 ++++ tests/unit/plugins/irc/test-irc-join.cpp | 8 ++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/ChangeLog.adoc b/ChangeLog.adoc index b8f942e60..7f7d77231 100644 --- a/ChangeLog.adoc +++ b/ChangeLog.adoc @@ -20,6 +20,10 @@ Bug fixes:: * irc: add missing tags on multiline messages (issue #1987) * irc: fix redirection of command `/list` when the reply doesn't start with message 321 (start of /list) +Tests:: + + * irc: fix tests on function irc_join_compare_join_channel (issue #1997) + [[v4.0.3]] == Version 4.0.3 (2023-08-08) diff --git a/tests/unit/plugins/irc/test-irc-join.cpp b/tests/unit/plugins/irc/test-irc-join.cpp index 57ede5800..68d6588e5 100644 --- a/tests/unit/plugins/irc/test-irc-join.cpp +++ b/tests/unit/plugins/irc/test-irc-join.cpp @@ -129,24 +129,24 @@ TEST(IrcJoin, CompareJoinChannel) LONGS_EQUAL(0, irc_join_compare_join_channel (NULL, &join_chan1, &join_chan2)); join_chan1.name = strdup ("#abc"); - LONGS_EQUAL(35, irc_join_compare_join_channel (NULL, &join_chan1, &join_chan2)); + CHECK(irc_join_compare_join_channel (NULL, &join_chan1, &join_chan2) > 0); join_chan2.name = strdup ("#abc"); LONGS_EQUAL(0, irc_join_compare_join_channel (NULL, &join_chan1, &join_chan2)); join_chan1.key = strdup ("key_abc"); - LONGS_EQUAL(-1, irc_join_compare_join_channel (NULL, &join_chan1, &join_chan2)); + CHECK(irc_join_compare_join_channel (NULL, &join_chan1, &join_chan2) < 0); join_chan2.key = strdup ("key_abc"); LONGS_EQUAL(0, irc_join_compare_join_channel (NULL, &join_chan1, &join_chan2)); free (join_chan2.key); join_chan2.key = strdup ("key2_abc"); - LONGS_EQUAL(45, irc_join_compare_join_channel (NULL, &join_chan1, &join_chan2)); + CHECK(irc_join_compare_join_channel (NULL, &join_chan1, &join_chan2) > 0); free (join_chan2.name); join_chan2.name = strdup ("#def"); - LONGS_EQUAL(-3, irc_join_compare_join_channel (NULL, &join_chan1, &join_chan2)); + CHECK(irc_join_compare_join_channel (NULL, &join_chan1, &join_chan2) < 0); free (join_chan1.name); free (join_chan1.key);