From 53a9a161f41bae36059ccd083d60544cb80f8a75 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Helleu?= Date: Sun, 10 Aug 2014 10:52:04 +0200 Subject: [PATCH] core: fix memory leak on /upgrade when file signature in upgrade file is invalid --- ChangeLog.asciidoc | 2 ++ src/core/wee-upgrade-file.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/ChangeLog.asciidoc b/ChangeLog.asciidoc index eee79e5d6..0dae0754a 100644 --- a/ChangeLog.asciidoc +++ b/ChangeLog.asciidoc @@ -15,6 +15,8 @@ http://weechat.org/files/releasenotes/ReleaseNotes-devel.html[release notes] == Version 1.0 (under dev) +* core: fix memory leak on /upgrade when file signature in upgrade file is + invalid * core: fix memory leak in completion of config options values * core: fix memory leak when removing script files * core: fix result of hash function (in hashtables) on 32-bit systems diff --git a/src/core/wee-upgrade-file.c b/src/core/wee-upgrade-file.c index b8d43b8ba..996d70acd 100644 --- a/src/core/wee-upgrade-file.c +++ b/src/core/wee-upgrade-file.c @@ -759,6 +759,8 @@ upgrade_file_read (struct t_upgrade_file *upgrade_file, { UPGRADE_ERROR(_("read - bad signature (upgrade file format may have " "changed since last version)"), ""); + if (signature) + free (signature); return 0; }