From 711d3afa5c2d6c367a5f05886f8bde566698b3dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Helleu?= Date: Sun, 27 Aug 2023 17:19:01 +0200 Subject: [PATCH] script: fix crash when a `/script` command triggers another `/script` command (issue #923) --- ChangeLog.adoc | 1 + src/plugins/script/script-action.c | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ChangeLog.adoc b/ChangeLog.adoc index ef2dcfa50..9d4a9b1d7 100644 --- a/ChangeLog.adoc +++ b/ChangeLog.adoc @@ -56,6 +56,7 @@ Bug fixes:: * irc: add missing "account-tag" in list of supported capabilities * irc: add channel in "autojoin" server option only when the channel is actually joined (issue #1990) * relay: synchronize nick modes with IRC client upon connection (issue #1984) + * script: fix crash when a `/script` command triggers another `/script` command (issue #923) * script: add local key bindings during the buffer creation * script: add parameters up/down/go in `/help script` and command completion * script: fix cursor position after `/script list -i` or `/script list -il` diff --git a/src/plugins/script/script-action.c b/src/plugins/script/script-action.c index eae0e63d3..7de928e3a 100644 --- a/src/plugins/script/script-action.c +++ b/src/plugins/script/script-action.c @@ -1300,6 +1300,9 @@ script_action_run_all () | WEECHAT_STRING_SPLIT_STRIP_RIGHT | WEECHAT_STRING_SPLIT_COLLAPSE_SEPS, 0, &num_actions); + + script_action_clear (); + if (actions) { for (i = 0; i < num_actions; i++) @@ -1564,8 +1567,6 @@ script_action_run_all () weechat_string_free_split (actions); } - script_action_clear (); - return 1; }