pegasus/weechat
1
0
Fork 0
mirror of https://github.com/weechat/weechat.git synced 2026-06-30 23:06:38 +02:00
Code Activity

Add API version string: do not load plugins with wrong API version (fix crash when loading old/obsolete plugins)

Browse Source
This commit is contained in:
Sebastien Helleu
2009-05-02 22:56:14 +02:00
parent 9cb6b4d158
commit 747b78aff3
10 changed files with 103 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/plugins/plugin.c
+30 -3
View File
@@ -155,8 +155,8 @@ plugin_load (const char *filename)
{
char *ptr_home, *full_name, *full_name2;
void *handle;
char *name, *author, *description, *version, *weechat_version, *license;
char *charset;
char *name, *api_version, *author, *description, *version;
char *weechat_version, *license, *charset;
t_weechat_init_func *init_func;
int rc, i, argc;
char **argv;
@@ -206,6 +206,34 @@ plugin_load (const char *filename)
return NULL;
}
/* look for API version */
api_version = dlsym (handle, "weechat_plugin_api_version");
if (!api_version)
{
gui_chat_printf (NULL,
_("%sError: symbol \"%s\" not found in "
"plugin \"%s\", failed to load"),
gui_chat_prefix[GUI_CHAT_PREFIX_ERROR],
"weechat_plugin_api_version",
full_name);
dlclose (handle);
free (full_name);
return NULL;
}
if (strcmp (api_version, WEECHAT_PLUGIN_API_VERSION) != 0)
{
gui_chat_printf (NULL,
_("%sError: API mismatch for plugin \"%s\" (current "
"API: \"%s\", plugin API: \"%s\"), failed to load"),
gui_chat_prefix[GUI_CHAT_PREFIX_ERROR],
full_name,
WEECHAT_PLUGIN_API_VERSION,
api_version);
dlclose (handle);
free (full_name);
return NULL;
}
/* check for plugin with same name */
if (plugin_search (name))
{
@@ -278,7 +306,6 @@ plugin_load (const char *filename)
free (full_name);
return NULL;
}
if (util_weechat_version_cmp (PACKAGE_VERSION, weechat_version) != 0)
{
gui_chat_printf (NULL,
src/plugins/weechat-plugin.h
+6 -2
View File
@@ -32,9 +32,13 @@ struct t_gui_completion;
struct t_infolist;
struct t_weelist;
/* API version (used to check that plugin has same API and can be loaded) */
#define WEECHAT_PLUGIN_API_VERSION "20090502-01"
/* macros for defining plugin infos */
#define WEECHAT_PLUGIN_NAME(__name) \
char weechat_plugin_name[] = __name;
#define WEECHAT_PLUGIN_NAME(__name) \
char weechat_plugin_name[] = __name; \
char weechat_plugin_api_version[] = WEECHAT_PLUGIN_API_VERSION;
#define WEECHAT_PLUGIN_AUTHOR(__author) \
char weechat_plugin_author[] = __author;
#define WEECHAT_PLUGIN_DESCRIPTION(__desc) \