From b2c7682242d6e8527e480ee2ff668841fc494e7e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Helleu?= <flashcode@flashtux.org>
Date: Wed, 8 May 2024 11:18:46 +0200
Subject: [PATCH] core: add function gui_buffer_set_notify

---
 src/gui/gui-buffer.c               | 66 +++++++++++++++++++-----------
 tests/unit/gui/test-gui-buffer.cpp | 10 +++++
 2 files changed, 51 insertions(+), 25 deletions(-)

diff --git a/src/gui/gui-buffer.c b/src/gui/gui-buffer.c
index 5cb028136..144d3182d 100644
--- a/src/gui/gui-buffer.c
+++ b/src/gui/gui-buffer.c
@@ -1736,6 +1736,46 @@ gui_buffer_set_type (struct t_gui_buffer *buffer, enum t_gui_buffer_type type)
                                    WEECHAT_HOOK_SIGNAL_POINTER, buffer);
 }
 
+/*
+ * Sets notify for a buffer.
+ */
+
+void
+gui_buffer_set_notify (struct t_gui_buffer *buffer, const char *notify)
+{
+    const char *ptr_notify;
+    char *error;
+    long number;
+    int mute_old;
+
+    if (!buffer)
+        return;
+
+    ptr_notify = NULL;
+    error = NULL;
+    number = strtol (notify, &error, 10);
+    if (error && !error[0])
+    {
+        if (number < GUI_BUFFER_NUM_NOTIFY)
+        {
+            if (number < 0)
+                number = CONFIG_ENUM(config_look_buffer_notify_default);
+            ptr_notify = gui_buffer_notify_string[number];
+        }
+    }
+    else
+    {
+        ptr_notify = notify;
+    }
+    if (ptr_notify)
+    {
+        mute_old = gui_chat_mute;
+        gui_chat_mute = GUI_CHAT_MUTE_ALL_BUFFERS;
+        config_weechat_notify_set (buffer, ptr_notify);
+        gui_chat_mute = mute_old;
+    }
+}
+
 /*
  * Sets title for a buffer.
  */
@@ -2447,10 +2487,8 @@ void
 gui_buffer_set (struct t_gui_buffer *buffer, const char *property,
                 const char *value)
 {
-    int gui_chat_mute_old;
     long number;
     char *error;
-    const char *ptr_notify;
 
     if (!property || !value)
         return;
@@ -2575,29 +2613,7 @@ gui_buffer_set (struct t_gui_buffer *buffer, const char *property,
     }
     else if (strcmp (property, "notify") == 0)
     {
-        ptr_notify = NULL;
-        error = NULL;
-        number = strtol (value, &error, 10);
-        if (error && !error[0])
-        {
-            if (number < GUI_BUFFER_NUM_NOTIFY)
-            {
-                if (number < 0)
-                    number = CONFIG_ENUM(config_look_buffer_notify_default);
-                ptr_notify = gui_buffer_notify_string[number];
-            }
-        }
-        else
-        {
-            ptr_notify = value;
-        }
-        if (ptr_notify)
-        {
-            gui_chat_mute_old = gui_chat_mute;
-            gui_chat_mute = GUI_CHAT_MUTE_ALL_BUFFERS;
-            config_weechat_notify_set (buffer, ptr_notify);
-            gui_chat_mute = gui_chat_mute_old;
-        }
+        gui_buffer_set_notify (buffer, value);
     }
     else if (strcmp (property, "title") == 0)
     {
diff --git a/tests/unit/gui/test-gui-buffer.cpp b/tests/unit/gui/test-gui-buffer.cpp
index 9d72f225f..38fab1f54 100644
--- a/tests/unit/gui/test-gui-buffer.cpp
+++ b/tests/unit/gui/test-gui-buffer.cpp
@@ -1001,6 +1001,16 @@ TEST(GuiBuffer, SetType)
     /* TODO: write tests */
 }
 
+/*
+ * Tests functions:
+ *   gui_buffer_set_notify
+ */
+
+TEST(GuiBuffer, SetNotify)
+{
+    /* TODO: write tests */
+}
+
 /*
  * Tests functions:
  *   gui_buffer_set_title