From b4d999010a535ccbc2fbedfaed4e24f308feb006 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Helleu?= Date: Tue, 27 Jun 2023 12:56:42 +0200 Subject: [PATCH] api: do not convert option name to lower case in API functions config_set_plugin and config_set_desc_plugin --- ChangeLog.adoc | 1 + ReleaseNotes.adoc | 8 ++++++++ src/plugins/plugin-config.c | 19 ++++--------------- 3 files changed, 13 insertions(+), 15 deletions(-) diff --git a/ChangeLog.adoc b/ChangeLog.adoc index a0a1f728b..a72a5009c 100644 --- a/ChangeLog.adoc +++ b/ChangeLog.adoc @@ -17,6 +17,7 @@ Bug fixes:: * core: force key "return" to command "/input return" when migrating legacy keys * core: display actual key name and command with key kbd:[Alt+k], remove key kbd:[Alt+K] (grab raw key) and associated commands `/input grab_raw_key` and `/input grab_raw_key_command` + * api: do not convert option name to lower case in API functions config_set_plugin and config_set_desc_plugin * irc: reply to a CTCP request sent to self nick (issue #1966) * irc: sent "QUIT" message to servers connected with TLS on `/upgrade` diff --git a/ReleaseNotes.adoc b/ReleaseNotes.adoc index 974644bbd..52876327b 100644 --- a/ReleaseNotes.adoc +++ b/ReleaseNotes.adoc @@ -14,6 +14,14 @@ For a complete list of changes, please look at ChangeLog. [[v4.0.1]] == Version 4.0.1 (under dev) +[[v4.0.1_config_set_plugin]] +=== Functions config_set_plugin and config_set_desc_plugin + +The functions link:https://weechat.org/doc/weechat/plugin/#_config_set_plugin[config_set_plugin] +and link:https://weechat.org/doc/weechat/plugin/#_config_set_desc_plugin[config_set_desc_plugin] +are not converting any more the option name to lower case because since version 4.0.0, +the name of options is case sensitive. + [[v4.0.1_grab_raw_key]] === Grab raw key and command diff --git a/src/plugins/plugin-config.c b/src/plugins/plugin-config.c index 14f717439..4e318e3da 100644 --- a/src/plugins/plugin-config.c +++ b/src/plugins/plugin-config.c @@ -114,7 +114,7 @@ plugin_config_set (const char *plugin_name, const char *option_name, const char *value) { int length, rc; - char *option_full_name, *option_full_name_lower; + char *option_full_name; rc = WEECHAT_CONFIG_OPTION_SET_ERROR; @@ -124,12 +124,7 @@ plugin_config_set (const char *plugin_name, const char *option_name, { snprintf (option_full_name, length, "%s.%s", plugin_name, option_name); - option_full_name_lower = string_tolower (option_full_name); - if (option_full_name_lower) - { - rc = plugin_config_set_internal (option_full_name_lower, value); - free (option_full_name_lower); - } + rc = plugin_config_set_internal (option_full_name, value); free (option_full_name); } @@ -206,7 +201,7 @@ plugin_config_set_desc (const char *plugin_name, const char *option_name, const char *description) { int length; - char *option_full_name, *option_full_name_lower; + char *option_full_name; length = strlen (plugin_name) + 1 + strlen (option_name) + 1; option_full_name = malloc (length); @@ -214,13 +209,7 @@ plugin_config_set_desc (const char *plugin_name, const char *option_name, { snprintf (option_full_name, length, "%s.%s", plugin_name, option_name); - option_full_name_lower = string_tolower (option_full_name); - if (option_full_name_lower) - { - plugin_config_set_desc_internal (option_full_name_lower, - description); - free (option_full_name_lower); - } + plugin_config_set_desc_internal (option_full_name, description); free (option_full_name); } }