From c7090ae14a0ae8bb9334a0bf8dd1c5083171f783 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Helleu?= <flashcode@flashtux.org>
Date: Sun, 19 Mar 2023 16:05:03 +0100
Subject: [PATCH] core: use a fixed size buffer to create a bar option

---
 src/gui/gui-bar.c | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/src/gui/gui-bar.c b/src/gui/gui-bar.c
index 7145931a2..aa4d69325 100644
--- a/src/gui/gui-bar.c
+++ b/src/gui/gui-bar.c
@@ -1311,18 +1311,12 @@ struct t_config_option *
 gui_bar_create_option (const char *bar_name, int index_option, const char *value)
 {
     struct t_config_option *ptr_option;
-    int length;
-    char *option_name;
+    char option_name[4096];
 
     ptr_option = NULL;
 
-    length = strlen (bar_name) + 1 +
-        strlen (gui_bar_option_string[index_option]) + 1;
-    option_name = malloc (length);
-    if (!option_name)
-        return NULL;
-
-    snprintf (option_name, length, "%s.%s",
+    snprintf (option_name, sizeof (option_name),
+              "%s.%s",
               bar_name, gui_bar_option_string[index_option]);
 
     switch (index_option)
@@ -1499,8 +1493,6 @@ gui_bar_create_option (const char *bar_name, int index_option, const char *value
             break;
     }
 
-    free (option_name);
-
     return ptr_option;
 }