pegasus/weechat
1
0
Fork 0
mirror of https://github.com/weechat/weechat.git synced 2026-07-10 11:43:13 +02:00
Code Activity

core: fix potential memory leak with infolists not freed in plugins (debian #751108)

Browse Source 
The memory leak should not happen if infolists are properly freed by plugins,
and it happened only on unload of plugins (or exit).
This commit is contained in:
Sébastien Helleu
2014-06-10 20:14:24 +02:00
parent 955ed344c2
commit d0fa44865c
6 changed files with 31 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/wee-infolist.h
+1 -1
View File
@@ -68,7 +68,7 @@ extern struct t_infolist *last_weechat_infolist;
/* list functions */
extern struct t_infolist *infolist_new ();
extern struct t_infolist *infolist_new (struct t_weechat_plugin *plugin);
extern int infolist_valid (struct t_infolist *infolist);
extern struct t_infolist_item *infolist_new_item (struct t_infolist *infolist);
extern struct t_infolist_var *infolist_new_var_integer (struct t_infolist_item *item,
src/core/wee-upgrade-file.c
+1 -1
View File
@@ -618,7 +618,7 @@ upgrade_file_read_object (struct t_upgrade_file *upgrade_file)
goto end;
}
infolist = infolist_new ();
infolist = infolist_new (NULL);
if (!infolist)
{
UPGRADE_ERROR(_("read - infolist creation"), "");
src/core/wee-upgrade.c
+7 -7
View File
@@ -75,7 +75,7 @@ upgrade_weechat_save_history (struct t_upgrade_file *upgrade_file,
if (!last_history)
return 1;
ptr_infolist = infolist_new ();
ptr_infolist = infolist_new (NULL);
if (!ptr_infolist)
return 0;
@@ -128,7 +128,7 @@ upgrade_weechat_save_buffers (struct t_upgrade_file *upgrade_file)
ptr_buffer = ptr_buffer->next_buffer)
{
/* save buffer */
ptr_infolist = infolist_new ();
ptr_infolist = infolist_new (NULL);
if (!ptr_infolist)
return 0;
if (!gui_buffer_add_to_infolist (ptr_infolist, ptr_buffer))
@@ -146,7 +146,7 @@ upgrade_weechat_save_buffers (struct t_upgrade_file *upgrade_file)
/* save nicklist */
if (ptr_buffer->nicklist)
{
ptr_infolist = infolist_new ();
ptr_infolist = infolist_new (NULL);
if (!ptr_infolist)
return 0;
if (!gui_nicklist_add_to_infolist (ptr_infolist, ptr_buffer, NULL))
@@ -166,7 +166,7 @@ upgrade_weechat_save_buffers (struct t_upgrade_file *upgrade_file)
for (ptr_line = ptr_buffer->own_lines->first_line; ptr_line;
ptr_line = ptr_line->next_line)
{
ptr_infolist = infolist_new ();
ptr_infolist = infolist_new (NULL);
if (!ptr_infolist)
return 0;
if (!gui_line_add_to_infolist (ptr_infolist,
@@ -212,7 +212,7 @@ upgrade_weechat_save_misc (struct t_upgrade_file *upgrade_file)
struct t_infolist_item *ptr_item;
int rc;
ptr_infolist = infolist_new ();
ptr_infolist = infolist_new (NULL);
if (!ptr_infolist)
return 0;
@@ -264,7 +264,7 @@ upgrade_weechat_save_hotlist (struct t_upgrade_file *upgrade_file)
for (ptr_hotlist = gui_hotlist; ptr_hotlist;
ptr_hotlist = ptr_hotlist->next_hotlist)
{
ptr_infolist = infolist_new ();
ptr_infolist = infolist_new (NULL);
if (!ptr_infolist)
return 0;
if (!gui_hotlist_add_to_infolist (ptr_infolist, ptr_hotlist))
@@ -298,7 +298,7 @@ upgrade_weechat_save_layout_window_tree (struct t_upgrade_file *upgrade_file,
struct t_infolist *ptr_infolist;
int rc;
ptr_infolist = infolist_new ();
ptr_infolist = infolist_new (NULL);
if (!ptr_infolist)
return 0;