From dbcb8d3dbf3c4247d675ac87f0e4255bbfddc564 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Helleu?= Date: Sat, 27 May 2023 11:53:12 +0200 Subject: [PATCH] irc: remove extra space in CTCP ACTION message sent without arguments Now when doing `/me` (without arguments), the message sent is: PRIVMSG #test :\x01ACTION\x01 instead of: PRIVMSG #test :\x01ACTION \x01 --- ChangeLog.adoc | 1 + src/plugins/irc/irc-command.c | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ChangeLog.adoc b/ChangeLog.adoc index 15508ae39..fe1d2ad40 100644 --- a/ChangeLog.adoc +++ b/ChangeLog.adoc @@ -92,6 +92,7 @@ Bug fixes:: * irc: add missing tag "log3" in notify messages * irc: add missing tags "irc_cap" and "log3" in cap messages (client capability) * irc: fix split of CTCP message with no arguments + * irc: remove extra space in CTCP ACTION message sent without arguments * lua: fix crash with print when the value to print is not a string (issue #1904, issue #1905) * ruby: fix crash on quit when a child process is still running (issue #1889, issue #1915) * script: remove trailing "J" (line feed char) in source of scripts displayed diff --git a/src/plugins/irc/irc-command.c b/src/plugins/irc/irc-command.c index a301b76eb..1d2d88d29 100644 --- a/src/plugins/irc/irc-command.c +++ b/src/plugins/irc/irc-command.c @@ -1120,9 +1120,10 @@ irc_command_me_channel_message (struct t_irc_server *server, server, IRC_SERVER_SEND_OUTQ_PRIO_HIGH | IRC_SERVER_SEND_RETURN_LIST, NULL, - "PRIVMSG %s :\01ACTION %s\01", + "PRIVMSG %s :\01ACTION%s%s\01", channel->name, - message); + (message && message[0]) ? " " : "", + (message && message[0]) ? message : ""); if (list_messages) { list_size = weechat_arraylist_size (list_messages);