pegasus/weechat
1
0
Fork 0
mirror of https://github.com/weechat/weechat.git synced 2026-06-28 13:56:37 +02:00
Code Activity

relay/api: return an error 400 when URL parameters "nicks", "lines" and "lines_free" have an invalid value

Browse Source
This commit is contained in:
Sébastien Helleu
2025-10-26 08:07:23 +01:00
parent 58c873809b
commit e637e0de1c
5 changed files with 118 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/plugins/relay/api/relay-api-protocol.c
+40 -6
View File
@@ -579,7 +579,13 @@ RELAY_API_PROTOCOL_CALLBACK(buffers)
}
}
nicks = relay_http_get_param_boolean (client->http_req, "nicks", 0);
if (!relay_http_get_param_boolean (client->http_req, "nicks", 0, &nicks))
{
relay_api_msg_send_error_json (client, RELAY_HTTP_400_BAD_REQUEST, NULL,
"Invalid parameter \"%s\"",
"nicks");
return RELAY_API_PROTOCOL_RC_OK;
}
colors = RELAY_API_COLORS_ANSI;
ptr_colors = weechat_hashtable_get (client->http_req->params, "colors");
if (ptr_colors)
@@ -623,7 +629,16 @@ RELAY_API_PROTOCOL_CALLBACK(buffers)
}
else
{
lines = relay_http_get_param_long (client->http_req, "lines", LONG_MAX);
if (!relay_http_get_param_long (client->http_req, "lines", LONG_MAX, &lines))
{
relay_api_msg_send_error_json (
client,
RELAY_HTTP_400_BAD_REQUEST,
NULL,
"Invalid query string parameter \"%s\"",
"lines");
return RELAY_API_PROTOCOL_RC_OK;
}
json = relay_api_msg_lines_to_json (ptr_buffer, lines, colors);
if (json)
{
@@ -655,10 +670,29 @@ RELAY_API_PROTOCOL_CALLBACK(buffers)
}
else
{
lines = relay_http_get_param_long (client->http_req, "lines", 0L);
lines_free = relay_http_get_param_long (client->http_req,
"lines_free",
(lines == 0) ? 0 : LONG_MAX);
if (!relay_http_get_param_long (client->http_req, "lines", 0L, &lines))
{
relay_api_msg_send_error_json (
client,
RELAY_HTTP_400_BAD_REQUEST,
NULL,
"Invalid query string parameter \"%s\"",
"lines");
return RELAY_API_PROTOCOL_RC_OK;
}
if (!relay_http_get_param_long (client->http_req,
"lines_free",
(lines == 0) ? 0 : LONG_MAX,
&lines_free))
{
relay_api_msg_send_error_json (
client,
RELAY_HTTP_400_BAD_REQUEST,
NULL,
"Invalid query string parameter \"%s\"",
"lines_free");
return RELAY_API_PROTOCOL_RC_OK;
}
if (ptr_buffer)
{
json = relay_api_msg_buffer_to_json (ptr_buffer, lines, lines_free,