From ee51e6c05f4895c6fb73e1555708d47f1af8c922 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Helleu?= <flashcode@flashtux.org>
Date: Thu, 25 Apr 2024 19:28:11 +0200
Subject: [PATCH] plugins: remove check of NULL pointers before calling
 weechat_infolist_free() (issue #865)

---
 src/plugins/python/weechat-python.c    | 3 +--
 src/plugins/relay/irc/relay-irc.c      | 3 +--
 tests/unit/core/test-core-infolist.cpp | 3 +++
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/plugins/python/weechat-python.c b/src/plugins/python/weechat-python.c
index 7bc3e9247..21fc0059d 100644
--- a/src/plugins/python/weechat-python.c
+++ b/src/plugins/python/weechat-python.c
@@ -1358,8 +1358,7 @@ weechat_python_infolist_constants ()
     return infolist;
 
 error:
-    if (infolist)
-        weechat_infolist_free (infolist);
+    weechat_infolist_free (infolist);
     return NULL;
 }
 
diff --git a/src/plugins/relay/irc/relay-irc.c b/src/plugins/relay/irc/relay-irc.c
index ddb8516a4..79847cd5a 100644
--- a/src/plugins/relay/irc/relay-irc.c
+++ b/src/plugins/relay/irc/relay-irc.c
@@ -561,8 +561,7 @@ relay_irc_signal_irc_outtags_cb (const void *pointer, void *data,
                                  (host && host[0]) ? host : "",
                                  ptr_message);
 
-                if (infolist_nick)
-                    weechat_infolist_free (infolist_nick);
+                weechat_infolist_free (infolist_nick);
             }
         }
         free (irc_channel);
diff --git a/tests/unit/core/test-core-infolist.cpp b/tests/unit/core/test-core-infolist.cpp
index 423a041e0..8347dff9f 100644
--- a/tests/unit/core/test-core-infolist.cpp
+++ b/tests/unit/core/test-core-infolist.cpp
@@ -253,6 +253,9 @@ TEST(CoreInfolist, Valid)
     infolist_free (infolist);
 
     LONGS_EQUAL(0, infolist_valid (infolist));
+
+    /* test free of NULL infolist */
+    infolist_free (NULL);
 }
 
 /*