1
0
mirror of https://github.com/anope/anope.git synced 2026-06-26 18:16:38 +02:00

Fix missing override keywords.

This commit is contained in:
Sadie Powell
2023-03-06 16:11:54 +00:00
parent d210cd2695
commit 29db25dac7
40 changed files with 66 additions and 66 deletions
+3 -3
View File
@@ -15,7 +15,7 @@
struct BadWordImpl : BadWord, Serializable
{
BadWordImpl() : Serializable("BadWord") { }
~BadWordImpl();
~BadWordImpl() override;
void Serialize(Serialize::Data &data) const override
{
@@ -35,7 +35,7 @@ struct BadWordsImpl : BadWords
BadWordsImpl(Extensible *obj) : ci(anope_dynamic_static_cast<ChannelInfo *>(obj)), badwords("BadWord") { }
~BadWordsImpl();
~BadWordsImpl() override;
BadWord* AddBadWord(const Anope::string &word, BadWordType type) override
{
@@ -160,7 +160,7 @@ class BadwordsDelCallback : public NumberList
bw = ci->Require<BadWords>("badwords");
}
~BadwordsDelCallback()
~BadwordsDelCallback() override
{
if (!deleted)
source.Reply(_("No matching entries on %s bad words list."), ci->name.c_str());
+2 -2
View File
@@ -165,9 +165,9 @@ class CommandBSKickBase : public Command
{
}
virtual void Execute(CommandSource &source, const std::vector<Anope::string> &params) override = 0;
void Execute(CommandSource &source, const std::vector<Anope::string> &params) override = 0;
virtual bool OnHelp(CommandSource &source, const Anope::string &subcommand) override = 0;
bool OnHelp(CommandSource &source, const Anope::string &subcommand) override = 0;
protected:
bool CheckArguments(CommandSource &source, const std::vector<Anope::string> &params, ChannelInfo* &ci)
+1 -1
View File
@@ -261,7 +261,7 @@ class CommandCSAccess : public Command
this->override = true;
}
~AccessDelCallback()
~AccessDelCallback() override
{
if (denied && !deleted)
source.Reply(ACCESS_DENIED);
+1 -1
View File
@@ -218,7 +218,7 @@ class CommandCSAKick : public Command
{
}
~AkickDelCallback()
~AkickDelCallback() override
{
if (!deleted)
source.Reply(_("No matching entries on %s autokick list."), ci->name.c_str());
+1 -1
View File
@@ -26,7 +26,7 @@ struct EntryMsgImpl : EntryMsg, Serializable
this->when = ct;
}
~EntryMsgImpl();
~EntryMsgImpl() override;
void Serialize(Serialize::Data &data) const override
{
+2 -2
View File
@@ -18,7 +18,7 @@ struct LogSettingImpl : LogSetting, Serializable
{
}
~LogSettingImpl()
~LogSettingImpl() override
{
ChannelInfo *ci = ChannelInfo::Find(chan);
if (ci)
@@ -81,7 +81,7 @@ struct LogSettingsImpl : LogSettings
{
LogSettingsImpl(Extensible *) { }
~LogSettingsImpl()
~LogSettingsImpl() override
{
for (iterator it = (*this)->begin(); it != (*this)->end();)
{
+2 -2
View File
@@ -18,7 +18,7 @@ struct ModeLockImpl : ModeLock, Serializable
{
}
~ModeLockImpl()
~ModeLockImpl() override
{
ChannelInfo *chan = ChannelInfo::Find(ci);
if (chan)
@@ -42,7 +42,7 @@ struct ModeLocksImpl : ModeLocks
{
}
~ModeLocksImpl()
~ModeLocksImpl() override
{
ModeList modelist;
mlocks->swap(modelist);
+1 -1
View File
@@ -36,7 +36,7 @@ struct SeenInfo : Serializable
{
}
~SeenInfo()
~SeenInfo() override
{
database_map::iterator iter = database.find(nick);
if (iter != database.end() && iter->second == this)
+1 -1
View File
@@ -176,7 +176,7 @@ class CSSetMisc : public Module
me = this;
}
~CSSetMisc()
~CSSetMisc() override
{
for (Anope::map<ExtensibleItem<CSMiscData> *>::iterator it = items.begin(); it != items.end(); ++it)
delete it->second;
+1 -1
View File
@@ -288,7 +288,7 @@ class CommandCSXOP : public Command
{
}
~XOPDelCallback()
~XOPDelCallback() override
{
if (!deleted)
source.Reply(_("No matching entries on %s %s list."), ci->name.c_str(), source.command.c_str());
+1 -1
View File
@@ -59,7 +59,7 @@ class MemoListCallback : public NumberList
found = false;
}
~MemoListCallback()
~MemoListCallback() override
{
if (!found)
source.Reply(_("No memos to display."));
+1 -1
View File
@@ -27,7 +27,7 @@ struct AJoinEntry : Serializable
AJoinEntry(Extensible *) : Serializable("AJoinEntry") { }
~AJoinEntry()
~AJoinEntry() override
{
AJoinList *channels = owner->GetExt<AJoinList>("ajoinlist");
if (channels)
+1 -1
View File
@@ -35,7 +35,7 @@ struct NSCertListImpl : NSCertList
public:
NSCertListImpl(Extensible *obj) : nc(anope_dynamic_static_cast<NickCore *>(obj)) { }
~NSCertListImpl()
~NSCertListImpl() override
{
ClearCert();
}
+1 -1
View File
@@ -189,7 +189,7 @@ class NSSetMisc : public Module
me = this;
}
~NSSetMisc()
~NSSetMisc() override
{
for (Anope::map<ExtensibleItem<NSMiscData> *>::iterator it = items.begin(); it != items.end(); ++it)
delete it->second;
+1 -1
View File
@@ -23,7 +23,7 @@ class AkillDelCallback : public NumberList
{
}
~AkillDelCallback()
~AkillDelCallback() override
{
if (!deleted)
source.Reply(_("No matching entries on the AKILL list."));
+1 -1
View File
@@ -115,7 +115,7 @@ class DefConTimeout : public Timer
timeout = this;
}
~DefConTimeout()
~DefConTimeout() override
{
timeout = NULL;
}
+3 -3
View File
@@ -29,7 +29,7 @@ struct DNSZone : Serializable
zones->push_back(this);
}
~DNSZone()
~DNSZone() override
{
std::vector<DNSZone *>::iterator it = std::find(zones->begin(), zones->end(), this);
if (it != zones->end())
@@ -104,7 +104,7 @@ class DNSServer : public Serializable
dns_servers->push_back(this);
}
~DNSServer()
~DNSServer() override
{
std::vector<DNSServer *>::iterator it = std::find(dns_servers->begin(), dns_servers->end(), this);
if (it != dns_servers->end())
@@ -743,7 +743,7 @@ class ModuleDNS : public Module
}
}
~ModuleDNS()
~ModuleDNS() override
{
for (unsigned i = zones->size(); i > 0; --i)
delete zones->at(i - 1);
+1 -1
View File
@@ -68,7 +68,7 @@ class MyForbidService : public ForbidService
public:
MyForbidService(Module *m) : ForbidService(m), forbid_data("ForbidData") { }
~MyForbidService()
~MyForbidService() override
{
std::vector<ForbidData *> f = GetForbids();
for (unsigned i = 0; i < f.size(); ++i)
+1 -1
View File
@@ -15,7 +15,7 @@
struct IgnoreDataImpl : IgnoreData, Serializable
{
IgnoreDataImpl() : Serializable("IgnoreData") { }
~IgnoreDataImpl();
~IgnoreDataImpl() override;
void Serialize(Serialize::Data &data) const override;
static Serializable* Unserialize(Serializable *obj, Serialize::Data &data);
};
+1 -1
View File
@@ -19,7 +19,7 @@ struct OperInfo : Serializable
OperInfo(const Anope::string &t, const Anope::string &i, const Anope::string &a, time_t c) :
Serializable("OperInfo"), target(t), info(i), adder(a), created(c) { }
~OperInfo();
~OperInfo() override;
void Serialize(Serialize::Data &data) const override
{
+4 -4
View File
@@ -99,7 +99,7 @@ class MyNewsService : public NewsService
public:
MyNewsService(Module *m) : NewsService(m) { }
~MyNewsService()
~MyNewsService() override
{
for (unsigned i = 0; i < 3; ++i)
for (unsigned j = 0; j < newsItems[i].size(); ++j)
@@ -280,13 +280,13 @@ class NewsBase : public Command
this->SetSyntax("LIST");
}
virtual ~NewsBase()
~NewsBase() override
{
}
virtual void Execute(CommandSource &source, const std::vector<Anope::string> &params) = 0;
void Execute(CommandSource &source, const std::vector<Anope::string> &params) override = 0;
virtual bool OnHelp(CommandSource &source, const Anope::string &subcommand) = 0;
bool OnHelp(CommandSource &source, const Anope::string &subcommand) override = 0;
};
class CommandOSLogonNews : public NewsBase
+1 -1
View File
@@ -265,7 +265,7 @@ class OSOper : public Module
{
}
~OSOper()
~OSOper() override
{
for (nickcore_map::const_iterator it = NickCoreList->begin(), it_end = NickCoreList->end(); it != it_end; ++it)
{
+2 -2
View File
@@ -139,7 +139,7 @@ class ExceptionDelCallback : public NumberList
{
}
~ExceptionDelCallback()
~ExceptionDelCallback() override
{
if (!deleted)
source.Reply(_("No matching entries on session-limit exception list."));
@@ -149,7 +149,7 @@ class ExceptionDelCallback : public NumberList
source.Reply(_("Deleted %d entries from session-limit exception list."), deleted);
}
virtual void HandleNumber(unsigned number) override
void HandleNumber(unsigned number) override
{
if (!number || number > session_service->GetExceptions().size())
return;
+2 -2
View File
@@ -22,7 +22,7 @@ class SXLineDelCallback : public NumberList
{
}
~SXLineDelCallback()
~SXLineDelCallback() override
{
if (!deleted)
source.Reply(_("No matching entries on the %s list."), source.command.c_str());
@@ -253,7 +253,7 @@ class CommandOSSXLineBase : public Command
return;
}
virtual bool OnHelp(CommandSource &source, const Anope::string &subcommand) override = 0;
bool OnHelp(CommandSource &source, const Anope::string &subcommand) override = 0;
};
class CommandOSSNLine : public CommandOSSXLineBase
+1 -1
View File
@@ -19,7 +19,7 @@ class Data : public Serialize::Data
public:
std::map<Anope::string, std::stringstream *> data;
~Data()
~Data() override
{
for (std::map<Anope::string, std::stringstream *>::iterator it = data.begin(), it_end = data.end(); it != it_end; ++it)
delete it->second;
+5 -5
View File
@@ -453,7 +453,7 @@ namespace DNS
class ReplySocket : public virtual Socket
{
public:
virtual ~ReplySocket() = default;
~ReplySocket() override = default;
virtual void Reply(Packet *p) = 0;
};
}
@@ -479,7 +479,7 @@ class TCPSocket : public ListenSocket
Log(LOG_DEBUG_2) << "Resolver: New client from " << addr.addr();
}
~Client()
~Client() override
{
Log(LOG_DEBUG_2) << "Resolver: Exiting client from " << clientaddr.addr();
delete packet;
@@ -560,7 +560,7 @@ class UDPSocket : public ReplySocket
public:
UDPSocket(Manager *m, const Anope::string &ip, int port) : Socket(-1, ip.find(':') != Anope::string::npos, SOCK_DGRAM), manager(m) { }
~UDPSocket()
~UDPSocket() override
{
for (unsigned i = 0; i < packets.size(); ++i)
delete packets[i];
@@ -666,7 +666,7 @@ class MyManager : public Manager, public Timer
{
}
~MyManager()
~MyManager() override
{
delete udpsock;
delete tcpsock;
@@ -1022,7 +1022,7 @@ class ModuleDNS : public Module
}
~ModuleDNS()
~ModuleDNS() override
{
for (std::map<int, Socket *>::const_iterator it = SocketEngine::Sockets.begin(), it_end = SocketEngine::Sockets.end(); it != it_end;)
{
+2 -2
View File
@@ -99,7 +99,7 @@ class MyHTTPClient : public HTTPClient
Log(LOG_DEBUG, "httpd") << "Accepted connection " << f << " from " << a.addr();
}
~MyHTTPClient()
~MyHTTPClient() override
{
Log(LOG_DEBUG, "httpd") << "Closing connection " << this->GetFD() << " from " << this->ip;
}
@@ -344,7 +344,7 @@ class HTTPD : public Module
}
~HTTPD()
~HTTPD() override
{
for (std::map<int, Socket *>::const_iterator it = SocketEngine::Sockets.begin(), it_end = SocketEngine::Sockets.end(); it != it_end;)
{
+3 -3
View File
@@ -69,12 +69,12 @@ class ProxyConnect : public ConnectionSocket
proxies.insert(this);
}
~ProxyConnect()
~ProxyConnect() override
{
proxies.erase(this);
}
virtual void OnConnect() override = 0;
void OnConnect() override = 0;
virtual const Anope::string GetType() const = 0;
protected:
@@ -227,7 +227,7 @@ class ModuleProxyScan : public Module
this->listener = NULL;
}
~ModuleProxyScan()
~ModuleProxyScan() override
{
for (std::set<ProxyConnect *>::iterator it = ProxyConnect::proxies.begin(), it_end = ProxyConnect::proxies.end(); it != it_end;)
{
+4 -4
View File
@@ -23,7 +23,7 @@ class RedisSocket : public BinarySocket, public ConnectionSocket
RedisSocket(MyRedisService *pro, bool v6) : Socket(-1, v6), provider(pro) { }
~RedisSocket();
~RedisSocket() override;
void OnConnect() override;
void OnError(const Anope::string &error) override;
@@ -38,7 +38,7 @@ class Transaction : public Interface
Transaction(Module *creator) : Interface(creator) { }
~Transaction()
~Transaction() override
{
for (unsigned i = 0; i < interfaces.size(); ++i)
{
@@ -96,7 +96,7 @@ class MyRedisService : public Provider
sub->Connect(host, port);
}
~MyRedisService()
~MyRedisService() override
{
if (sock)
{
@@ -533,7 +533,7 @@ class ModuleRedis : public Module
{
}
~ModuleRedis()
~ModuleRedis() override
{
for (std::map<Anope::string, MyRedisService *>::iterator it = services.begin(); it != services.end(); ++it)
{
+2 -2
View File
@@ -131,7 +131,7 @@ class SASLService : public SASL::Service, public Timer
public:
SASLService(Module *o) : SASL::Service(o), Timer(o, 60, Anope::CurTime, true) { }
~SASLService()
~SASLService() override
{
for (std::map<Anope::string, Session *>::iterator it = sessions.begin(); it != sessions.end(); it++)
delete it->second;
@@ -332,7 +332,7 @@ class ModuleSASL : public Module
catch (ModuleException &) { }
}
~ModuleSASL()
~ModuleSASL() override
{
delete external;
}
+1 -1
View File
@@ -208,7 +208,7 @@ class ModuleXMLRPC : public Module
}
~ModuleXMLRPC()
~ModuleXMLRPC() override
{
if (httpref)
httpref->UnregisterPage(&xmlrpcinterface);
+1 -1
View File
@@ -300,7 +300,7 @@ class ModuleXMLRPCMain : public Module
xmlrpc->Register(&stats);
}
~ModuleXMLRPCMain()
~ModuleXMLRPCMain() override
{
if (xmlrpc)
xmlrpc->Unregister(&stats);
+1 -1
View File
@@ -441,7 +441,7 @@ class ProtoPlexus : public Module
this->AddModes();
}
~ProtoPlexus()
~ProtoPlexus() override
{
m_hybrid = ModuleManager::FindModule("hybrid");
ModuleManager::UnloadModule(m_hybrid, NULL);
+1 -1
View File
@@ -363,7 +363,7 @@ class ProtoRatbox : public Module
this->AddModes();
}
~ProtoRatbox()
~ProtoRatbox() override
{
m_hybrid = ModuleManager::FindModule("hybrid");
ModuleManager::UnloadModule(m_hybrid, NULL);
+1 -1
View File
@@ -401,7 +401,7 @@ class ProtoSolanum : public Module
this->AddModes();
}
~ProtoSolanum()
~ProtoSolanum() override
{
m_ratbox = ModuleManager::FindModule("ratbox");
ModuleManager::UnloadModule(m_ratbox, NULL);
+4 -4
View File
@@ -29,7 +29,7 @@ class NickServCollide : public Timer
collides.insert(this);
}
~NickServCollide()
~NickServCollide() override
{
collides.erase(this);
}
@@ -68,7 +68,7 @@ class NickServHeld : public Timer
n->Extend<bool>("HELD");
}
void Tick(time_t)
void Tick(time_t) override
{
if (na)
na->Shrink<bool>("HELD");
@@ -101,7 +101,7 @@ class NickServRelease : public User, public Timer
IRCD->SendClientIntroduction(this);
}
~NickServRelease()
~NickServRelease() override
{
IRCD->SendQuit(this, "");
NickServReleases.erase(this->nick);
@@ -137,7 +137,7 @@ class NickServCore : public Module, public NickServService
{
}
~NickServCore()
~NickServCore() override
{
OnShutdown();
}
+1 -1
View File
@@ -200,7 +200,7 @@ class OperServCore : public Module
XLineManager::RegisterXLineManager(&snlines);
}
~OperServCore()
~OperServCore() override
{
this->sglines.Clear();
this->sqlines.Clear();
+1 -1
View File
@@ -202,7 +202,7 @@ class ModuleWebCPanel : public Module
}
}
~ModuleWebCPanel()
~ModuleWebCPanel() override
{
if (provider)
{
+1 -1
View File
@@ -303,7 +303,7 @@ void StackerInfo::AddMode(Mode *mode, bool set, const Anope::string &param)
static class ModePipe : public Pipe
{
public:
void OnNotify()
void OnNotify() override
{
ModeManager::ProcessModes();
}
+1 -1
View File
@@ -22,7 +22,7 @@ class ReconnectTimer : public Timer
public:
ReconnectTimer(int wait) : Timer(wait) { }
void Tick(time_t)
void Tick(time_t) override
{
try
{