pegasus/anope
1
0
Fork 0
mirror of https://github.com/anope/anope.git synced 2026-07-01 15:26:39 +02:00
Code Activity

Remove unused modules_unload_all fini param

Browse Source 
git-svn-id: http://anope.svn.sourceforge.net/svnroot/anope/trunk@2279 5417fbe8-f217-4b02-8779-1006273d7864
This commit is contained in:
rburchell
2009-04-16 20:26:24 +00:00
parent d8e1f104a4
commit 89850c85a9
4 changed files with 7 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
TODO
+1 -1
View File
@@ -5,7 +5,7 @@ Legend:
1.9.1
-----
[ ] Remove modules_unload_all fini + hack that goes with it
[x] Remove modules_unload_all fini + hack that goes with it
[x] signal handling cleanup
[ ] Move a (lot) of stuff to class members as a defined interface rather than copypasta everywhere (ns_set, ns_saset!)
[ ] burn do_sjoin with fire
include/extern.h
+1 -1
View File
@@ -668,7 +668,7 @@ E int str_is_cidr(char *str, uint32 * ip, uint32 * mask, char **host);
/**** modules.c ****/
E void modules_unload_all(bool fini, bool unload_proto); /* Read warnings near function source */
E void modules_unload_all(bool unload_proto); /* Read warnings near function source */
E void ModuleDatabaseBackup(const char *dbname);
E void ModuleRemoveBackups(const char *dbname);
src/main.c
+4 -4
View File
@@ -167,8 +167,8 @@ static void services_restart()
disconn(servsock);
close_log();
/* First don't unload protocol module, then do so */
modules_unload_all(true, false);
modules_unload_all(true, true);
modules_unload_all(false);
modules_unload_all(true);
chdir(binary_dir.c_str());
execve(SERVICES_BIN, my_av, my_envp);
if (!readonly) {
@@ -223,8 +223,8 @@ static void services_shutdown()
send_event(EVENT_SHUTDOWN, 1, EVENT_STOP);
disconn(servsock);
/* First don't unload protocol module, then do so */
modules_unload_all(true, false);
modules_unload_all(true, true);
modules_unload_all(false);
modules_unload_all(true);
/* just in case they weren't all removed at least run once */
ModuleRunTimeDirCleanUp();
}
src/modules.c
+1 -10
View File
@@ -112,20 +112,11 @@ int protocol_module_init()
* And if that isn't enough discouragement, you'll wake up with your
* both legs broken tomorrow ;) -GD
*/
void modules_unload_all(bool fini, bool unload_proto)
void modules_unload_all(bool unload_proto)
{
int idx;
ModuleHash *mh, *next;
if (!fini)
{
/*
* XXX: This was used to stop modules from executing destructors, we don't really
* support this now, so just return.. dirty. We need to rewrite the code that uses this param.
*/
return;
}
for (idx = 0; idx < MAX_CMD_HASH; idx++) {
mh = MODULE_HASH[idx];
while (mh) {