BUILD : 1.7.9 (795) BUGS : 379 NOTES : Fixed the channelname issue in do_part once and for all with sstrdup(tm) power

git-svn-id: svn://svn.anope.org/anope/trunk@795 31f1291d-b8d6-0310-a050-a5561fc1590b


git-svn-id: http://anope.svn.sourceforge.net/svnroot/anope/trunk@554 5417fbe8-f217-4b02-8779-1006273d7864

Changes

@@ -1,6 +1,7 @@
 Anope Version S V N
 -------------------
 Provided by Anope Dev. <dev@anope.org> - 2005
+05/13 F Possible segfault with do_part by using freed memory.             [#379]
 05/13 F Long hosts got cut off when setting topic and host was recorded.  [#377]
 05/12 F NSListOpersOnly works correctly.                                  [#375]
 05/12 F Using variable for EVENT_PART_CHANNEL after freeing it.           [#374]

src/channels.c

@@ -653,6 +653,7 @@ void do_part(const char *source, int ac, char **av)
     User *user;
     char *s, *t;
     struct u_chanlist *c;
+    char *channame;
 
     user = finduser(source);
     if (!user) {
@@ -676,8 +677,10 @@ void do_part(const char *source, int ac, char **av)
                 alog("user: BUG parting %s: channel entry found but c->chan NULL", s);
                 return;
             }
+            channame = sstrdup(c->chan->name);
             send_event(EVENT_PART_CHANNEL, 3, EVENT_START, user->nick,
-                       c->chan->name);
+                       channame);
+
             chan_deluser(user, c->chan);
             if (c->next)
                 c->next->prev = c->prev;
@@ -685,9 +688,11 @@ void do_part(const char *source, int ac, char **av)
                 c->prev->next = c->next;
             else
                 user->chans = c->next;
-            send_event(EVENT_PART_CHANNEL, 3, EVENT_STOP, user->nick,
-                       c->chan->name);
             free(c);
+
+            send_event(EVENT_PART_CHANNEL, 3, EVENT_STOP, user->nick,
+                       channame);
+            free(channame);
         }
     }
 }

version.log

@@ -8,10 +8,14 @@
 VERSION_MAJOR="1"
 VERSION_MINOR="7"
 VERSION_PATCH="9"
-VERSION_BUILD="794"
+VERSION_BUILD="795"
 
 # $Log$
 #
+# BUILD : 1.7.9 (795)
+# BUGS  : 379
+# NOTES : Fixed the channelname issue in do_part once and for all with sstrdup(tm) power
+#
 # BUILD : 1.7.9 (794)
 # BUGS  : 377
 # NOTES : Removed any ! and further from topicsetters, since Unreal sometimes sends a nick!user@host topicsetter instead of just nick