# BUILD : 1.7.18 (1229) # BUGS : 690 # NOTES : SAs can no longer move down other SAs to the SO list.

git-svn-id: svn://svn.anope.org/anope/trunk@1229 31f1291d-b8d6-0310-a050-a5561fc1590b


git-svn-id: http://anope.svn.sourceforge.net/svnroot/anope/trunk@948 5417fbe8-f217-4b02-8779-1006273d7864

Changes

@@ -13,6 +13,7 @@ Anope Version  S V N
 01/15 F Only send PONG during MySQL save when we're not syncing.          [#669]
 01/15 F InspIRCD 1.1 protocol module used windows incompatible strtok_r.  [#667]
 01/22 F Crash during first save when MySQL is enabled.                    [#672]
+03/03 F SAs can no longer move other SAs down to ServicesOpers.           [#690]
 
 Anope Version 1.7.18
 --------------------

src/core/os_oper.c

@@ -111,6 +111,10 @@ int do_oper(User * u)
         } else {
             if (na->nc->flags & NI_SERVICES_ADMIN
                 && (res = slist_indexof(&servadmins, na->nc)) != -1) {
+                if (!is_services_root(u)) {
+                    notice_lang(s_OperServ, u, PERMISSION_DENIED);
+                    return MOD_CONT;
+                }
                 slist_delete(&servadmins, res);
                 na->nc->flags |= NI_SERVICES_OPER;
                 notice_lang(s_OperServ, u, OPER_OPER_MOVED, nick);

version.log

@@ -9,10 +9,14 @@ VERSION_MAJOR="1"
 VERSION_MINOR="7"
 VERSION_PATCH="18"
 VERSION_EXTRA="-svn"
-VERSION_BUILD="1228"
+VERSION_BUILD="1229"
 
 # $Log$
 #
+# BUILD : 1.7.18 (1229)
+# BUGS  : 690
+# NOTES : SAs can no longer move down other SAs to the SO list.
+#
 # BUILD : 1.7.18 (1228)
 # BUGS  : 672
 # NOTES : Fixed a crash when MySQL was enabled; it checked the (unset) uplink server flags resulting in a segfault