Release 2.1.3.

.github/ISSUE_TEMPLATE/BUG.yml

@@ -1,44 +0,0 @@
----
-name: Bug report
-description: Report a non-security bug in Anope.
-body:
-  - type: markdown
-    attributes:
-      value: |
-        Thanks for taking the time to fill out this bug report!
-
-        If you're looking for help with setting up your services please post on [our support forum](https://github.com/orgs/anope/discussions/categories/support) instead.
-
-        If you're reporting a crash or other security issue [please read our security policy](https://github.com/anope/anope/security/policy#reporting-a-vulnerability) for how to report security issues privately.
-
-  - type: textarea
-    attributes:
-      label: Description
-    validations:
-      required: true
-
-  - type: textarea
-    attributes:
-      label: Steps to reproduce the issue
-    validations:
-      required: true
-
-  - type: textarea
-    attributes:
-      label: Describe the results you received
-    validations:
-      required: true
-
-  - type: textarea
-    attributes:
-      label: Describe the results you expected
-    validations:
-      required: true
-
-  - type: input
-    attributes:
-      label: Anope version
-      description: |-
-        Either the output of `services --version` (2.0) or `anope --version` (2.1).
-    validations:
-      required: true

.github/ISSUE_TEMPLATE/BUG_REPORT.md

@@ -0,0 +1,33 @@
+---
+name: Bug report
+about: Report a non-security issue with Anope.
+---
+
+<!--
+Please fill in the template below. It will help us process your bug report a lot faster. If you have multiple bugs to report then please open one issue for each bug.
+-->
+
+**Description**
+
+
+
+**Steps to reproduce the issue:**
+
+1.
+2.
+3.
+
+**Describe the results you received:**
+
+
+
+**Describe the results you expected:**
+
+
+
+**Additional information you deem important (e.g. issue happens only occasionally):**
+
+
+
+**Output of `services --version`:**
+

.github/ISSUE_TEMPLATE/FEATURE.yml

@@ -1,20 +0,0 @@
----
-name: Feature request
-description: Request that a new feature is added to Anope.
-body:
-  - type: markdown
-    attributes:
-      value: |
-        Thanks for taking the time to fill out this feature request!
-
-  - type: textarea
-    attributes:
-      label: Description
-    validations:
-      required: true
-
-  - type: textarea
-    attributes:
-      label: Why this would be useful?
-    validations:
-      required: true

.github/ISSUE_TEMPLATE/FEATURE_REQUEST.md

@@ -0,0 +1,15 @@
+---
+name: Feature request
+about: Request that a new feature is added to Anope.
+---
+
+<!--
+Please fill in the template below. It will help us process your feature request a lot faster. If you have multiple features to request then please open one issue for each feature.
+-->
+
+**Description**
+
+
+
+**Why this would be useful**
+

.github/ISSUE_TEMPLATE/config.yml

@@ -1,5 +1 @@
 blank_issues_enabled: false
-contact_links:
-  - name: Support forum
-    url: https://github.com/orgs/anope/discussions/categories/support
-    about: Please ask support questions here.

.github/SECURITY.md

@@ -14,6 +14,6 @@ Version | Supported
 
 ## Reporting a Vulnerability
 
-Please do not report security vulnerabilities on GitHub. Instead, email the details to team@anope.org or get the attention of a developer in our development IRC channel at irc.teranova.net #anope-devel and PM them the details.
+Please do not report security vulnerabilities on GitHub. Instead, email the details to team@anope.org or get the attention of a developer in our development IRC channel at irc.anope.org #anope-devel and PM them the details.
 
 We will triage your issue as soon as possible and try to release a fixed version within a week of receiving your report.

.github/dependabot.yml

@@ -4,4 +4,3 @@ updates:
     directory: /
     schedule:
       interval: monthly
-    target-branch: "2.1"

.github/workflows/ci-alpine.yml

@@ -20,7 +20,6 @@ jobs:
           echo "http://dl-cdn.alpinelinux.org/alpine/edge/testing" >> /etc/apk/repositories
           apk update
           apk add \
-            argon2-dev \
             clang \
             cmake \
             g++ \
@@ -37,7 +36,7 @@ jobs:
 
       - name: Enable extras
         run: |
-          for MODULE in enc_argon2 enc_posix ldap mysql regex_pcre2 regex_posix regex_tre sqlite ssl_gnutls ssl_openssl
+          for MODULE in ldap ldap_authentication ldap_oper mysql regex_pcre2 regex_posix regex_tre sql_authentication sql_log sql_oper sqlite ssl_gnutls ssl_openssl
           do
             ln -s $PWD/modules/extra/$MODULE.cpp $PWD/modules
           done

.github/workflows/ci-linux.yml

@@ -20,7 +20,6 @@ jobs:
             g++ \
             gettext \
             git \
-            libargon2-dev \
             libgnutls28-dev \
             libldap2-dev \
             libmysqlclient-dev \
@@ -32,7 +31,7 @@ jobs:
 
       - name: Enable extras
         run: |
-          for MODULE in enc_argon2 enc_posix ldap mysql regex_pcre2 regex_posix regex_tre sqlite ssl_gnutls ssl_openssl
+          for MODULE in ldap ldap_authentication ldap_oper mysql regex_pcre2 regex_posix regex_tre sql_authentication sql_log sql_oper sqlite ssl_gnutls ssl_openssl
           do
             ln -s ${{ github.workspace }}/modules/extra/$MODULE.cpp ${{ github.workspace }}/modules
           done

.github/workflows/ci-windows.yml

@@ -2,9 +2,6 @@ name: Windows CI
 on:
   pull_request:
   push:
-  release:
-    types:
-      - published
   schedule:
     - cron: '0 0 * * 0'
 jobs:
@@ -12,15 +9,15 @@ jobs:
     if: "!contains(github.event.head_commit.message, '[skip windows ci]')"
     runs-on: windows-2019
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v3
 
       - name: Setup MSBuild
-        uses: microsoft/setup-msbuild@v2
+        uses: microsoft/setup-msbuild@v1.3
 
       - name: Setup Conan
         uses: turtlebrowser/get-conan@v1.2
         with:
-          version: 1.64.0
+          version: 1.59.0
 
       - name: Install libraries
         run: |
@@ -30,17 +27,9 @@ jobs:
         run: |
           mkdir ${{ github.workspace }}\build
           cd ${{ github.workspace }}\build
-          cmake -A "x64" -D "CMAKE_BUILD_TYPE=${{ github.event_name == 'release' && 'Release' || 'Debug' }}" -G "Visual Studio 16 2019" ..
+          cmake -A "x64" -G "Visual Studio 16 2019" ..
 
       - name: Build Anope
         working-directory: ${{ github.workspace }}\build
         run: |
-          msbuild PACKAGE.vcxproj /M:3 /P:Configuration=${{ github.event_name == 'release' && 'Release' || 'Debug' }} /P:Platform=x64 /VERBOSITY:MINIMAL
-
-      - name: Upload installer
-        if: "${{ github.event_name == 'release' }}"
-        working-directory: ${{ github.workspace }}\build
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          gh release upload ${{ github.event.release.tag_name }} $(Get-ChildItem anope-*.exe)
+          msbuild PACKAGE.vcxproj /M:3 /P:Configuration=Release /P:Platform=x64 /VERBOSITY:MINIMAL

.gitignore

@@ -1,17 +1,19 @@
 build/
 config.cache
 include/sysconf.h
-modules/enc_argon2.cpp
-modules/enc_posix.cpp
 modules/ldap.cpp
+modules/ldap_authentication.cpp
+modules/ldap_oper.cpp
 modules/mysql.cpp
 modules/regex_pcre2.cpp
 modules/regex_posix.cpp
 modules/regex_tre.cpp
+modules/sql_authentication.cpp
+modules/sql_log.cpp
+modules/sql_oper.cpp
 modules/sqlite.cpp
 modules/ssl_gnutls.cpp
 modules/ssl_openssl.cpp
 modules/stats
 run/
 *.mo
-*.pot

CMakeLists.txt

@@ -31,8 +31,12 @@ if(CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang$")
   execute_process(COMMAND ${CMAKE_C_COMPILER} -print-search-dirs OUTPUT_VARIABLE LINES OUTPUT_STRIP_TRAILING_WHITESPACE)
   # Find only the part after "libraries: "
   string(REGEX REPLACE ".*\nlibraries: (.*)$" "\\1" LINE "${LINES}")
-  # Replace the colons in the list with semicolons
-  string(REGEX REPLACE ":" ";" LIBRARIES ${LINE})
+  # Replace the colons in the list with semicolons (only when not on MinGW, which uses semicolons already), and if on MinGW, just copy the line
+  if(NOT MINGW)
+    string(REGEX REPLACE ":" ";" LIBRARIES ${LINE})
+  else()
+    set(LIBRARIES "${LINE}")
+  endif()
   # Iterate through the libraries
   foreach(LIBRARY ${LIBRARIES})
     # Check if the first character is an equal sign, and skip that library directory as it is (I believe) the primary default and shows up later in the list anyways
@@ -102,6 +106,13 @@ if(NOT MSVC)
   endif()
 endif()
 
+# If running under MinGW, we have to force the resource compiler settings (hopefully this will be fixed in a later version of CMake)
+if(MINGW)
+  set(CMAKE_RC_COMPILER_INIT windres)
+  enable_language(RC)
+  set(CMAKE_RC_COMPILE_OBJECT "<CMAKE_RC_COMPILER> <FLAGS> <DEFINES> -o <OBJECT> <SOURCE>")
+endif()
+
 # Include the checking functions used later in this CMakeLists.txt
 include(CheckFunctionExists)
 include(CheckTypeSize)
@@ -178,6 +189,11 @@ if(CMAKE_THREAD_LIBS_INIT)
   list(APPEND LINK_LIBS ${CMAKE_THREAD_LIBS_INIT})
 endif()
 
+# Under MinGW, the -shared flag isn't properly set in the module-specific linker flags, add it from the C flags for shared libraries
+if(MINGW)
+  set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} ${CMAKE_SHARED_LIBRARY_CREATE_C_FLAGS}")
+endif()
+
 if(NOT PROGRAM_NAME)
   set(PROGRAM_NAME anope)
 endif()
@@ -208,7 +224,6 @@ if(CMAKE_BUILD_TYPE STREQUAL "DEBUG" OR CMAKE_BUILD_TYPE STREQUAL "RELWITHDEBINF
 endif()
 
 # Check for the existence of the following functions
-check_function_exists(clock_gettime HAVE_CLOCK_GETTIME)
 check_function_exists(umask HAVE_UMASK)
 check_function_exists(epoll_wait HAVE_EPOLL)
 check_function_exists(poll HAVE_POLL)
@@ -240,8 +255,8 @@ endif()
 if(NOT BIN_DIR)
   set(BIN_DIR "bin")
 endif()
-if(NOT DATA_DIR)
-  set(DATA_DIR "data")
+if(NOT DB_DIR)
+  set(DB_DIR "data")
 endif()
 if(NOT DOC_DIR)
   set(DOC_DIR "doc")
@@ -249,14 +264,14 @@ endif()
 if(NOT CONF_DIR)
   set(CONF_DIR "conf")
 endif()
-if(NOT MODULE_DIR)
-  set(MODULE_DIR "modules")
+if(NOT LIB_DIR)
+  set(LIB_DIR "lib")
 endif()
 if(NOT LOCALE_DIR)
   set(LOCALE_DIR "locale")
 endif()
-if(NOT LOG_DIR)
-  set(LOG_DIR "logs")
+if(NOT LOGS_DIR)
+  set(LOGS_DIR "logs")
 endif()
 
 # Version number processing
@@ -334,17 +349,15 @@ set(SERVICES_BINARY "$<TARGET_FILE:${PROGRAM_NAME}>")
 get_filename_component(SERVICES_BINARY ${SERVICES_BINARY} NAME)
 
 # At install time, create the following additional directories
-get_filename_component(ABSOLUTE_DATA_DIR ${DATA_DIR} REALPATH BASE_DIR ${CMAKE_INSTALL_PREFIX})
-get_filename_component(ABSOLUTE_LOG_DIR ${LOG_DIR} REALPATH BASE_DIR ${CMAKE_INSTALL_PREFIX})
-install(CODE "file(MAKE_DIRECTORY \"\$ENV{DESTDIR}${ABSOLUTE_DATA_DIR}/backups\")")
-install(CODE "file(MAKE_DIRECTORY \"\$ENV{DESTDIR}${ABSOLUTE_LOG_DIR}\")")
+install(CODE "file(MAKE_DIRECTORY \"\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${DB_DIR}/backups\")")
+install(CODE "file(MAKE_DIRECTORY \"\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${LOGS_DIR}\")")
 if(WIN32)
-  install(CODE "file(MAKE_DIRECTORY \"\$ENV{DESTDIR}${ABSOLUTE_DATA_DIR}/runtime\")")
+  install(CODE "file(MAKE_DIRECTORY \"\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${DB_DIR}/runtime\")")
 endif()
 # On non-Windows platforms, if RUNGROUP is set, change the permissions of the below directories, as well as the group of the data directory
 if(NOT WIN32 AND RUNGROUP)
-  install(CODE "execute_process(COMMAND ${CHMOD} 2775 \"\$ENV{DESTDIR}${ABSOLUTE_DATA_DIR}/backups\")")
-  install(CODE "execute_process(COMMAND ${CHMOD} 2775 \"\$ENV{DESTDIR}${ABSOLUTE_LOG_DIR}\")")
+  install(CODE "execute_process(COMMAND ${CHMOD} 2775 \"\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/\${DB_DIR}/backups\")")
+  install(CODE "execute_process(COMMAND ${CHMOD} 2775 \"\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/\${LOGS_DIR}\")")
   install(CODE "execute_process(COMMAND ${CHGRP} -R ${RUNGROUP} \"\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}\")")
 endif()
 # On Windows platforms, install extra files
@@ -354,8 +367,7 @@ if(WIN32)
   )
 endif()
 
-get_filename_component(ABSOLUTE_MODULE_DIR ${MODULE_DIR} REALPATH BASE_DIR ${CMAKE_INSTALL_PREFIX})
-install(CODE "file(REMOVE_RECURSE \"$ENV{DESTDIR}${ABSOLUTE_MODULE_DIR}\")")
+install(CODE "file(REMOVE_RECURSE \"$ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}/${LIB_DIR}/modules\")")
 
 # Only process the CPack section if we have CPack
 if(EXISTS "${CMAKE_ROOT}/Modules/CPack.cmake")

Config

@@ -13,6 +13,10 @@
 #
 ###########################################################################
 
+echo2 () {
+	$ECHO2 "$*$ECHO2SUF" # these are defined later
+}
+
 exists () { # because some shells don't have test -e
 	if [ -f $1 -o -d $1 -o -p $1 -o -c $1 -o -b $1 ] ; then
 		return 0
@@ -38,6 +42,7 @@ Run_Build_System () {
 	WITH_PERM=""
 	EXTRA_INCLUDE=""
 	EXTRA_LIBS=""
+	GEN_TYPE=""
 
 	if [ "$INSTDIR" != "" ] ; then
 		WITH_INST="-DINSTDIR:STRING=$INSTDIR"
@@ -65,25 +70,45 @@ Run_Build_System () {
 		EXTRA_LIBS="-DEXTRA_LIBS:STRING=$EXTRA_LIB_DIRS"
 	fi
 
-	BUILD_PATHS="-B ${SOURCE_DIR}/build ${SOURCE_DIR}"
+	if [ "$SOURCE_DIR" = "." ] ; then
+		pwdsave=`pwd`
+		test -d build || mkdir build
+		cd "build"
+		REAL_SOURCE_DIR=".."
+	else
+		REAL_SOURCE_DIR="$SOURCE_DIR"
+	fi
 
-	CMAKE="cmake $GEN_TYPE $WITH_INST $WITH_RUN $WITH_PERM $BUILD_TYPE $EXTRA_INCLUDE $EXTRA_LIBS $EXTRA_CONFIG_ARGS $BUILD_PATHS"
-	echo $CMAKE
-	$CMAKE
+	echo "cmake $GEN_TYPE $WITH_INST $WITH_RUN $WITH_PERM $BUILD_TYPE $EXTRA_INCLUDE $EXTRA_LIBS $EXTRA_CONFIG_ARGS $REAL_SOURCE_DIR"
 
+	cmake $GEN_TYPE $WITH_INST $WITH_RUN $WITH_PERM $BUILD_TYPE $EXTRA_INCLUDE $EXTRA_LIBS $EXTRA_CONFIG_ARGS $REAL_SOURCE_DIR
 	if [ $? -ne 0 ]; then
 		echo "You should fix these issues and then run ./Config -quick to rerun CMake."
 		exit 1
 	fi
 
 	echo ""
-	if [ "$PWD" = "${SOURCE_DIR}/build" ]; then
-		echo "Now run make to build Anope."
-	else
+	if [ "$SOURCE_DIR" = "." ] ; then
 		echo "Now cd build, then run make to build Anope."
+		cd "$pwdsave"
+	else
+		echo "Now run make to build Anope."
 	fi
 }
 
+ECHO2SUF=''
+if [ "`echo -n a ; echo -n b`" = "ab" ] ; then
+	ECHO2='echo -n'
+elif [ "`echo 'a\c' ; echo 'b\c'`" = "ab" ] ; then
+	ECHO2='echo' ; ECHO2SUF='\c'
+elif [ "`printf 'a' 2>&1 ; printf 'b' 2>&1`" = "ab" ] ; then
+	ECHO2='printf "%s"'
+else
+	# oh well...
+	ECHO2='echo'
+fi
+export ECHO2 ECHO2SUF
+
 ###########################################################################
 # Init values
 ###########################################################################
@@ -96,7 +121,7 @@ EXTRA_INCLUDE_DIRS=
 EXTRA_LIB_DIRS=
 EXTRA_CONFIG_ARGS=
 CAN_QUICK="no"
-SOURCE_DIR="$(cd "$(dirname "$0")" && pwd)"
+SOURCE_DIR=`dirname $0`
 
 ###########################################################################
 # Check out the options
@@ -113,7 +138,7 @@ while [ $# -ge 1 ] ; do
 		exit 0
 	elif [ $1 = "-devel" ] ; then
 		DEBUG="yes"
-		INSTDIR="$SOURCE_DIR/run"
+		INSTDIR="$PWD/run"
 	elif [ $1 = "-nocache" ] ; then
 		IGNORE_CACHE="1"
 	elif [ $1 = "-nointro" ] ; then
@@ -174,7 +199,7 @@ export ok INPUT
 ok=0
 echo "In what directory should Anope be installed?"
 while [ $ok -eq 0 ] ; do
-	echo -n "[$INSTDIR] "
+	echo2 "[$INSTDIR] "
 	if read INPUT ; then : ; else echo "" ; exit 1 ; fi
 	if [ ! "$INPUT" ] ; then
 		INPUT=$INSTDIR
@@ -184,7 +209,7 @@ while [ $ok -eq 0 ] ; do
 			echo "$INPUT exists, but is not a directory!"
 		else
 			echo "$INPUT does not exist.  Create it?"
-			echo -n "[y] "
+			echo2 "[y] "
 			read YN
 			if [ "$YN" != "n" ] ; then
 				if mkdir -p $INPUT ; then
@@ -213,7 +238,7 @@ else
 	echo "should not force files to be owned by a particular group, just press"
 	echo "Return.)"
 fi
-echo -n "[$RUNGROUP] "
+echo2 "[$RUNGROUP] "
 if read INPUT ; then : ; else echo "" ; exit 1 ; fi
 if [ "$INPUT" ] ; then
 	if [ "$INPUT" = "none" ] ; then
@@ -238,7 +263,7 @@ ok=0
 echo "What should the default umask for data files be (in octal)?"
 echo "(077 = only accessible by owner; 007 = accessible by owner and group)"
 while [ $ok -eq 0 ] ; do
-	echo -n "[$UMASK] "
+	echo2 "[$UMASK] "
 	if read INPUT ; then : ; else echo "" ; exit 1 ; fi
 	if [ ! "$INPUT" ] ; then
 		INPUT=$UMASK
@@ -262,7 +287,7 @@ if [ "$DEBUG" = "yes" ] ; then
 	TEMP_YN="y"
 fi
 echo "Would you like to build a debug version of Anope?"
-echo -n "[$TEMP_YN] "
+echo2 "[$TEMP_YN] "
 read YN
 if [ "$YN" ] ; then
 	if [ "$YN" = "y" ] ; then
@@ -280,7 +305,7 @@ echo "You may only need to do this if CMake is unable to locate"
 echo "missing dependencies without hints."
 echo "Separate directories with semicolons."
 echo "If you need no extra include directories, enter NONE in all caps."
-echo -n "[$EXTRA_INCLUDE_DIRS] "
+echo2 "[$EXTRA_INCLUDE_DIRS] "
 if read INPUT ; then : ; else echo "" ; exit 1 ; fi
 if [ "$INPUT" ] ; then
 	if [ "$INPUT" = "NONE" ] ; then
@@ -298,7 +323,7 @@ echo "You may only need to do this if CMake is unable to locate"
 echo "missing dependencies without hints."
 echo "Separate directories with semicolons."
 echo "If you need no extra library directories, enter NONE in all caps."
-echo -n "[$EXTRA_LIB_DIRS] "
+echo2 "[$EXTRA_LIB_DIRS] "
 if read INPUT ; then : ; else echo "" ; exit 1 ; fi
 if [ "$INPUT" ] ; then
 	if [ "$INPUT" = "NONE" ] ; then
@@ -313,7 +338,7 @@ echo ""
 
 echo "Are there any extra arguments you wish to pass to CMake?"
 echo "If you need no extra arguments to CMake, enter NONE in all caps."
-echo -n "[$EXTRA_CONFIG_ARGS] "
+echo2 "[$EXTRA_CONFIG_ARGS] "
 if read INPUT ; then : ; else echo "" ; exit 1 ; fi
 if [ "$INPUT" ] ; then
 	if [ "$INPUT" = "NONE" ] ; then
@@ -330,7 +355,7 @@ echo ""
 # Store values
 ################################################################################
 
-echo -n "Saving configuration results in config.cache... "
+echo2 "Saving configuration results in config.cache... "
 
 cat <<EOT >$SOURCE_DIR/config.cache
 INSTDIR="$INSTDIR"

README.md

@@ -4,7 +4,7 @@ Anope is an open source set of IRC services. It is highly modular, with a vast n
 
 * [Website](https://anope.org)
 * [GitHub](https://github.com/anope)
-* IRC \#anope on irc.teranova.net
+* IRC \#anope on irc.anope.org
 
 ## Installation
 
@@ -33,7 +33,7 @@ Copy conf/anope.example.conf to conf/anope.conf
 $ cp conf/anope.example.conf conf/anope.conf
 ```
 
-Edit anope.conf, configuring the uplink, serverinfo, and protocol module configurations. Example link blocks for popular IRCds are included in the the example.conf documentation. The [Anope wiki](https://wiki.anope.org) is also a good source of information. Our support channel is located at #anope on [irc.teranova.net](ircs://irc.teranova.net/anope).
+Edit anope.conf, configuring the uplink, serverinfo, and protocol module configurations. Example link blocks for popular IRCds are included in the anope.example.conf documentation. The [Anope wiki](https://wiki.anope.org) is also a good source of information. Our support channel is located at #anope on [irc.anope.org](irc://irc.anope.org/#anope).
 
 Note that the example configuration file includes other example configuration files. If you want to modify the other example configuration files, copy them (e.g. `modules.example.conf` to `modules.conf`) and modify the `include` directive in `anope.conf` to include the new file.
 

data/CMakeLists.txt

@@ -1,6 +1,6 @@
-# Only install cron.example.sh and anope.example.conf from this directory
+# Only install example.chk and anope.example.conf from this directory
 # NOTE: I would've had this just find all files in the directory, but that would include files not needed (like this file)
-set(DATA cron.example.sh anope.example.conf botserv.example.conf hostserv.example.conf modules.example.conf operserv.example.conf chanserv.example.conf global.example.conf memoserv.example.conf nickserv.example.conf chanstats.example.conf irc2sql.example.conf stats.standalone.example.conf)
+set(DATA example.chk anope.example.conf botserv.example.conf hostserv.example.conf modules.example.conf operserv.example.conf chanserv.example.conf global.example.conf memoserv.example.conf nickserv.example.conf chanstats.example.conf irc2sql.example.conf stats.standalone.example.conf)
 install(FILES ${DATA}
   DESTINATION ${CONF_DIR}
 )

data/anope.example.conf

@@ -238,15 +238,15 @@ serverinfo
 
 	/*
 	 * The filename containing the Anope process ID. The path is relative to the
-	 * data directory.
+	 * services root directory.
 	 */
-	pid = "anope.pid"
+	pid = "data/anope.pid"
 
 	/*
 	 * The filename containing the Message of the Day. The path is relative to the
-	 * config directory.
+	 * services root directory.
 	 */
-	motd = "motd.txt"
+	motd = "conf/motd.txt"
 }
 
 /*
@@ -265,7 +265,26 @@ serverinfo
  *  - solanum
  *  - unrealircd
  */
-module { name = "inspircd" }
+module
+{
+	name = "inspircd"
+
+	/*
+	 * Some protocol modules can enforce mode locks server-side. This reduces the spam caused by
+	 * services immediately reversing mode changes for locked modes.
+	 *
+	 * If the protocol module you have loaded does not support this, this setting will have no effect.
+	 */
+	use_server_side_mlock = yes
+
+	/*
+	 * Some protocol modules can enforce topic locks server-side. This reduces the spam caused by
+	 * services immediately reversing topic changes.
+	 *
+	 * If the protocol module you have loaded does not support this, this setting will have no effect.
+	 */
+	use_server_side_topiclock = yes
+}
 
 /*
  * [REQUIRED] Network Information
@@ -376,6 +395,19 @@ options
 	 */
 	casemap = "ascii"
 
+	/*
+	 * This key is used to initiate the random number generator. This number
+	 * MUST be random as you want your passcodes to be random. Don't give this
+	 * key to anyone! Keep it private!
+	 *
+	 * NOTE: If you don't uncomment this or keep the default values, any talented
+	 * programmer would be able to easily "guess" random strings used to mask
+	 * information. Be safe, and come up with a 7-digit number.
+	 *
+	 * This directive is optional, but highly recommended.
+	 */
+	#seed = 9866235
+
 	/*
 	 * Sets the number of invalid password tries before services removes a user
 	 * from the network. If a user enters a number of invalid passwords equal to
@@ -402,7 +434,7 @@ options
 	/*
 	 * Sets the delay between automatic database updates.
 	 */
-	updatetimeout = 2m
+	updatetimeout = 5m
 
 	/*
 	 * Sets the delay between checks for expired nicknames and channels.
@@ -414,6 +446,12 @@ options
 	 */
 	readtimeout = 5s
 
+	/*
+	 * Sets the interval between sending warning messages for program errors via
+	 * WALLOPS/GLOBOPS.
+	 */
+	warningtimeout = 4h
+
 	/*
 	 * Sets the (maximum) frequency at which the timeout list is checked. This,
 	 * combined with readtimeout above, determines how accurately timed events,
@@ -430,11 +468,26 @@ options
 	timeoutcheck = 3s
 
 	/*
-	 * If set Anope will tell users to use a server-side alias for messaging
-	 * services instead of /msg. The alias for each service defaults to the
-	 * bot name but can be configured in the service block.
+	 * If set, this will allow users to let services send PRIVMSGs to them
+	 * instead of NOTICEs. Also see the "msg" option of nickserv:defaults,
+	 * which also toggles the default communication (PRIVMSG or NOTICE) to
+	 * use for unregistered users.
+	 *
+	 * This is a feature that is against the IRC RFC and should be used ONLY
+	 * if absolutely necessary.
+	 *
+	 * This directive is optional, and not recommended.
 	 */
-	#servicealias = yes
+	#useprivmsg = yes
+
+	/*
+	 * If set, will force services to only respond to PRIVMSGs addresses to
+	 * Nick@ServerName - e.g. NickServ@example.com. This should be used in
+	 * conjunction with IRCd aliases. This directive is optional.
+	 *
+	 * This option will have no effect on some IRCds, such as TS6 IRCds.
+	 */
+	#usestrictprivmsg = yes
 
 	/*
 	 * If set, Anope will only show /stats o to IRC Operators. This directive
@@ -490,7 +543,7 @@ options
 	 *
 	 * Removing .UTF-8 will instead use the default encoding for the language, e.g. iso-8859-1 for western European languages.
 	 */
-	languages = "de_DE.UTF-8 el_GR.UTF-8 es_ES.UTF-8 fr_FR.UTF-8 it_IT.UTF-8 nl_NL.UTF-8 pl_PL.UTF-8 pt_PT.UTF-8 tr_TR.UTF-8"
+	languages = "ca_ES.UTF-8 de_DE.UTF-8 el_GR.UTF-8 es_ES.UTF-8 fr_FR.UTF-8 hu_HU.UTF-8 it_IT.UTF-8 nl_NL.UTF-8 pl_PL.UTF-8 pt_PT.UTF-8 ru_RU.UTF-8 tr_TR.UTF-8"
 
 	/*
 	 * Default language that non- and newly-registered nicks will receive messages in.
@@ -709,14 +762,13 @@ log
  *
  * Available privileges:
  *  botserv/administration        - Can view and assign private BotServ bots
- *  botserv/fantasy               - Can use fantasy commands without the FANTASY privilege
+ *  botserv/fantasy               - Can use fantasy commands without the FANTASIA privilege
  *  chanserv/administration       - Can modify the settings of any channel (including changing of the owner!)
  *  chanserv/access/list          - Can view channel access and akick lists, but not modify them
  *  chanserv/access/modify        - Can modify channel access and akick lists, and use /chanserv enforce
  *  chanserv/auspex               - Can see any information with /CHANSERV INFO
  *  chanserv/no-register-limit    - May register an unlimited number of channels and nicknames
  *  chanserv/kick                 - Can kick and ban users from channels through ChanServ
- *  chanserv/drop/override        - Allows dropping channels without using a confirmation code
  *  memoserv/info                 - Can see any information with /MEMOSERV INFO
  *  memoserv/set-limit            - Can set the limit of max stored memos on any user and channel
  *  memoserv/no-limit             - Can send memos through limits and throttles
@@ -725,8 +777,6 @@ log
  *  nickserv/cert                 - Can modify other users certificate lists
  *  nickserv/confirm              - Can confirm other users nicknames
  *  nickserv/drop                 - Can drop other users nicks
- *  nickserv/drop/display         - Allows dropping display nicks when preservedisplay is enabled
- *  nickserv/drop/override        - Allows dropping nicks without using a confirmation code
  *  nickserv/recover              - Can recover other users nicks
  *  operserv/config               - Can modify services's configuration
  *  operserv/oper/modify          - Can add and remove operators with at most the same privileges
@@ -752,7 +802,7 @@ log
  *
  *   hostserv/set            hostserv/del           hostserv/list
  *
- *   global/global         global/queue          global/server
+ *   global/global
  *
  *   operserv/news         operserv/stats        operserv/kick       operserv/exception    operserv/seen
  *   operserv/mode         operserv/session      operserv/modinfo    operserv/ignore       operserv/chanlist
@@ -802,6 +852,8 @@ opertype
 	 *
 	 * This can be used to automatically oper users who identify for services operator accounts, and is
 	 * useful for setting modes such as Plexus's user mode +N.
+	 *
+	 * Note that some IRCds, such as InspIRCd, do not allow directly setting +o, and this will not work.
 	 */
 	#modes = "+o"
 }
@@ -879,7 +931,7 @@ opertype
 /*
  * [OPTIONAL] Mail Config
  *
- * This section contains settings related to the use of email from services.
+ * This section contains settings related to the use of e-mail from services.
  * If the usemail directive is set to yes, unless specified otherwise, all other
  * directives are required.
  *
@@ -893,13 +945,13 @@ mail
 	 * If set, this option enables the mail commands in Anope. You may choose
 	 * to disable it if you have no Sendmail-compatible mailer installed. Whilst
 	 * this directive (and entire block) is optional, it is required if
-	 * nickserv:registration is set to mail.
+	 * nickserv:registration is set to yes.
 	 */
 	usemail = yes
 
 	/*
 	 * This is the command-line that will be used to call the mailer to send an
-	 * email. It must be called with all the parameters needed to make it
+	 * e-mail. It must be called with all the parameters needed to make it
 	 * scan the mail input to find the mail recipient; consult your mailer
 	 * documentation.
 	 *
@@ -911,18 +963,18 @@ mail
 	 * If you are running on Windows you should use a Windows sendmail port
 	 * like https://www.glob.com.au/sendmail/ for sending emails.
 	 */
-	#sendmailpath = "/usr/sbin/sendmail -it"
+	sendmailpath = "/usr/sbin/sendmail -t"
 
 	/*
-	 * This is the email address from which all the emails are to be sent from.
+	 * This is the e-mail address from which all the e-mails are to be sent from.
 	 * It should really exist.
 	 */
 	sendfrom = "services@example.com"
 
 	/*
 	 * This controls the minimum amount of time a user must wait before sending
-	 * another email after they have sent one. It also controls the minimum time
-	 * a user must wait before they can receive another email.
+	 * another e-mail after they have sent one. It also controls the minimum time
+	 * a user must wait before they can receive another e-mail.
 	 *
 	 * This feature prevents users from being mail bombed using services and
 	 * it is highly recommended that it be used.
@@ -933,10 +985,10 @@ mail
 
 	/*
 	 * If set, Anope will not put quotes around the TO: fields
-	 * in emails.
+	 * in e-mails.
 	 *
 	 * This directive is optional, and as far as we know, it's only needed
-	 * if you are using ESMTP or QMail to send out emails.
+	 * if you are using ESMTP or QMail to send out e-mails.
 	 */
 	#dontquoteaddresses = yes
 
@@ -1053,22 +1105,6 @@ mail
 	#hash = "md5"
 }
 
-/*
- * db_atheme
- *
- * This allows importing databases from Atheme. You should load another database module as
- * well as this as it can only read Atheme databases not write them.
- */
-#module
-{
-	name = "db_atheme"
-
-	/*
-	 * The database name db_atheme should use.
-	 */
-	database = "atheme.db"
-}
-
 /*
  * [RECOMMENDED] db_flatfile
  *
@@ -1112,6 +1148,11 @@ module
 	 * This is only useful with very large databases, with hundreds
 	 * of thousands of objects, that have a noticeable delay from
 	 * writing databases.
+	 *
+	 * If your database is large enough cause a noticeable delay when
+	 * saving you should consider a more powerful alternative such
+	 * as db_sql or db_redis, which incrementally update their
+	 * databases asynchronously in real time.
 	 */
 	fork = no
 }
@@ -1149,10 +1190,9 @@ module
 
 	/* Whether or not to import data from another database module in to SQL on startup.
 	 * If you enable this, be sure that the database services is configured to use is
-	 * empty and that another database module to import from is loaded BEFORE db_sql.
-	 * After you enable this and do a database import you MUST disable it for
-	 * subsequent restarts. If you want to keep writing a flatfile database after the
-	 * SQL import is done you should load db_flatfile AFTER this module.
+	 * empty and that another database module to import from is loaded before db_sql.
+	 * After you enable this and do a database import you should disable it for
+	 * subsequent restarts.
 	 *
 	 * Note that you can not import databases using db_sql_live. If you want to import
 	 * databases and use db_sql_live you should import them using db_sql, then shut down
@@ -1185,121 +1225,49 @@ module
 /*
  * [RECOMMENDED] Encryption modules.
  *
- * The encryption modules are used when dealing with passwords. This determines
- * how the passwords are stored in the databases.
+ * The encryption modules are used when dealing with passwords. This determines how
+ * the passwords are stored in the databases, and does not add any security as
+ * far as transmitting passwords over the network goes.
+ *
+ * Without any encryption modules loaded users will not be able to authenticate unless
+ * there is another module loaded that provides authentication checking, such as
+ * ldap_authentication or sql_authentication.
+ *
+ * With enc_none, passwords will be stored in plain text, allowing for passwords
+ * to be recovered later but it isn't secure and therefore is not recommended.
+ *
+ * The other encryption modules use one-way encryption, so the passwords can not
+ * be recovered later if those are used.
+ *
+ * The first encryption module loaded is the primary encryption module. All new passwords are
+ * encrypted by this module. Old passwords stored in another encryption method are
+ * automatically re-encrypted by the primary encryption module on next identify.
+ *
+ * enc_md5, enc_sha1, and enc_old are deprecated, and are provided for users
+ * to upgrade to a newer encryption module. Do not use them as the primary
+ * encryption module. They will be removed in a future release.
  *
- * The first encryption module loaded is the primary encryption module. All new
- * passwords are encrypted by this module. Old passwords encrypted with another
- * encryption method are automatically re-encrypted with the primary encryption
- * module the next time the user identifies.
  */
 
-/*
- * enc_sha2
- *
- * Provides support for encrypting passwords using the HMAC-SHA-2 algorithm. See
- * https://en.wikipedia.org/wiki/SHA-2 and https://en.wikipedia.org/wiki/HMAC
- * for more information.
- */
-module
-{
-	name = "enc_sha2"
+#module { name = "enc_bcrypt" }
+module { name = "enc_sha256" }
 
-	/** The sub-algorithm to use. Can be set to sha224 for SHA-224, sha256 for
-	 * SHA-256, sha284 for SHA-384 or sha512 to SHA-512. Defaults to sha256.
-	 */
-	#algorithm = "sha256"
-}
-
-/*
- * [EXTRA] enc_argon2
- *
- * Provides support for encrypting passwords using the Argon2 algorithm. See
- * https://en.wikipedia.org/wiki/Argon2 for more information.
- */
-#module
-{
-	name = "enc_argon2"
-
-	/** The sub-algorithm to use. Can be set to argon2d for Argon2d, argon2i for
-	 * Argon2i, or argon2id for Argon2id. Defaults to argon2id.
-	 */
-	#algorithm = "argon2id"
-
-	/** The memory hardness in kibibytes of the Argon2 algorithm. Defaults to
-	 * 128 mebibytes.
-	 */
-	#memory_cost = 121072
-
-	/** The time hardness (iterations) of the Argon2 algorithm. Defaults to 3.
-	 */
-	#time_cost = 3
-
-	/** The amount of parallel threads to use when encrypting passwords.
-	 * Defaults to 1.
-	 */
-	#parallelism = 1
-
-	/** The length in bytes of an Argon2 hash. Defaults to 32. */
-	#hash_length = 32
-
-	/** The length in bytes of an Argon2 salt. Defaults to 32. */
-	#salt_length = 32
-}
-
-/*
- * enc_bcrypt
- *
- * Provides support for encrypting passwords using the Bcrypt algorithm. See
- * https://en.wikipedia.org/wiki/Bcrypt for more information.
- */
-#module
-{
-	name = "enc_bcrypt"
-
-	/** The number of Bcrypt rounds to perform on passwords. Can be set to any
-	 * number between 10 and 32 but higher numbers are more CPU intensive and
-	 * may impact performance.
-	 */
-	#rounds = 10
-}
-
-/*
- * [EXTRA] enc_posix
- *
- * Provides verify-only support for passwords encrypted using the POSIX crypt()
- * function. Load this if you are migrating from another services packages such
- * as Atheme. See https://en.wikipedia.org/wiki/Crypt_(C) for more information.
- *
- * You must load another encryption method before this to re-encrypt passwords
- * with when a user logs in.
- */
-#module { name = "enc_posix" }
-
-/*
- * [DEPRECATED] enc_md5, enc_none, enc_old, enc_sha1, enc_sha256
- *
- * Provides verify-only support for passwords encrypted using encryption methods
- * from older versions of Anope. These methods are no longer considered secure
- * and will be removed in a future version of Anope. Only load them if you are
- * upgrading from a previous version of Anope that used them.
- *
- * enc_md5:    Verifies passwords encrypted with the MD5 algorithm
- * enc_none:   Verifies passwords that are not encrypted
- * enc_sha1:   Verifies passwords encrypted with the SHA1 algorithm
- * enc_old:    Verifies passwords encrypted with the broken MD5 algorithm used
- *             before 1.7.17.
- * enc_sha256: Verifies passwords encrypted with the SHA256 algorithm using a
- *             custom initialisation vector as a salt.
- *
- * You must load another encryption method before this to re-encrypt passwords
- * with when a user logs in.
- */
+ /*
+ * [DEPRECATED] Deprecated encryption modules. You can only use these for compatibility with
+ * old databases and will need to load one of the above modules as your primary encryption
+ * module.
+  */
 #module { name = "enc_md5" }
 #module { name = "enc_none" }
-#module { name = "enc_old" }
 #module { name = "enc_sha1" }
-#module { name = "enc_sha256" }
+
+/*
+ * enc_old is Anope's previous (broken) MD5 implementation used from 1.4.x to 1.7.16.
+ * If your databases were made using that module, load it here to allow conversion to the primary
+ * encryption method.
+ */
+#module { name = "enc_old" }
+
 
 /* Extra (optional) modules. */
 include

data/botserv.example.conf

@@ -59,17 +59,6 @@ service
 	 * Prefixes may be given to the channels in the form of mode characters or prefix symbols.
 	 */
 	#channels = "@#services,#mychan"
-
-	/*
-	 * The server alias that can be used to securely message this service. If
-	 * your IRC server does not have an alias for this service you can set this
-	 * to an empty string to tell users to use /msg instead.
-	 *
-	 * This setting is ignored when options:servicealias is disabled.
-	 *
-	 * Defaults to the nick of the service if not set.
-	 */
-	#alias = "BS"
 }
 
 /*
@@ -194,7 +183,7 @@ module
 	/*
 	 * The maximum number of entries a single bad words list can have.
 	 */
-	badwordsmax = 50
+	badwordsmax = 32
 
 	/*
 	 * If set, BotServ will use case sensitive checking for badwords.
@@ -345,10 +334,10 @@ privilege
 /*
  * fantasy
  *
- * Allows fantasy commands (e.g. !kick) to be used in channels.
+ * Allows 'fantasist' commands to be used in channels.
  *
  * Provides the commands:
- *   botserv/set/fantasy - Used for enabling or disabling BotServ's fantasy commands.
+ *   botserv/set/fantasy - Used for enabling or disabling BotServ's fantasist commands.
  */
 module
 {

data/chanserv.example.conf

@@ -49,17 +49,6 @@ service
 	 * Prefixes may be given to the channels in the form of mode characters or prefix symbols.
 	 */
 	#channels = "@#services,#mychan"
-
-	/*
-	 * The server alias that can be used to securely message this service. If
-	 * your IRC server does not have an alias for this service you can set this
-	 * to an empty string to tell users to use /msg instead.
-	 *
-	 * This setting is ignored when options:servicealias is disabled.
-	 *
-	 * Defaults to the nick of the service if not set.
-	 */
-	#alias = "CS"
 }
 
 /*
@@ -118,21 +107,22 @@ module
 	/*
 	 * The length of time before a channel registration expires.
 	 *
-	 * This directive is optional. If not set, the default is never.
+	 * This directive is optional, but recommended.
+	 * If not set, the default is 30 days.
 	 */
-	#expire = 90d
+	expire = 30d
 
 	/*
 	 * The maximum number of entries on a channel's access list.
-	 * If not set, the default is 1000. This can be set to 0 for unlimited.
+	 * If not set, the default is 1024. This can be set to 0 for unlimited.
 	 */
-	accessmax = 1000
+	accessmax = 1024
 
 	/*
 	 * The length of time ChanServ stays in a channel after kicking a user from a channel they are not
 	 * permitted to be in. This only occurs when the user is the only one in the channel.
 	 */
-	inhabit = 1m
+	inhabit = 15s
 
 	/*
 	 * Allow only IRC Operators to use ChanServ.
@@ -402,7 +392,7 @@ privilege
 }
 
 /*
- * FANTASY privilege.
+ * FANTASIA privilege.
  *
  * Used by botserv/main and chanserv/xop.
  *
@@ -410,7 +400,7 @@ privilege
  */
 privilege
 {
-	name = "FANTASY"
+	name = "FANTASIA"
 	desc = _("Allowed to use fantasy commands")
 	rank = 30
 	level = 3
@@ -737,7 +727,7 @@ privilege
 privilege
 {
 	name = "SET"
-	desc = _("Allowed to modify channel settings")
+	desc = _("Allowed to set channel settings")
 	rank = 320
 	level = 9999
 	flag = "s"
@@ -923,7 +913,7 @@ module
 	/*
 	 * The maximum number of entries on a channel's autokick list.
 	 */
-	autokickmax = 50
+	autokickmax = 32
 
 	/*
 	 * The default reason for an autokick if none is given.
@@ -1136,7 +1126,7 @@ module
 	 *
 	 * This directive is optional.
 	 */
-	max = 50
+	max = 32
 }
 command { service = "ChanServ"; name = "MODE"; command = "chanserv/mode"; group = "chanserv/management"; }
 
@@ -1256,8 +1246,8 @@ command { service = "ChanServ"; name = "SET NOEXPIRE"; command = "chanserv/saset
  * A field named misc_description may be given for use with help output.
  */
 module { name = "cs_set_misc" }
-command { service = "ChanServ"; name = "SET URL"; command = "chanserv/set/misc"; misc_description = _("Associate a URL with the channel"); misc_numeric = 328; }
-command { service = "ChanServ"; name = "SET EMAIL"; command = "chanserv/set/misc"; misc_description = _("Associate an email address with the channel"); }
+command { service = "ChanServ"; name = "SET URL"; command = "chanserv/set/misc"; misc_description = _("Associate a URL with the channel"); }
+command { service = "ChanServ"; name = "SET EMAIL"; command = "chanserv/set/misc"; misc_description = _("Associate an E-mail address with the channel"); }
 
 /*
  * cs_status
@@ -1288,7 +1278,7 @@ module
 	 * This directive is optional.
 	 * If not set, the default is never.
 	 */
-	suspendexpire = 90d
+	expire = 90d
 
 	/*
 	 * Settings to show to non-opers in ChanServ's INFO output.

data/global.example.conf

@@ -49,17 +49,6 @@ service
 	 * Prefixes may be given to the channels in the form of mode characters or prefix symbols.
 	 */
 	#channels = "@#services,#mychan"
-
-	/*
-	 * The server alias that can be used to securely message this service. If
-	 * your IRC server does not have an alias for this service you can set this
-	 * to an empty string to tell users to use /msg instead.
-	 *
-	 * This setting is ignored when options:servicealias is disabled.
-	 *
-	 * Defaults to the nick of the service if not set.
-	 */
-	#alias = "GL"
 }
 
 /*
@@ -124,29 +113,3 @@ command { service = "Global"; name = "HELP"; command = "generic/help"; }
  */
 module { name = "gl_global" }
 command { service = "Global"; name = "GLOBAL"; command = "global/global"; permission = "global/global"; }
-
-/*
- * gl_queue
- *
- * Provides the command global/queue.
- *
- * Used for queuing messages to send to every online user.
- */
-module
-{
-	name = "gl_queue"
-
-	/* The maximum number of messages in a message queue. Defaults to 10. */
-	maxqueue = 10
-}
-command { service = "Global"; name = "QUEUE"; command = "global/queue"; permission = "global/queue"; }
-
-/*
- * gl_server
- *
- * Provides the command global/server.
- *
- * Used for sending a message to every online user on a server.
- */
-module { name = "gl_server" }
-command { service = "Global"; name = "SERVER"; command = "global/server"; permission = "global/server"; }

data/hostserv.example.conf

@@ -49,17 +49,6 @@ service
 	 * Prefixes may be given to the channels in the form of mode characters or prefix symbols.
 	 */
 	#channels = "@#services,#mychan"
-
-	/*
-	 * The server alias that can be used to securely message this service. If
-	 * your IRC server does not have an alias for this service you can set this
-	 * to an empty string to tell users to use /msg instead.
-	 *
-	 * This setting is ignored when options:servicealias is disabled.
-	 *
-	 * Defaults to the nick of the service if not set.
-	 */
-	#alias = "HS"
 }
 
 /*

data/memoserv.example.conf

@@ -49,17 +49,6 @@ service
 	 * Prefixes may be given to the channels in the form of mode characters or prefix symbols.
 	 */
 	#channels = "@#services,#mychan"
-
-	/*
-	 * The server alias that can be used to securely message this service. If
-	 * your IRC server does not have an alias for this service you can set this
-	 * to an empty string to tell users to use /msg instead.
-	 *
-	 * This setting is ignored when options:servicealias is disabled.
-	 *
-	 * Defaults to the nick of the service if not set.
-	 */
-	#alias = "MS"
 }
 
 /*
@@ -94,7 +83,7 @@ module
 	 *
 	 * This directive is optional, but recommended.
 	 */
-	senddelay = 30s
+	senddelay = 3s
 }
 
 /*
@@ -157,7 +146,7 @@ module
 	 *
 	 * This directive is optional.
 	 */
-	max = 50
+	max = 32
 }
 command { service = "MemoServ"; name = "IGNORE"; command = "memoserv/ignore"; }
 

data/modules.example.conf

@@ -59,7 +59,7 @@ module { name = "help" }
 	 * SOA record information.
 	 */
 
-	/* Email address of the DNS administrator. */
+	/* E-mail address of the DNS administrator. */
 	admin = "admin@example.com"
 
 	/* This should be the names of the public facing nameservers serving the records. */
@@ -254,7 +254,7 @@ module { name = "help" }
 }
 
 /*
- * ldap_authentication
+ * ldap_authentication [EXTRA]
  *
  * This module allows many commands such as IDENTIFY, RELEASE, RECOVER, GHOST, etc. use
  * LDAP to authenticate users. Requires ldap.
@@ -314,7 +314,7 @@ module { name = "help" }
 }
 
 /*
- * ldap_oper
+ * ldap_oper [EXTRA]
  *
  * This module dynamically ties users to Anope opertypes when they identify
  * via LDAP group membership. Requires ldap.
@@ -372,7 +372,6 @@ module { name = "help" }
 		username = "anope"
 		password = "mypassword"
 		port = 3306
-		socket = ""
 	}
 }
 
@@ -581,8 +580,7 @@ module { name = "sasl" }
 	name = "ssl_gnutls"
 
 	/*
-	 * An optional certificate and key for ssl_gnutls to give to the uplink. All
-	 * paths are relative to the config directory.
+	 * An optional certificate and key for ssl_gnutls to give to the uplink.
 	 *
 	 * You can generate your own certificate and key pair by using:
 	 *
@@ -590,8 +588,8 @@ module { name = "sasl" }
 	 *   certtool --generate-self-signed --load-privkey privkey.pem --outfile fullchain.pem
 	 *
 	 */
-	cert = "fullchain.pem"
-	key = "privkey.pem"
+	cert = "data/fullchain.pem"
+	key = "data/privkey.pem"
 
 	/*
 	 * Diffie-Hellman parameters to use when acting as a server. This is only
@@ -604,7 +602,7 @@ module { name = "sasl" }
 	 *   certtool --generate-dh-params --bits 2048 --outfile dhparams.pem
 	 *
 	 */
-	#dhparams = "dhparams.pem"
+#	dhparams = "data/dhparams.pem"
 }
 
 /*
@@ -622,15 +620,14 @@ module { name = "sasl" }
 
 	/*
 	 * An optional certificate and key for ssl_openssl to give to the uplink.
-	 * All paths are relative to the config directory.
 	 *
 	 * You can generate your own certificate and key pair by using:
 	 *
 	 *   openssl genrsa -out privkey.pem 2048
 	 *   openssl req -new -x509 -key privkey.pem -out fullchain.pem -days 1095
 	 */
-	cert = "fullchain.pem"
-	key = "privkey.pem"
+	cert = "data/fullchain.pem"
+	key = "data/privkey.pem"
 
 	/*
 	 * If you wish to increase security you can disable support for older
@@ -643,7 +640,7 @@ module { name = "sasl" }
 }
 
 /*
- * sql_authentication
+ * sql_authentication [EXTRA]
  *
  * This module allows authenticating users against an external SQL database using a custom
  * query.
@@ -694,7 +691,7 @@ module { name = "sasl" }
 }
 
 /*
- * sql_log
+ * sql_log [EXTRA]
  *
  * This module adds an additional target option to log{} blocks
  * that allows logging Service's logs to SQL. To log to SQL, add
@@ -714,7 +711,7 @@ module { name = "sasl" }
 #module { name = "sql_log" }
 
 /*
- * sql_oper
+ * sql_oper [EXTRA]
  *
  * This module allows granting users services operator privileges and possibly IRC Operator
  * privileges based on an external SQL database using a custom query.
@@ -755,7 +752,7 @@ module { name = "sasl" }
 		name = "sqlite/main"
 
 		/* The database name, it will be created if it does not exist. */
-		database = "anope.sqlite"
+		database = "anope.db"
 	}
 }
 
@@ -773,16 +770,13 @@ module { name = "sasl" }
 	name = "webcpanel"
 
 	/* Web server to use. */
-	server = "httpd/main"
+	server = "httpd/main";
 
-	/*
-	 * The directory containing the webcpanel templates. This is relative to the
-	 * data directory.
-	 */
-	template_dir = "webcpanel/templates/default"
+	/* Template to use. */
+	template = "default";
 
 	/* Page title. */
-	title = "Anope IRC Services"
+	title = "Anope IRC Services";
 }
 
 /*

data/nickserv.example.conf

@@ -49,17 +49,6 @@ service
 	 * Prefixes may be given to the channels in the form of mode characters or prefix symbols.
 	 */
 	#channels = "@#services,#mychan"
-
-	/*
-	 * The server alias that can be used to securely message this service. If
-	 * your IRC server does not have an alias for this service you can set this
-	 * to an empty string to tell users to use /msg instead.
-	 *
-	 * This setting is ignored when options:servicealias is disabled.
-	 *
-	 * Defaults to the nick of the service if not set.
-	 */
-	#alias = "NS"
 }
 
 /*
@@ -77,9 +66,9 @@ module
 	client = "NickServ"
 
 	/*
-	 * Requires users to give an email address when they register a nick.
+	 * Force users to give an e-mail address when they register a nick.
 	 *
-	 * This directive defaults to "yes" and is recommended to be enabled.
+	 * This directive defaults to "yes" and is recommended to be enabled. This is required if e-mail registration is enabled.
 	 */
 	forceemail = yes
 
@@ -108,7 +97,7 @@ module
 	 * -    kill_immed: Kill nick immediately if not identified, this one overrides both the killprotect
 	 *                    and kill_quick options and the killprotect option must be specified with this one
 	 * -    ns_private: Hide the nick from NickServ's LIST command
-	 * -    hide_email: Hide the nick's email address from NickServ's INFO command
+	 * -    hide_email: Hide the nick's e-mail address from NickServ's INFO command
 	 * -     hide_mask: Hide the nick's last or current user@host from NickServ's INFO command
 	 * -   hide_status: Hide the nick's services operator access status from NickServ's INFO command
 	 * -     hide_quit: Hide the nick's last quit message from NickServ's INFO command
@@ -117,7 +106,8 @@ module
 	 * -     memo_mail: Notify user if they have a new memo by mail
 	 * -        autoop: User will be automatically opped in channels they enter and have access to
 	 * -       neverop: User can not be added to access lists
-	 * -           msg: Messages will be sent as PRIVMSGs instead of NOTICEs
+	 * -           msg: Messages will be sent as PRIVMSGs instead of NOTICEs, requires options:useprivmsg
+	 *                  to be enabled as well
 	 * - ns_keep_modes: Enables keepmodes, which retains user modes across sessions
 	 *
 	 * This directive is optional, if left blank, the options will default to memo_signon, and
@@ -129,14 +119,14 @@ module
 	 * The minimum length of time between consecutive uses of NickServ's REGISTER command. This
 	 * directive is optional, but recommended. If not set, this restriction will be disabled.
 	 */
-	regdelay = 5m
+	regdelay = 30s
 
 	/*
 	 * The length of time before a nick's registration expires.
 	 *
-	 * This directive is optional, but recommended. If not set, the default is one year.
+	 * This directive is optional, but recommended. If not set, the default is 90 days.
 	 */
-	expire = 1y
+	expire = 90d
 
 	/*
 	 * Prevents the use of the ACCESS and CERT (excluding their LIST subcommand), DROP, FORBID, SUSPEND
@@ -203,17 +193,13 @@ module
 	releasetimeout = 1m
 
 	/*
-	 * When a user's nick is forcibly changed to enforce nickname protection their new
-	 * nick will be based on this value. Any # in the value will be replaced with a random
-	 * number. If your IRCd has support for unique identifiers you can also set this to an
-	 * empty string to change a user's nick to their unique identifier.
+	 * When a user's nick is forcibly changed to enforce a "nick kill", their new nick will start
+	 * with this value. The rest will be made up of 6 or 7 digits.
+	 * Make sure this is a valid nick and Nicklen+7 is not longer than the allowed Nicklen on your ircd.
 	 *
-	 * Make sure this is a valid nick and that it is is not longer than the maximum nick
-	 * length on your IRCd.
-	 *
-	 * This directive is optional. If not set it defaults to "Guest####"
+	 * This directive is optional. If not set it defaults to "Guest"
 	 */
-	guestnick = "Guest####"
+	guestnickprefix = "Guest"
 
 	/*
 	 * If set, Anope does not allow ownership of nick names, only ownership of accounts.
@@ -233,12 +219,6 @@ module
 	 * This directive is optional. If not set it defaults to 50.
 	 */
 	maxpasslen = 50
-
-	/*
-	 * Whether all of the secondary nicks of a nick group have to expire or be
-	  dropped before the display nick can expire or be dropped.
-	 */
-	preservedisplay = no
 }
 
 /*
@@ -293,7 +273,6 @@ command { service = "NickServ"; name = "AJOIN"; command = "nickserv/ajoin"; }
  */
 module { name = "ns_alist" }
 command { service = "NickServ"; name = "ALIST"; command = "nickserv/alist"; }
-command { service = "NickServ"; name = "ACCESS"; command = "nickserv/alist"; hide = true; }
 
 /*
  * ns_cert
@@ -306,12 +285,6 @@ module
 {
 	name = "ns_cert"
 
-	/*
-	* Should users who are connected with a SSL client certificate have its fingerprint be added to
-	* their account when they register. Defaults to yes.
-	*/
-	automatic = yes
-
 	/*
 	 * The maximum number of entries allowed on a nickname's certificate fingerprint list.
 	 * The default is 5. This number cannot be set to 0.
@@ -356,7 +329,7 @@ module
 	 *
 	 * This directive is optional, but recommended. If not set or set to 0, no limits will be applied.
 	 */
-	maxaliases = 10
+	maxaliases = 16
 
 	/*
 	 * If set, the NickServ GROUP command won't allow any group changes. This is recommended to
@@ -494,7 +467,7 @@ module
 	 *
 	 * This directive is optional.
 	 */
-	nickregdelay = 15s
+	#nickregdelay = 30s
 
 	/*
 	 * The length of time a user using an unconfirmed account has
@@ -525,11 +498,24 @@ command { service = "NickServ"; name = "RESETPASS"; command = "nickserv/resetpas
  *   nickserv/set/display, nickserv/saset/display - Used for setting a users display name.
  *   nickserv/set/email, nickserv/saset/email - Used for setting a users email address.
  *   nickserv/set/keepmodes, nickserv/saset/keepmodes - Configure whether or not services should retain a user's modes across sessions.
+ *   nickserv/set/kill, nickserv/saset/kill - Used for configuring nickname protection.
+ *   nickserv/set/language, nickserv/saset/language - Used for configuring what language services use.
+ *   nickserv/set/message, nickserv/saset/message - Used to configure how services send messages to you.
  *   nickserv/set/neverop, nickserv/saset/neverop - Used to configure whether a user can be added to access lists
  *   nickserv/saset/noexpire - Used for configuring noexpire, which prevents nicks from expiring.
  *   nickserv/set/password, nickserv/saset/password  - Used for changing a users password.
  */
-module { name = "ns_set" }
+module
+{
+	name = "ns_set"
+
+	/*
+	 * Allow the use of the IMMED option in the NickServ SET KILL command.
+	 *
+	 * This directive is optional.
+	 */
+	#allowkillimmed = yes
+}
 
 command { service = "NickServ"; name = "SET"; command = "nickserv/set"; }
 command { service = "NickServ"; name = "SASET"; command = "nickserv/saset"; permission = "nickserv/saset/"; group = "nickserv/admin"; }
@@ -546,6 +532,15 @@ command { service = "NickServ"; name = "SASET EMAIL"; command = "nickserv/saset/
 command { service = "NickServ"; name = "SET KEEPMODES"; command = "nickserv/set/keepmodes"; }
 command { service = "NickServ"; name = "SASET KEEPMODES"; command = "nickserv/saset/keepmodes"; permission = "nickserv/saset/keepmodes"; }
 
+command { service = "NickServ"; name = "SET KILL"; command = "nickserv/set/kill"; }
+command { service = "NickServ"; name = "SASET KILL"; command = "nickserv/saset/kill"; permission = "nickserv/saset/kill"; }
+
+command { service = "NickServ"; name = "SET LANGUAGE"; command = "nickserv/set/language"; }
+command { service = "NickServ"; name = "SASET LANGUAGE"; command = "nickserv/saset/language"; permission = "nickserv/saset/language"; }
+
+command { service = "NickServ"; name = "SET MESSAGE"; command = "nickserv/set/message"; }
+command { service = "NickServ"; name = "SASET MESSAGE"; command = "nickserv/saset/message"; permission = "nickserv/saset/message"; }
+
 command { service = "NickServ"; name = "SET PASSWORD"; command = "nickserv/set/password"; }
 command { service = "NickServ"; name = "SASET PASSWORD"; command = "nickserv/saset/password"; permission = "nickserv/saset/password"; }
 
@@ -554,53 +549,6 @@ command { service = "NickServ"; name = "SASET NEVEROP"; command = "nickserv/sase
 
 command { service = "NickServ"; name = "SASET NOEXPIRE"; command = "nickserv/saset/noexpire"; permission = "nickserv/saset/noexpire"; }
 
-/*
- * ns_set_kill
- *
- * Provides the commands nickserv/set/kill and kickserv/saset/kill.
- *
- * Used for configuring nickname protection.
- */
-module
-{
-	name = "ns_set_kill"
-
-	/*
-	 * Allow the use of the IMMED option in the NickServ SET KILL command.
-	 *
-	 * This directive is optional.
-	 */
-	#allowkillimmed = yes
-}
-
-command { service = "NickServ"; name = "SET KILL"; command = "nickserv/set/kill"; }
-command { service = "NickServ"; name = "SASET KILL"; command = "nickserv/saset/kill"; permission = "nickserv/saset/kill"; }
-
-/*
- * ns_set_language
- *
- * Provides the command nickserv/set/language and nickserv/saset/language.
- *
- * Allows configuring the language that services uses.
- */
-module { name = "ns_set_language" }
-command { service = "NickServ"; name = "SET LANGUAGE"; command = "nickserv/set/language"; }
-command { service = "NickServ"; name = "SASET LANGUAGE"; command = "nickserv/saset/language"; permission = "nickserv/saset/language"; }
-
-/*
- * ns_set_message
- *
- * Provides the commands nickserv/set/message and nickserv/saset/message.
- *
- * Allows users to let services send them PRIVMSGs instead of NOTICEs.
- *
- * This might cause problems with badly written clients as the IRC RFC
- * requires that automatic responses to a PRIVMSG use a NOTICE to avoid
- * message loops. Only enable this if you are sure this can not happen.
- */
-#module { name = "ns_set_message" }
-#command { service = "NickServ"; name = "SET MESSAGE"; command = "nickserv/set/message"; }
-#command { service = "NickServ"; name = "SASET MESSAGE"; command = "nickserv/saset/message"; permission = "nickserv/saset/message"; }
 
 /*
  * ns_set_misc
@@ -615,10 +563,10 @@ command { service = "NickServ"; name = "SET URL"; command = "nickserv/set/misc";
 command { service = "NickServ"; name = "SASET URL"; command = "nickserv/saset/misc"; misc_description = _("Associate a URL with this account"); permission = "nickserv/saset/url"; group = "nickserv/admin"; }
 #command { service = "NickServ"; name = "SET DISCORD"; command = "nickserv/set/misc"; misc_description = _("Associate a Discord account with your account"); }
 #command { service = "NickServ"; name = "SASET DISCORD"; command = "nickserv/saset/misc"; misc_description = _("Associate a Discord account with this account"); permission = "nickserv/saset/discord"; group = "nickserv/admin"; }
+#command { service = "NickServ"; name = "SET FACEBOOK"; command = "nickserv/set/misc"; misc_description = _("Associate a Facebook URL with your account"); }
+#command { service = "NickServ"; name = "SASET FACEBOOK"; command = "nickserv/saset/misc"; misc_description = _("Associate a Facebook URL with this account"); permission = "nickserv/saset/facebook"; group = "nickserv/admin"; }
 #command { service = "NickServ"; name = "SET MASTODON"; command = "nickserv/set/misc"; misc_description = _("Associate a Mastodon account with your account"); }
 #command { service = "NickServ"; name = "SASET MASTODON"; command = "nickserv/saset/misc"; misc_description = _("Associate a Mastodon account with this account"); permission = "nickserv/saset/mastodon"; group = "nickserv/admin"; }
-#command { service = "NickServ"; name = "SET TIMEZONE"; command = "nickserv/set/misc"; misc_description = _("Associate a time zone with your account"); }
-#command { service = "NickServ"; name = "SASET TIMEZONE"; command = "nickserv/saset/misc"; misc_description = _("Associate a time zone with this account"); permission = "nickserv/saset/timezone"; group = "nickserv/admin"; }
 
 /*
  * ns_suspend
@@ -674,7 +622,7 @@ command { service = "NickServ"; name = "UPDATE"; command = "nickserv/update"; }
 	name = "ns_maxemail"
 
 	/*
-	 * The limit to how many registered nicks can use the same email address. If set to 0 or left
+	 * The limit to how many registered nicks can use the same e-mail address. If set to 0 or left
 	 * commented, there will be no limit enforced when registering new accounts or using
 	 * /msg NickServ SET EMAIL.
 	 */

data/operserv.example.conf

@@ -49,17 +49,6 @@ service
 	 * Prefixes may be given to the channels in the form of mode characters or prefix symbols.
 	 */
 	#channels = "@#services,#mychan"
-
-	/*
-	 * The server alias that can be used to securely message this service. If
-	 * your IRC server does not have an alias for this service you can set this
-	 * to an empty string to tell users to use /msg instead.
-	 *
-	 * This setting is ignored when options:servicealias is disabled.
-	 *
-	 * Defaults to the nick of the service if not set.
-	 */
-	#alias = "OS"
 }
 
 /*
@@ -514,7 +503,7 @@ command { service = "OperServ"; name = "RANDOMNEWS"; command = "operserv/randomn
  *
  * Used to NOOP a server, which prevents users from opering on that server.
  */
-#module { name = "os_noop" }
+module { name = "os_noop" }
 command { service = "OperServ"; name = "NOOP"; command = "operserv/noop"; permission = "operserv/noop"; }
 
 /*

data/stats.standalone.example.conf

@@ -235,15 +235,15 @@ serverinfo
 
 	/*
 	 * The filename containing the Anope process ID. The path is relative to the
-	 * data directory.
+	 * services root directory.
 	 */
-	pid = "anope.pid"
+	pid = "data/anope.pid"
 
 	/*
 	 * The filename containing the Message of the Day. The path is relative to the
-	 * config directory.
+	 * services root directory.
 	 */
-	motd = "motd.txt"
+	motd = "conf/motd.txt"
 }
 
 /*
@@ -371,6 +371,12 @@ options
 	 */
 	readtimeout = 5s
 
+	/*
+	 * Sets the interval between sending warning messages for program errors via
+	 * WALLOPS/GLOBOPS.
+	 */
+	warningtimeout = 4h
+
 	/*
 	 * If set, Anope will only show /stats o to IRC Operators. This directive
 	 * is optional.

docs/Changes

@@ -1,125 +1,3 @@
-Anope Version 2.1.11
---------------------
-Added support for database migrations to the mysql module.
-Added support for renicking users to their UID when enforcing nickname protection.
-Added support for sending channel URLs to joining users.
-Allowed selecting languages using a shorter version of their name.
-Changed various messages to use human-readable durations instead of seconds.
-Improved the creation of expiry and duration messages.
-Improved the translation system with support for plural forms.
-Reworked how guest nicknames are generated.
-Simplified how account identifiers are allocated.
-
-Anope Version 2.1.10
---------------------
-Added support for NEXTBANS on UnrealIRCd.
-Changed hostmask access entries added by nick to use that nick as the default description.
-Changed modes to be handled internally in their split form.
-Changed ns_cert to notify a user that their certificate is being automatically added to their account.
-Fixed matching users against extended bans.
-Fixed parsing name-only extended bans on InspIRCd.
-Fixed respecting the preferred extended ban format on InspIRCd.
-Fixed the name of the cron script in the docs.
-Updated the list of supported IRCds.
-Updated the location of the Anope IRC channels
-
-Anope Version 2.1.9
--------------------
-Bumped the minimum supported version of UnrealIRCd to 6.
-Fixed granting IRC operator status to services operators.
-Fixed making users an IRC operator on InspIRCd.
-Fixed nonicknameownership on InspIRCd v4.
-Fixed some messages not being translatable.
-Fixed the Argon2 module not having test vectors.
-Increased the default nickname expiry period to one year.
-
-Anope Version 2.1.8
--------------------
-Added account identifiers to the nickserv/info output.
-Added support for bool, float, and uint SQL columns.
-Added the ability to automatically determine SQL column types based on the native type.
-Added UNIX socket support to mysql module.
-Changed smartjoin to use SendClearBans where available.
-Dropped support for MinGW in favour of native builds.
-Fixed parsing named extbans on InspIRCd.
-Fixed parsing SVSMODE and SVS2MODE from UnrealIRCd.
-Fixed sending global messages to remotely linked servers.
-Removed the services server name from the CTCP version response.
-
-Anope Version 2.1.7
--------------------
-Added importing of akick reasons, forbid reasons, opers and session exceptions to db_atheme.
-Added support for sending tag messages.
-Added the ability to look up account information of an authenticated user.
-Fixed a crash in ns_cert when an IRC user is not present during a nick registration.
-Fixed a null pointer dereference in the global module.
-Fixed a rare memory leak in os_akill and os_sxline.
-Improved the performance of some code that looks up the primary nick from an account.
-Removed the broken Catalan, Hungarian, and Russian translations.
-Reworked the protocol interface for sending messages.
-Updated the Turkish translation.
-
-Anope Version 2.1.6
--------------------
-Added opportunistic upgrading of TLS fingerprints to more secure algorithms on InspIRCd.
-Added support for logging out partially connected users on Plexus.
-Added the account registration time to nickserv/info.
-Changed ns_cert to automatically add a TLS fingerprint to new accounts if available.
-Clarified that a non-deprecated encryption module must be loaded.
-Fixed creating the runtime directory on Windows.
-Fixed mistakenly allowing badpasslimit to be set to a negative value.
-Fixed parsing backup TLS fingerprints on InspIRCd.
-Fixed parsing the flood mode on UnrealIRCd.
-Fixed parsing the history mode on UnrealIRCd.
-Fixed various iterator invalidation issues.
-Partially rewrote the Portuguese translation.
-Removed some incorrect strings from the Turkish translation.
-Renamed the --modulesdir option to --moduledir to match the name of other path options.
-
-Anope Version 2.1.5
--------------------
-Added an example systemd unit file.
-Added support for BIGLINES on UnrealIRCd.
-Bumped the minimum supported version of Bahamut to 2.0.
-Fixed truncating messages in global/global and global/server.
-Improved building Anope for use as a system package.
-Updated the Turkish translation.
-
-Anope Version 2.1.4
--------------------
-Added a check for a non-deprecated encryption module on start.
-Added a way for protocol modules to report an error to the uplink.
-Added more account settings to the webcpanel.
-Added self-test functionality for all encryption modules.
-Added support for challenge authentication on InspIRCd.
-Added support for importing databases from Atheme.
-Added support for sending client tags on UnrealIRCd.
-Added support for the InspIRCd 1206 (v4) protocol.
-Added the --nopid option to disable writing a pid file.
-Added the enc_argon2 module to encrypt passwords with Argon2.
-Added the enc_sha2 module to encrypt passwords with HMAC-SHA-2.
-Added the global/queue command for queueing multi-line messages.
-Added the global/server command for sending messages to an individual server.
-Added the PASSWORD category to operserv/stats to view password encryption methods.
-Added the verify-only enc_posix module to validate passwords from Atheme that were encrypted with Argon2.
-Changed nickserv/drop to use confirmation codes to confirm a nickname drop.
-Changed various paths to be relative to the data and config directories.
-Converted some IRCDProto member functions to variables.
-Converted the enc_md5, enc_none, enc_old, enc_sha1, and enc_sha256 modules to be verify-only.
-Deduplicated page headers and footers in the webcpanel templates.
-Deprecated the enc_sha256 module.
-Fixed inconsistent spelling/casing of email, vhost, and vident.
-Fixed various bugs in the inspircd module.
-Improved portability of email sending.
-Improved protocol debug messages.
-Improved the performance and reliability of internal conversion logic.
-Improved the randomness of randomly generated numbers.
-Refactored the enc_bcrypt module and exposed it as an encryption context.
-Removed several duplicate translation strings.
-Replaced the custom MD5 implementation in enc_md5 with a vendored one.
-Replaced the custom SHA256 implementation in enc_sha256 with a vendored one.
-The ldap_authentication, ldap_oper, sql_authentication, sql_log, and sql_oper modules are now always enabled.
-
 Anope Version 2.1.3
 -------------------
 Added alternate command suggestions when a user runs an invalid command.
@@ -140,7 +18,7 @@ Reworked how messages are sent in protocol modules to allow sending message tags
 Anope Version 2.1.2
 -------------------
 Bumped the minimum OpenSSL version to 1.1.0.
-Bumped the minimum GnuTLS version to 3.0.0.
+Bumped the minumum GnuTLS version to 3.0.0.
 Disabled SSLv3 support in the m_ssl_openssl module.
 Modernized mutex and thread code to use Modern C++.
 Normalised the program exit codes.

docs/Changes.conf

@@ -1,62 +1,3 @@
-Anope Version 2.1.11
---------------------
-Moved module:allowkilimmed from the ns_set module to the ns_set_kill module.
-Moved nickserv/set/kill and nickserv/saset/kill to the ns_set_kill module.
-Replaced module:guestnickprefix for the nickserv module with module:guestnick.
-
-Anope Version 2.1.10
---------------------
-Added options:servicealias.
-Moved nickserv/set/message and nickserv/saset/message to the ns_set_message module.
-Removed options:useprivmsg.
-Removed options:usestrictprivmsg
-
-Anope Version 2.1.9
--------------------
-No significant changes.
-
-Anope Version 2.1.8
--------------------
-Added module:preservedisplay to the nickserv module.
-Added the nickserv/drop/display oper privilege.
-
-Anope Version 2.1.7
--------------------
-Moved nickserv/set/language and nickserv/saset/language to the ns_set_language module.
-Renamed module:expire for the cs_suspend module to suspendexpire.
-Renamed the FANTASIA privilege to FANTASY.
-
-Anope Version 2.1.6
--------------------
-Added module:automatic to the ns_cert module (defaults to yes).
-Removed module:use_server_side_mlock for the protocol modules (now always enabled).
-Removed module:use_server_side_topiclock for the protocol modules (now always enabled).
-
-Anope Version 2.1.5
--------------------
-Added the nickserv/drop/override and chanserv/drop/override oper privileges.
-
-Anope Version 2.1.4
--------------------
-Added the db_atheme module.
-Added the enc_argon2 module.
-Added the enc_posix module.
-Added the enc_sha2 module.
-Added the gl_queue module.
-Added the gl_server module.
-Added the global/queue operator privilege.
-Added the global/server operator privilege.
-Changed serverinfo:motd to be relative to the config directory.
-Changed serverinfo:pid to be relative to the data directory.
-Changed the default value of mail:sendmailpath to "/usr/sbin/sendmail -it".
-Changed the default value of module:accessmax for the chanserv module to 1000.
-Changed the default value of module:inhabit for the chanserv module to 1 minute.
-Changed the default value of module:max for the cs_mode module to 50.
-Changed the default value of module:max for the ms_ignore module to 50.
-Removed options:seed.
-Replaced module:template for the webcpanel module with module:template_dir.
-
-
 Anope Version 2.1.3
 -------------------
 Added options:didyoumeandifference.

docs/DEFCON

@@ -90,4 +90,4 @@ Anope DefCon
 6) Support
 
     You might get DefCon support by posting on our online forum, or maybe on
-    our #anope channel at /server irc.teranova.net.
+    our #anope channel at /server irc.anope.org.

docs/INSTALL

@@ -60,7 +60,7 @@ Note: You should also read the README and FAQ files!
     most likely not work!
 
     If you need help, you should visit https://forum.anope.org/ or #anope on
-    irc.teranova.net. Provide *complete* error output, along with other relevant
+    irc.anope.org. Provide *complete* error output, along with other relevant
     information eg. OS, compiler and C++ library versions.
     See the README file for more information.
 
@@ -111,17 +111,17 @@ Note: You should also read the README and FAQ files!
     A crontab entry will allow you to check periodically whether Anope is
     still running, and restart it if not.
 
-    First rename the cron.example.sh script that is in Anope path (by default,
-    this is ~/anope/conf) to cron.sh and edit it. You'll need to
+    First rename the example.chk script that is in Anope path (by default,
+    this is ~/anope/conf) to anope.chk and edit it. You'll need to
     modify the CONFIGURATION part of the file. Then ensure that the file is
-    marked as executable by typing chmod +x cron.sh, and try to launch the
+    marked as executable by typing chmod +x anope.chk, and try to launch the
     script to see if it works (Anope must not be running when you do this ;))
 
     When this is done, you'll have to add the crontab entry. Type crontab -e.
     This will open the default text editor with the crontab file. Enter the
     following (with correct path):
 
-        */5 * * * * /home/ircd/anope/conf/cron.sh >/dev/null 2>&1
+        */5 * * * * /home/ircd/anope/conf/anope.chk >/dev/null 2>&1
 
     The */5 at the beginning means "check every 5 minutes". You may replace
     the 5 with other another number if you want (but less than 60). Consult

docs/INSTALL.fr

@@ -64,7 +64,7 @@ Note : Vous devrez également lire les fichiers README et FAQ !
     recommandée, et Anope ne fonctionnera probablement pas !
 
     Si vous avez besoin d'aide, vous pouvez aller sur le site
-    https://forum.anope.org/ ou le canal #anope sur irc.teranova.net.
+    https://forum.anope.org/ ou le canal #anope sur irc.anope.org.
     Fournissez *l'essemble* des erreurs qui apparaîssent, en plus de
     toutes informations utiles, comme les versions de votre OS, du
     compilateur utilisé et de la librairie C++. Lisez le fichier README
@@ -121,11 +121,11 @@ Note : Vous devrez également lire les fichiers README et FAQ !
     Une entrée crontab vous permettra de vérifier périodiquement si Anope
     est toujours en cours d'exécution et de le redémarrer s'il n'est pas.
 
-    D'abord renommez le script cron.example.sh qui est dans les dossiers
-    d'Anope (par défaut, ~/anope/conf) en cron.sh et modifiez-le.
+    D'abord renommez le script example.chk qui est dans les dossiers
+    d'Anope (par défaut, ~/anope/conf) en anope.chk et modifiez-le.
     Vous aurez besoin de modifier la partie CONFIGURATION du fichier.
     Assurez-vous ensuite que le fichier est marqué comme exécutable en
-    tapant chmod +x cron.sh et essayez de lancer le script pour voir
+    tapant chmod +x anope.chk et essayez de lancer le script pour voir
     si cela fonctionne (Anope ne doit pas être en marche lorsque vous
     testez cela ;))
 
@@ -133,7 +133,7 @@ Note : Vous devrez également lire les fichiers README et FAQ !
     crontab -e. Cela va ouvrir l'éditeur de texte par défaut avec le
     fichier crontab. Entrez la ligne suivante (avec le chemin correct) :
 
-        */5 * * * * /home/ircd/anope/conf/cron.sh > /dev/null 2>&1
+        */5 * * * * /home/ircd/anope/conf/anope.chk > /dev/null 2>&1
 
     Le */5 au début signifie "vérifier toutes les 5 minutes". Vous pouvez
     remplacer le 5 par un autre numéro si vous voulez (mais moins de 60).

docs/LANGUAGE

@@ -19,8 +19,6 @@ Anope Multi Language Support
         Then execute:
         dpkg-reconfigure locales
 
-    If you have already built Anope you will need to delete the build directory and rebuild from scratch.
-
     Building Anope on Windows with gettext support is explained in docs/WIN32.txt
 
 2) Adding a new language
@@ -35,7 +33,7 @@ Anope Multi Language Support
     po files (especially on Windows).
 
     If you have finished a language file translation and you want others to use it, please send it to team@anope.org
-    (don't forget to mention clearly your (nick)name, your email and the language name). You'll of course get full credit for it.
+    (don't forget to mention clearly your (nick)name, your e-mail and the language name). You'll of course get full credit for it.
 
     NOTE: There is no guarantee we will use your work so please do not be offended if we say no thanks.
 

docs/MODULES

@@ -111,7 +111,7 @@ Anope Modules
     Use modules at your own risk, and make sure you get them from a
     reputable source. You might get module support by contacting the module
     author, posting on our online forum, or maybe on our #anope channel
-    at /server irc.teranova.net.
+    at /server irc.anope.org.
 
 7) Information for Developers
 

docs/README

@@ -166,14 +166,14 @@ Table of Contents
 
     Anope currently works with:
 
-        * Bahamut 2.0 or later
-        * InspIRCd 3 or later
+        * Bahamut 1.4.27 or later (including 1.8)
         * ircd-hybrid 8.2.23 or later
-        * ircd-ratbox 3 or later
+        * InspIRCd 3 or later
         * ngIRCd 19.2 or later
         * Plexus 3 or later
+        * Ratbox 2.0.6 or later
         * Solanum (all versions)
-        * UnrealIRCd 6 or later
+        * UnrealIRCd 4 or later
 
     Anope could also work with some of the daemons derived by the ones listed
     above, but there's no support for them if they work or don't work.
@@ -245,7 +245,7 @@ Table of Contents
 
     If you read the documentation carefully, and didn't find the answer to
     your question, feel free to post on the website forums or join our irc
-    channel (irc.teranova.net #anope). Once you join our Support channel be as
+    channel (irc.anope.org #anope). Once you join our Support channel be as
     precise as possible when asking a question, because we have no extraordinary
     powers and can't guess things if they aren't provided.
 

include/account.h

@@ -17,13 +17,13 @@
 #include "memo.h"
 #include "base.h"
 
-typedef Anope::unordered_map<NickAlias *> nickalias_map;
-typedef Anope::unordered_map<NickCore *> nickcore_map;
+typedef Anope::hash_map<NickAlias *> nickalias_map;
+typedef Anope::hash_map<NickCore *> nickcore_map;
 typedef std::unordered_map<uint64_t, NickCore *> nickcoreid_map;
 
 extern CoreExport Serialize::Checker<nickalias_map> NickAliasList;
 extern CoreExport Serialize::Checker<nickcore_map> NickCoreList;
-extern CoreExport Serialize::Checker<nickcoreid_map> NickCoreIdList;
+extern CoreExport nickcoreid_map NickCoreIdList;
 
 /* A registered nickname.
  * It matters that Base is here before Extensible (it is inherited by Serializable)
@@ -33,7 +33,7 @@ class CoreExport NickAlias final
 	, public Extensible
 {
 	Anope::string vhost_ident, vhost_host, vhost_creator;
-	time_t vhost_created = 0;
+	time_t vhost_created;
 
 public:
 	Anope::string nick;
@@ -43,9 +43,8 @@ public:
 	Anope::string last_usermask;
 	/* Last uncloaked usermask, requires nickserv/auspex to see */
 	Anope::string last_realhost;
-	time_t time_registered = Anope::CurTime;
-	time_t last_seen = Anope::CurTime;
-
+	time_t time_registered;
+	time_t last_seen;
 	/* Account this nick is tied to. Multiple nicks can be tied to a single account. */
 	Serialize::Reference<NickCore> nc;
 
@@ -65,41 +64,41 @@ public:
 	 * @param creator Who created the vhost
 	 * @param time When the vhost was created
 	 */
-	void SetVHost(const Anope::string &ident, const Anope::string &host, const Anope::string &creator, time_t created = Anope::CurTime);
+	void SetVhost(const Anope::string &ident, const Anope::string &host, const Anope::string &creator, time_t created = Anope::CurTime);
 
 	/** Remove a users vhost
 	 **/
-	void RemoveVHost();
+	void RemoveVhost();
 
 	/** Check if the user has a vhost
 	 * @return true or false
 	 */
-	bool HasVHost() const;
+	bool HasVhost() const;
 
 	/** Retrieve the vhost ident
 	 * @return the ident
 	 */
-	const Anope::string &GetVHostIdent() const;
+	const Anope::string &GetVhostIdent() const;
 
 	/** Retrieve the vhost host
 	 * @return the host
 	 */
-	const Anope::string &GetVHostHost() const;
+	const Anope::string &GetVhostHost() const;
 
 	/** Retrieve the vhost mask
 	 * @param the mask
 	 */
-	Anope::string GetVHostMask() const;
+	Anope::string GetVhostMask() const;
 
 	/** Retrieve the vhost creator
 	 * @return the creator
 	 */
-	const Anope::string &GetVHostCreator() const;
+	const Anope::string &GetVhostCreator() const;
 
 	/** Retrieve when the vhost was created
 	 * @return the time it was created
 	 */
-	time_t GetVHostCreated() const;
+	time_t GetVhostCreated() const;
 
 	/** Finds a registered nick
 	 * @param nick The nick to lookup
@@ -128,10 +127,6 @@ public:
 	Anope::string email;
 	/* Locale name of the language of the user. Empty means default language */
 	Anope::string language;
-	/* Last time an email was sent to this user */
-	time_t lastmail = 0;
-	/* The time this account was registered */
-	time_t time_registered = Anope::CurTime;
 	MemoInfo memos;
 	std::map<Anope::string, Anope::string> last_modes;
 
@@ -141,14 +136,14 @@ public:
 	Serialize::Checker<std::vector<NickAlias *> > aliases;
 
 	/* Set if this user is a services operator. o->ot must exist. */
-	Oper *o = nullptr;
+	Oper *o;
 
 	/* Unsaved data */
 
-	/** The display nick for this account. */
-	NickAlias *na = nullptr;
 	/* Number of channels registered by this account */
-	uint16_t channelcount = 0;
+	uint16_t channelcount;
+	/* Last time an email was sent to this user */
+	time_t lastmail;
 	/* Users online now logged into this account */
 	std::list<User *> users;
 
@@ -165,7 +160,7 @@ public:
 	/** Changes the display for this account
 	 * @param na The new display, must be grouped to this account.
 	 */
-	void SetDisplay(NickAlias *na);
+	void SetDisplay(const NickAlias *na);
 
 	/** Checks whether this account is a services oper or not.
 	 * @return True if this account is a services oper, false otherwise.

include/anope.h

@@ -39,7 +39,6 @@ namespace Anope
 		typedef std::string::reverse_iterator reverse_iterator;
 		typedef std::string::const_reverse_iterator const_reverse_iterator;
 		typedef std::string::size_type size_type;
-		typedef std::string::value_type value_type;
 		static const size_type npos = static_cast<size_type>(-1);
 
 		/**
@@ -344,7 +343,7 @@ namespace Anope
 	using multimap = std::multimap<string, T, ci::less>;
 
 	template<typename T>
-	using unordered_map = std::unordered_map<string, T, hash_ci, compare>;
+	using hash_map = std::unordered_map<string, T, hash_ci, compare>;
 
 #ifndef REPRODUCIBLE_BUILD
 	static const char *const compiled = __TIME__ " " __DATE__;
@@ -367,7 +366,6 @@ namespace Anope
 	 * Use this unless you need very specific time checks
 	 */
 	extern CoreExport time_t CurTime;
-	extern CoreExport long long CurTimeNs;
 
 	/** The debug level we are running at.
 	 */
@@ -375,7 +373,7 @@ namespace Anope
 
 	/** Other command line options.
 	 */
-	extern CoreExport bool ReadOnly, NoFork, NoThird, NoPID, NoExpire, ProtocolDebug;
+	extern CoreExport bool ReadOnly, NoFork, NoThird, NoExpire, ProtocolDebug;
 
 	/** The root of the Anope installation. Usually ~/anope
 	 */
@@ -471,7 +469,14 @@ namespace Anope
 	 * @param src The source string to encrypt
 	 * @param dest The destination where the encrypted string is placed
 	 */
-	extern CoreExport bool Encrypt(const Anope::string &src, Anope::string &dest);
+	extern CoreExport void Encrypt(const Anope::string &src, Anope::string &dest);
+
+	/** Hashes a buffer with SipHash-2-4
+	 * @param src The start of the buffer to hash
+	 * @param src_sz The total number of bytes in the buffer
+	 * @param key A 16 byte key to hash the buffer with.
+	 */
+	extern CoreExport uint64_t SipHash24(const void *src, unsigned long src_sz, const char key[16]);
 
 	/** Returns a sequence of data formatted as the format argument specifies.
 	 ** After the format parameter, the function expects at least as many
@@ -529,18 +534,10 @@ namespace Anope
 	 */
 	extern CoreExport Anope::string NormalizeBuffer(const Anope::string &);
 
-	/** Parses a raw message from the uplink and calls its command handler.
-	 * @param message Raw message from the uplink
+	/** Main processing routine. Parses the message and takes the appropriate action.
+	 * @param Raw message from the uplink
 	 */
-	extern void Process(const Anope::string &message);
-
-	/** Calls the command handler for an already parsed message.
-	 * @param source Source of the message.
-	 * @param command Command name.
-	 * @param params Any extra parameters.
-	 * @param tags IRCv3 message tags.
-	 */
-	extern CoreExport void ProcessInternal(MessageSource &src, const Anope::string &command, const std::vector<Anope::string> &params, const Anope::map<Anope::string> & tags);
+	extern void Process(const Anope::string &);
 
 	/** Does a blocking dns query and returns the first IP.
 	 * @param host host to look up
@@ -561,53 +558,11 @@ namespace Anope
 	 */
 	extern CoreExport Anope::string Random(size_t len);
 
-	/** Generate a random number. */
-	extern CoreExport int RandomNumber();
-
 	/** Calculates the levenshtein distance between two strings.
 	 * @param s1 The first string.
 	 * @param s2 The second string.
 	 */
 	extern CoreExport size_t Distance(const Anope::string &s1, const Anope::string &s2);
-
-	/** Update the current time. */
-	extern CoreExport void UpdateTime();
-
-	/** Expands a path fragment that is relative to the base directory.
-	 * @param base The base directory that it is relative to.
-	 * @param fragment The fragment to expand.
-	 */
-	extern CoreExport Anope::string Expand(const Anope::string &base, const Anope::string &fragment);
-
-	/** Expands a config path. */
-	inline auto ExpandConfig(const Anope::string &path) { return Expand(ConfigDir, path); }
-
-	/** Expands a data path. */
-	inline auto ExpandData(const Anope::string &path) { return Expand(DataDir, path); }
-
-	/** Expands a locale path. */
-	inline auto ExpandLocale(const Anope::string &path) { return Expand(LocaleDir, path); }
-
-	/** Expands a log path. */
-	inline auto ExpandLog(const Anope::string &path) { return Expand(LogDir, path); }
-
-	/** Expands a module path. */
-	inline auto ExpandModule(const Anope::string &path) { return Expand(ModuleDir, path); }
-
-	/** Formats a CTCP message for sending to a client.
-	 * @param name The name of the CTCP.
-	 * @param body If present then the body of the CTCP.
-	 * @return A formatted CTCP ready to send to a client.
-	 */
-	extern CoreExport Anope::string FormatCTCP(const Anope::string &name, const Anope::string &body = "");
-
-	/** Parses a CTCP message received from a client.
-	 * @param text The raw message to parse.
-	 * @param name The location to store the name of the CTCP.
-	 * @param body The location to store body of the CTCP if one is present.
-	 * @return True if the message was a well formed CTCP; otherwise, false.
-	 */
-	extern CoreExport bool ParseCTCP(const Anope::string &text, Anope::string &name, Anope::string &body);
 }
 
 /** sepstream allows for splitting token separated lists.
@@ -635,9 +590,6 @@ public:
 	 */
 	sepstream(const Anope::string &source, char separator, bool allowempty = false);
 
-	/** Retrieves the underlying string. */
-	const auto &GetString() const { return tokens; }
-
 	/** Fetch the next token from the stream
 	 * @param token The next token from the stream is placed here
 	 * @return True if tokens still remain, false if there are none left
@@ -724,6 +676,9 @@ protected:
 	 */
 	Anope::string source;
 public:
+	/** Default constructor, just uses the error message 'Core threw an exception'.
+	 */
+	CoreException() : err("Core threw an exception"), source("The core") { }
 	/** This constructor can be used to specify an error message before throwing.
 	 */
 	CoreException(const Anope::string &message) : err(message), source("The core") { }
@@ -754,6 +709,10 @@ class CoreExport ModuleException
 	: public CoreException
 {
 public:
+	/** Default constructor, just uses the error message 'Module threw an exception'.
+	 */
+	ModuleException() : CoreException("Module threw an exception", "A Module") { }
+
 	/** This constructor can be used to specify an error message before throwing.
 	 */
 	ModuleException(const Anope::string &message) : CoreException(message, "A Module") { }
@@ -764,6 +723,72 @@ public:
 	virtual ~ModuleException() noexcept = default;
 };
 
+class CoreExport ConvertException final
+	: public CoreException
+{
+public:
+	ConvertException(const Anope::string &reason = "") : CoreException(reason) { }
+
+	virtual ~ConvertException() noexcept = default;
+};
+
+/** Convert something to a string
+ */
+inline Anope::string stringify(const Anope::string &x)
+{
+	return x;
+}
+
+template<typename T> inline Anope::string stringify(const T &x)
+{
+	std::ostringstream stream;
+
+	if (!(stream << x))
+		throw ConvertException("Stringify fail");
+
+	return stream.str();
+}
+
+template<typename T> inline void convert(const Anope::string &s, T &x, Anope::string &leftover, bool failIfLeftoverChars = true)
+{
+	leftover.clear();
+	std::istringstream i(s.str());
+	char c;
+	if (!(i >> x))
+		throw ConvertException("Convert fail");
+	if (failIfLeftoverChars)
+	{
+		if (i.get(c))
+			throw ConvertException("Convert fail");
+	}
+	else
+	{
+		std::string left;
+		getline(i, left);
+		leftover = left;
+	}
+}
+
+template<typename T> inline void convert(const Anope::string &s, T &x, bool failIfLeftoverChars = true)
+{
+	Anope::string Unused;
+	convert(s, x, Unused, failIfLeftoverChars);
+}
+
+template<typename T> inline T convertTo(const Anope::string &s, Anope::string &leftover, bool failIfLeftoverChars = true)
+{
+	T x;
+	convert(s, x, leftover, failIfLeftoverChars);
+	return x;
+}
+
+template<typename T> inline T convertTo(const Anope::string &s, bool failIfLeftoverChars = true)
+{
+	T x;
+	convert(s, x, failIfLeftoverChars);
+	return x;
+}
+
 /** Casts to be used instead of dynamic_cast, this uses dynamic_cast
  * for debug builds and static_cast on release builds
  * to speed up the program because dynamic_cast relies on RTTI.
@@ -783,5 +808,3 @@ template<typename T, typename O> inline T anope_dynamic_static_cast(O ptr)
 	return static_cast<T>(ptr);
 }
 #endif
-
-#include "convert.h"

include/bots.h

@@ -31,8 +31,6 @@ public:
 	time_t lastmsg;
 	/* Map of actual command names -> service name/permission required */
 	CommandInfo::map commands;
-	/* The server-side alias used to message this bot. */
-	Anope::string alias;
 	/* Modes the bot should have as configured in service:modes */
 	Anope::string botmodes;
 	/* Channels the bot should be in as configured in service:channels */
@@ -128,9 +126,6 @@ public:
 	 */
 	CommandInfo *GetCommand(const Anope::string &cname);
 
-	/** Get the command that users can use to send a message to this bot. */
-	Anope::string GetQueryCommand() const;
-
 	/** Find a bot by nick
 	 * @param nick The nick
 	 * @param nick_only True to only look by nick, and not by UID

include/channels.h

@@ -13,7 +13,7 @@
 #include "modes.h"
 #include "serialize.h"
 
-typedef Anope::unordered_map<Channel *> channel_map;
+typedef Anope::hash_map<Channel *> channel_map;
 
 extern CoreExport channel_map ChannelList;
 
@@ -215,7 +215,7 @@ public:
 	 * @param mode the modes
 	 * @param enforce_mlock true to enforce mlock
 	 */
-	void SetModesInternal(MessageSource &source, const Anope::string &modes, const std::vector<Anope::string> &params, time_t ts = 0, bool enforce_mlock = true);
+	void SetModesInternal(MessageSource &source, const Anope::string &mode, time_t ts = 0, bool enforce_mlock = true);
 
 	/** Does the given user match the given list? (CMODE_BAN, CMODE_EXCEPT, etc, a list mode)
 	 * @param u The user

include/commands.h

@@ -81,7 +81,6 @@ public:
 	bool IsFounder(ChannelInfo *ci);
 
 	void Reply(const char *message, ...) ATTR_FORMAT(2, 3);
-	void Reply(int count, const char *singular, const char *plural, ...) ATTR_FORMAT(4, 5);
 	void Reply(const Anope::string &message);
 
 	bool HasCommand(const Anope::string &cmd);

include/config.h

@@ -15,6 +15,7 @@
 #include "regchannel.h"
 #include "users.h"
 #include "opertype.h"
+#include <stack>
 
 namespace Configuration
 {
@@ -46,7 +47,14 @@ namespace Configuration
 
 		template<typename T> T Get(const Anope::string &tag, const Anope::string &def = "") const
 		{
-			return Anope::TryConvert<T>(this->Get<const Anope::string>(tag, def)).value_or(T());
+			const Anope::string &value = this->Get<const Anope::string>(tag, def);
+			if (!value.empty())
+				try
+				{
+					return convertTo<T>(value);
+				}
+				catch (const ConvertException &) { }
+			return T();
 		}
 
 		bool Set(const Anope::string &tag, const Anope::string &value);
@@ -88,17 +96,21 @@ namespace Configuration
 	{
 		/* options:readtimeout */
 		time_t ReadTimeout;
+		/* options:useprivmsg */
+		bool UsePrivmsg;
 		/* If we should default to privmsging clients */
 		bool DefPrivmsg;
 		/* Default language */
 		Anope::string DefLanguage;
 		/* options:timeoutcheck */
 		time_t TimeoutCheck;
-		/* options:servicealias */
-		bool ServiceAlias;
+		/* options:usestrictprivmsg */
+		bool UseStrictPrivmsg;
 		/* networkinfo:nickchars */
 		Anope::string NickChars;
 
+		/* either "/msg " or "/" */
+		Anope::string StrictPrivmsg;
 		/* List of uplink servers to try and connect to */
 		std::vector<Uplink> Uplinks;
 		/* A vector of our logfile options */
@@ -126,7 +138,7 @@ namespace Configuration
 		void LoadConf(File &file);
 		void Post(Conf *old);
 
-		Block *GetModule(const Module *);
+		Block *GetModule(Module *);
 		Block *GetModule(const Anope::string &name);
 
 		BotInfo *GetClient(const Anope::string &name);

include/convert.h

@@ -1,132 +0,0 @@
-/*
- *
- * (C) 2003-2024 Anope Team
- * Contact us at team@anope.org
- *
- * Please read COPYING and README for further details.
- *
- * Based on the original code of Epona by Lara.
- * Based on the original code of Services by Andy Church.
- */
-
-#pragma once
-
-#include <optional>
-
-namespace Anope
-{
-	/** Attempts to convert a string to any type.
-	 * @param in The value to convert.
-	 * @param leftover If non-nullptr then the location to store leftover data.
-	 */
-	template<typename T>
-	inline std::optional<T> TryConvert(const Anope::string &in, Anope::string *leftover = nullptr)
-	{
-		std::istringstream tmp(in.str());
-		T out;
-		if (!(tmp >> out))
-			return std::nullopt;
-
-		if (leftover)
-		{
-			leftover->clear();
-			std::getline(tmp, leftover->str());
-		}
-		else
-		{
-			char extra;
-			if (tmp >> extra)
-				return std::nullopt;
-		}
-		return out;
-	}
-
-	/** Converts a string to any type.
-	 * @param in The value to convert.
-	 * @param def The default to use if the conversion failed.
-	 * @param leftover If non-nullptr then the location to store leftover data.
-	 */
-	template<typename T>
-	inline T Convert(const Anope::string &in, T def, Anope::string *leftover = nullptr)
-	{
-		return TryConvert<T>(in, leftover).value_or(def);
-	}
-
-	/** Attempts to convert any type to a string.
-	 * @param in The value to convert.
-	 */
-	template <class T>
-	inline std::optional<Anope::string> TryString(const T &in)
-	{
-		std::ostringstream tmp;
-		if (!(tmp << in))
-			return std::nullopt;
-		return tmp.str();
-	}
-
-	/** No-op function that returns the string that was passed to it.
-	 * @param in The string to return.
-	 */
-	inline const string &ToString(const string &in)
-	{
-		return in;
-	}
-
-	/** Converts a std::string to a string.
-	 * @param in The value to convert.
-	 */
-	inline string ToString(const std::string &in)
-	{
-		return in;
-	}
-
-	/** Converts a char array to a string.
-	 * @param in The value to convert.
-	 */
-	inline string ToString(const char *in)
-	{
-		return string(in);
-	}
-
-	/** Converts a char to a string.
-	 * @param in The value to convert.
-	 */
-	inline string ToString(char in)
-	{
-		return string(1, static_cast<string::value_type>(in));
-	}
-
-	/** Converts an unsigned char to a string.
-	 * @param in The value to convert.
-	 */
-	inline string ToString(unsigned char in)
-	{
-		return string(1, static_cast<string::value_type>(in));
-	}
-
-	/** Converts a bool to a string.
-	 * @param in The value to convert.
-	 */
-	inline string ToString(bool in)
-	{
-		return (in ? "1" : "0");
-	}
-
-	/** Converts a type that std::to_string is implemented for to a string.
-	 * @param in The value to convert.
-	 */
-	template<typename Stringable>
-	inline std::enable_if_t<std::is_arithmetic_v<Stringable>, string> ToString(const Stringable &in)
-	{
-		return std::to_string(in);
-	}
-
-	/** Converts any type to a string.
-	 * @param in The value to convert.
-	 */
-	template <class T>
-	inline std::enable_if_t<!std::is_arithmetic_v<T>, string> ToString(const T &in)
-	{
-		return TryString(in).value_or(Anope::string());
-	}
-}

include/extensible.h

@@ -173,7 +173,7 @@ public:
 	void ExtensibleSerialize(const Extensible *e, const Serializable *s, Serialize::Data &data) const override
 	{
 		T *t = this->Get(e);
-		data.Store(this->name, *t);
+		data[this->name] << *t;
 	}
 
 	void ExtensibleUnserialize(Extensible *e, Serializable *s, Serialize::Data &data) override
@@ -194,7 +194,7 @@ public:
 
 	void ExtensibleSerialize(const Extensible *e, const Serializable *s, Serialize::Data &data) const override
 	{
-		data.Store(this->name, this->HasExt(e));
+		data[this->name] << true;
 	}
 
 	void ExtensibleUnserialize(Extensible *e, Serializable *s, Serialize::Data &data) override

include/language.h

@@ -55,58 +55,21 @@ namespace Language
 	 */
 	extern CoreExport const char *Translate(const NickCore *nc, const char *string);
 
-	/** Translates a string to the given language.
+	/** Translatesa string to the given language.
 	 * @param lang The language to translate to
 	 * @param string The string to translate
 	 * @return The translated string if found, else the original string.
 	 */
 	extern CoreExport const char *Translate(const char *lang, const char *string);
 
-	/** Translates a plural string to the default language.
-	 * @param count The number of items the string is counting.
-	 * @param singular The string to translate if there is one of \p count
-	 * @param plural The string to translate if there is multiple of \p count
-	 * @return The translated string if found, else the original string.
-	 */
-	extern CoreExport const char *Translate(int count, const char *singular, const char *plural);
-
-	/** Translates a plural string to the language of the given user.
-	 * @param u The user to translate the string for
-	 * @param count The number of items the string is counting.
-	 * @param singular The string to translate if there is one of \p count
-	 * @param plural The string to translate if there is multiple of \p count
-	 * @return The translated string if found, else the original string.
-	 */
-	extern CoreExport const char *Translate(User *u, int count, const char *singular, const char *plural);
-
-	/** Translates a plural string to the language of the given account.
-	 * @param nc The account to translate the string for
-	 * @param count The number of items the string is counting.
-	 * @param singular The string to translate if there is one of \p count
-	 * @param plural The string to translate if there is multiple of \p count
-	 * @return The translated string if count, else the original string
-	 */
-	extern CoreExport const char *Translate(const NickCore *nc, int count, const char *singular, const char *plural);
-
-	/** Translates a plural string to the given language.
-	 * @param lang The language to translate to
-	 * @param count The number of items the string is counting.
-	 * @param singular The string to translate if there is one of \p count
-	 * @param plural The string to translate if there is multiple of \p count
-	 * @return The translated string if found, else the original string.
-	 */
-	extern CoreExport const char *Translate(const char *lang, int count, const char *singular, const char *plural);
-
 } // namespace Language
 
 /* Commonly used language strings */
-#define CONFIRM_DROP			_("Please confirm that you want to drop \002%s\002 with \002%s DROP %s %s\002")
-#define SERVICE_UNAVAILABLE		_("Sorry, %s is temporarily unavailable.")
-#define MORE_INFO			_("\002%s HELP %s\002 for more information.")
+#define MORE_INFO			_("\002%s%s HELP %s\002 for more information.")
 #define BAD_USERHOST_MASK		_("Mask must be in the form \037user\037@\037host\037.")
 #define BAD_EXPIRY_TIME			_("Invalid expiry time.")
 #define USERHOST_MASK_TOO_WIDE		_("%s coverage is too wide; Please use a more specific mask.")
-#define READ_ONLY_MODE			_("Services are temporarily in read-only mode.")
+#define READ_ONLY_MODE			_("Services are in read-only mode!")
 #define PASSWORD_INCORRECT		_("Password incorrect.")
 #define ACCESS_DENIED			_("Access denied.")
 #define MORE_OBSCURE_PASSWORD		_("Please try again with a more obscure password. Passwords should not be\n" \
@@ -123,18 +86,18 @@ namespace Language
 #define CHAN_X_NOT_REGISTERED		_("Channel \002%s\002 isn't registered.")
 #define CHAN_X_NOT_IN_USE		_("Channel \002%s\002 doesn't exist.")
 #define NICK_IDENTIFY_REQUIRED		_("You must be logged into an account to use that command.")
-#define MAIL_X_INVALID			_("\002%s\002 is not a valid email address.")
+#define MAIL_X_INVALID			_("\002%s\002 is not a valid e-mail address.")
 #define UNKNOWN				_("<unknown>")
 #define NO_EXPIRE			_("does not expire")
 #define LIST_INCORRECT_RANGE		_("Incorrect range specified. The correct syntax is \002#\037from\037-\037to\037\002.")
 #define NICK_IS_SECURE			_("This nickname is registered and protected.  If it is your\n" \
-						"nick, type \002%s IDENTIFY \037password\037\002.  Otherwise,\n" \
+						"nick, type \002%s%s IDENTIFY \037password\037\002.  Otherwise,\n" \
 						"please choose a different nick.")
 #define FORCENICKCHANGE_NOW		_("This nickname has been registered; you may not use it.")
 #define NICK_CANNOT_BE_REGISTERED	_("Nickname \002%s\002 may not be registered.")
 #define NICK_ALREADY_REGISTERED		_("Nickname \002%s\002 is already registered!")
 #define NICK_SET_DISPLAY_CHANGED	_("The new display is now \002%s\002.")
-#define NICK_CONFIRM_INVALID		_("Invalid passcode has been entered, please check the email again, and retry.")
+#define NICK_CONFIRM_INVALID		_("Invalid passcode has been entered, please check the e-mail again, and retry.")
 #define CHAN_NOT_ALLOWED_TO_JOIN	_("You are not permitted to be on this channel.")
 #define CHAN_X_INVALID			_("Channel %s is not a valid channel.")
 #define CHAN_REACHED_CHANNEL_LIMIT	_("Sorry, you have already reached your limit of \002%d\002 channels.")
@@ -143,22 +106,23 @@ namespace Language
 #define CHAN_SETTING_CHANGED		_("%s for %s set to %s.")
 #define CHAN_SETTING_UNSET		_("%s for %s unset.")
 #define CHAN_ACCESS_LEVEL_RANGE		_("Access level must be between %d and %d inclusive.")
-#define CHAN_INFO_HEADER		_("Information about channel \002%s\002:")
+#define CHAN_INFO_HEADER		_("Information for channel \002%s\002:")
 #define CHAN_EXCEPTED			_("\002%s\002 matches an except on %s and cannot be banned until the except has been removed.")
 #define MEMO_NEW_X_MEMO_ARRIVED		_("There is a new memo on channel %s.\n" \
-						"Type \002%s READ %s %zu\002 to read it.")
+						"Type \002%s%s READ %s %zu\002 to read it.")
 #define MEMO_NEW_MEMO_ARRIVED		_("You have a new memo from %s.\n" \
-						"Type \002%s READ %zu\002 to read it.")
+						"Type \002%s%s READ %zu\002 to read it.")
 #define MEMO_HAVE_NO_MEMOS		_("You have no memos.")
 #define MEMO_X_HAS_NO_MEMOS		_("%s has no memos.")
+#define MEMO_SEND_DISABLED		_("Sorry, memo sending is temporarily disabled.")
 #define MEMO_HAVE_NO_NEW_MEMOS		_("You have no new memos.")
 #define MEMO_X_HAS_NO_NEW_MEMOS		_("%s has no new memos.")
 #define BOT_DOES_NOT_EXIST		_("Bot \002%s\002 does not exist.")
 #define BOT_NOT_ASSIGNED		_("You must assign a bot to the channel before using this command.")
 #define BOT_NOT_ON_CHANNEL		_("Bot is not on channel \002%s\002.")
-#define HOST_SET_ERROR			_("A vhost must be in the format of a valid hostname.")
-#define HOST_SET_IDENT_ERROR		_("A vident must be in the format of a valid ident.")
-#define HOST_SET_TOOLONG		_("Error! The vhost is too long, please use a hostname shorter than %zu characters.")
-#define HOST_SET_IDENTTOOLONG		_("Error! The vident is too long, please use an ident shorter than %zu characters.")
-#define HOST_NOT_ASSIGNED		_("Please contact an Operator to get a vhost assigned to this nick.")
-#define HOST_NO_VIDENT			_("Your IRCd does not support vidents. If this is incorrect please report this as a possible bug.")
+#define HOST_SET_ERROR			_("A vHost must be in the format of a valid hostname.")
+#define HOST_SET_IDENT_ERROR		_("A vHost ident must be in the format of a valid ident.")
+#define HOST_SET_TOOLONG		_("Error! The vHost is too long, please use a hostname shorter than %zu characters.")
+#define HOST_SET_IDENTTOOLONG		_("Error! The vHost ident is too long, please use an ident shorter than %zu characters.")
+#define HOST_NOT_ASSIGNED		_("Please contact an Operator to get a vHost assigned to this nick.")
+#define HOST_NO_VIDENT			_("Your IRCd does not support vIdent's, if this is incorrect, please report this as a possible bug")

include/mail.h

@@ -26,7 +26,6 @@ namespace Mail
 		: public Thread
 	{
 	private:
-		Anope::string error;
 		Anope::string sendmail_path;
 		Anope::string send_from;
 		Anope::string mail_to;
@@ -36,6 +35,7 @@ namespace Mail
 		Anope::string content_type;
 		bool dont_quote_addresses;
 
+		bool success = false;
 	public:
 		/** Construct this message. Once constructed call Thread::Start to launch the mail sending.
 		 * @param sf Config->SendFrom

include/messages.h

@@ -66,11 +66,10 @@ namespace Message
 		 * @param source The source of the SJOIN
 		 * @param chan The channel the users are joining to
 		 * @param ts The TS for the channel
-		 * @param modes The mode letters sent with the SJOIN, if any
-		 * @param modeparams The mode parameters sent with the SJOIN, if any
+		 * @param modes The modes sent with the SJOIN, if any
 		 * @param users The users and their status, if any
 		 */
-		static void SJoin(MessageSource &source, const Anope::string &chan, time_t ts, const Anope::string &modes, const std::vector<Anope::string> &modeparams, const std::list<SJoinUser> &users);
+		static void SJoin(MessageSource &source, const Anope::string &chan, time_t ts, const Anope::string &modes, const std::list<SJoinUser> &users);
 	};
 
 	struct CoreExport Kick

include/modes.h

@@ -216,11 +216,8 @@ template<typename T>
 class CoreExport ChannelModeVirtual
 	: public T
 {
-private:
-	ChannelMode *basech;
-
-protected:
 	Anope::string base;
+	ChannelMode *basech;
 
 public:
 	ChannelModeVirtual(const Anope::string &mname, const Anope::string &basename);

include/modules.h

@@ -199,8 +199,6 @@ public:
 class CoreExport NotImplementedException final
 	: public CoreException
 {
-public:
-	NotImplementedException() : CoreException("") { }
 };
 
 /** Every module in Anope is actually a class.
@@ -290,7 +288,7 @@ public:
 	 * @param cu The user, channel, and status of the user being kicked
 	 * @param kickmsg The reason for the kick.
 	 */
-	virtual void OnPreUserKicked(const MessageSource &source, ChanUserContainer *cu, const Anope::string &kickmsg) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual void OnPreUserKicked(const MessageSource &source, ChanUserContainer *cu, const Anope::string &kickmsg) { throw NotImplementedException(); }
 
 	/** Called when a user has been kicked from a channel.
 	 * @param source The kicker
@@ -299,13 +297,13 @@ public:
 	 * @param status The status the kicked user had on the channel before they were kicked
 	 * @param kickmsg The reason for the kick.
 	 */
-	virtual void OnUserKicked(const MessageSource &source, User *target, const Anope::string &channel, ChannelStatus &status, const Anope::string &kickmsg) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual void OnUserKicked(const MessageSource &source, User *target, const Anope::string &channel, ChannelStatus &status, const Anope::string &kickmsg) { throw NotImplementedException(); }
 
 	/** Called when the configuration is being (re)loaded.
 	 * @param conf The config that is being built now and will replace the global Config object
 	 * @throws A ConfigException to abort the config (re)loading process.
 	 */
-	virtual void OnReload(Configuration::Conf *conf) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnReload(Configuration::Conf *conf) { throw NotImplementedException(); }
 
 	/** Called before a bot is assigned to a channel.
 	 * @param sender The user assigning the bot
@@ -313,35 +311,35 @@ public:
 	 * @param bi The bot being assigned.
 	 * @return EVENT_CONTINUE to let other modules decide, EVENT_STOP to deny the assign.
 	 */
-	virtual EventReturn OnPreBotAssign(User *sender, ChannelInfo *ci, BotInfo *bi) ATTR_NOT_NULL(2, 3, 4) { throw NotImplementedException(); }
+	virtual EventReturn OnPreBotAssign(User *sender, ChannelInfo *ci, BotInfo *bi) { throw NotImplementedException(); }
 
 	/** Called when a bot is assigned ot a channel
 	 */
-	virtual void OnBotAssign(User *sender, ChannelInfo *ci, BotInfo *bi) ATTR_NOT_NULL(2, 3, 4) { throw NotImplementedException(); }
+	virtual void OnBotAssign(User *sender, ChannelInfo *ci, BotInfo *bi) { throw NotImplementedException(); }
 
 	/** Called before a bot is unassigned from a channel.
 	 * @param sender The user unassigning the bot
 	 * @param ci The channel the bot is being removed from
 	 * @return EVENT_CONTINUE to let other modules decide, EVENT_STOP to deny the unassign.
 	 */
-	virtual EventReturn OnBotUnAssign(User *sender, ChannelInfo *ci) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual EventReturn OnBotUnAssign(User *sender, ChannelInfo *ci) { throw NotImplementedException(); }
 
 	/** Called when a new user connects to the network.
 	 * @param u The connecting user.
 	 * @param exempt set to true/is true if the user should be excepted from bans etc
 	 */
-	virtual void OnUserConnect(User *u, bool &exempt) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnUserConnect(User *u, bool &exempt) { throw NotImplementedException(); }
 
 	/** Called when a new server connects to the network.
 	 * @param s The server that has connected to the network
 	 */
-	virtual void OnNewServer(Server *s) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnNewServer(Server *s) { throw NotImplementedException(); }
 
 	/** Called after a user changed the nick
 	 * @param u The user.
 	 * @param oldnick The old nick of the user
 	 */
-	virtual void OnUserNickChange(User *u, const Anope::string &oldnick) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnUserNickChange(User *u, const Anope::string &oldnick) { throw NotImplementedException(); }
 
 	/** Called when someone uses the generic/help command
 	 * @param source Command source
@@ -362,14 +360,14 @@ public:
 	 * @param params The parameters the user is sending
 	 * @return EVENT_CONTINUE to let other modules decide, EVENT_STOP to halt the command and not process it
 	 */
-	virtual EventReturn OnPreCommand(CommandSource &source, Command *command, std::vector<Anope::string> &params) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual EventReturn OnPreCommand(CommandSource &source, Command *command, std::vector<Anope::string> &params) { throw NotImplementedException(); }
 
 	/** Called after a command has been executed.
 	 * @param source The source of the command
 	 * @param command The command the user executed
 	 * @param params The parameters the user sent
 	 */
-	virtual void OnPostCommand(CommandSource &source, Command *command, const std::vector<Anope::string> &params) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual void OnPostCommand(CommandSource &source, Command *command, const std::vector<Anope::string> &params) { throw NotImplementedException(); }
 
 	/** Called when the databases are saved
 	 */
@@ -391,7 +389,7 @@ public:
 	 * @param params The params
 	 * @return EVENT_STOP to halt processing and not run the command, EVENT_ALLOW to allow the command to be executed
 	 */
-	virtual EventReturn OnBotFantasy(CommandSource &source, Command *c, ChannelInfo *ci, const std::vector<Anope::string> &params) ATTR_NOT_NULL(3, 4) { throw NotImplementedException(); }
+	virtual EventReturn OnBotFantasy(CommandSource &source, Command *c, ChannelInfo *ci, const std::vector<Anope::string> &params) { throw NotImplementedException(); }
 
 	/** Called on fantasy command without access
 	 * @param source The source of the command
@@ -400,31 +398,31 @@ public:
 	 * @param params The params
 	 * @return EVENT_STOP to halt processing and not run the command, EVENT_ALLOW to allow the command to be executed
 	 */
-	virtual EventReturn OnBotNoFantasyAccess(CommandSource &source, Command *c, ChannelInfo *ci, const std::vector<Anope::string> &params) ATTR_NOT_NULL(3, 4) { throw NotImplementedException(); }
+	virtual EventReturn OnBotNoFantasyAccess(CommandSource &source, Command *c, ChannelInfo *ci, const std::vector<Anope::string> &params) { throw NotImplementedException(); }
 
 	/** Called when a bot places a ban
 	 * @param u User being banned
 	 * @param ci Channel the ban is placed on
 	 * @param mask The mask being banned
 	 */
-	virtual void OnBotBan(User *u, ChannelInfo *ci, const Anope::string &mask) ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual void OnBotBan(User *u, ChannelInfo *ci, const Anope::string &mask) { throw NotImplementedException(); }
 
 	/** Called before a badword is added to the badword list
 	 * @param ci The channel
 	 * @param bw The badword
 	 */
-	virtual void OnBadWordAdd(ChannelInfo *ci, const BadWord *bw) ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual void OnBadWordAdd(ChannelInfo *ci, const BadWord *bw) { throw NotImplementedException(); }
 
 	/** Called before a badword is deleted from a channel
 	 * @param ci The channel
 	 * @param bw The badword
 	 */
-	virtual void OnBadWordDel(ChannelInfo *ci, const BadWord *bw) ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual void OnBadWordDel(ChannelInfo *ci, const BadWord *bw) { throw NotImplementedException(); }
 
 	/** Called when a bot is created or destroyed
 	 */
-	virtual void OnCreateBot(BotInfo *bi) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
-	virtual void OnDelBot(BotInfo *bi) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnCreateBot(BotInfo *bi) { throw NotImplementedException(); }
+	virtual void OnDelBot(BotInfo *bi) { throw NotImplementedException(); }
 
 	/** Called before a bot kicks a user
 	 * @param bi The bot sending the kick
@@ -433,13 +431,13 @@ public:
 	 * @param reason The reason
 	 * @return EVENT_CONTINUE to let other modules decide, EVENT_STOP to halt the command and not process it
 	 */
-	virtual EventReturn OnBotKick(BotInfo *bi, Channel *c, User *u, const Anope::string &reason) ATTR_NOT_NULL(2, 3, 4) { throw NotImplementedException(); }
+	virtual EventReturn OnBotKick(BotInfo *bi, Channel *c, User *u, const Anope::string &reason) { throw NotImplementedException(); }
 
 	/** Called before a user parts a channel
 	 * @param u The user
 	 * @param c The channel
 	 */
-	virtual void OnPrePartChannel(User *u, Channel *c)  ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual void OnPrePartChannel(User *u, Channel *c) {}
 
 	/** Called when a user parts a channel
 	 * @param u The user
@@ -447,14 +445,14 @@ public:
 	 * @param channel The channel name
 	 * @param msg The part reason
 	 */
-	virtual void OnPartChannel(User *u, Channel *c, const Anope::string &channel, const Anope::string &msg) ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual void OnPartChannel(User *u, Channel *c, const Anope::string &channel, const Anope::string &msg) { throw NotImplementedException(); }
 
 	/** Called when a user leaves a channel.
 	 * From either parting, being kicked, or quitting/killed!
 	 * @param u The user
 	 * @param c The channel
 	 */
-	virtual void OnLeaveChannel(User *u, Channel *c) ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual void OnLeaveChannel(User *u, Channel *c) { throw NotImplementedException(); }
 
 	/** Called after a user joins a channel
 	 * If this event triggers the user is allowed to be in the channel, and will
@@ -463,7 +461,7 @@ public:
 	 * @param u The user
 	 * @param channel The channel
 	 */
-	virtual void OnJoinChannel(User *u, Channel *c) ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual void OnJoinChannel(User *u, Channel *c) { throw NotImplementedException(); }
 
 	/** Called when a new topic is set
 	 * @param source The user changing the topic, if any
@@ -471,18 +469,18 @@ public:
 	 * @param setter The user who set the new topic, if there is no source
 	 * @param topic The new topic
 	 */
-	virtual void OnTopicUpdated(User *source, Channel *c, const Anope::string &user, const Anope::string &topic) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual void OnTopicUpdated(User *source, Channel *c, const Anope::string &user, const Anope::string &topic) { throw NotImplementedException(); }
 
 	/** Called before a channel expires
 	 * @param ci The channel
 	 * @param expire Set to true to allow the chan to expire
 	 */
-	virtual void OnPreChanExpire(ChannelInfo *ci, bool &expire) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnPreChanExpire(ChannelInfo *ci, bool &expire) { throw NotImplementedException(); }
 
 	/** Called before a channel expires
 	 * @param ci The channel
 	 */
-	virtual void OnChanExpire(ChannelInfo *ci) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnChanExpire(ChannelInfo *ci) { throw NotImplementedException(); }
 
 	/** Called before Anope connects to its uplink
 	 */
@@ -494,7 +492,7 @@ public:
 
 	/** Called when we are almost done synching with the uplink, just before we send the EOB
 	 */
-	virtual void OnPreUplinkSync(Server *serv) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnPreUplinkSync(Server *serv) { throw NotImplementedException(); }
 
 	/** Called when Anope disconnects from its uplink, before it tries to reconnect
 	 */
@@ -512,12 +510,12 @@ public:
 	 * @param na The nick
 	 * @param expire Set to true to allow the nick to expire
 	 */
-	virtual void OnPreNickExpire(NickAlias *na, bool &expire) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnPreNickExpire(NickAlias *na, bool &expire) { throw NotImplementedException(); }
 
 	/** Called when a nick drops
 	 * @param na The nick
 	 */
-	virtual void OnNickExpire(NickAlias *na) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnNickExpire(NickAlias *na) { throw NotImplementedException(); }
 
 	/** Called when defcon level changes
 	 * @param level The level
@@ -528,13 +526,13 @@ public:
 	 * @param ex The exception
 	 * @return EVENT_CONTINUE to let other modules decide, EVENT_STOP to halt the command and not process it
 	 */
-	virtual EventReturn OnExceptionAdd(Exception *ex) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual EventReturn OnExceptionAdd(Exception *ex) { throw NotImplementedException(); }
 
 	/** Called before an exception is deleted
 	 * @param source The source deleting it
 	 * @param ex The exception
 	 */
-	virtual void OnExceptionDel(CommandSource &source, Exception *ex) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual void OnExceptionDel(CommandSource &source, Exception *ex) { throw NotImplementedException(); }
 
 	/** Called before a XLine is added
 	 * @param source The source of the XLine
@@ -542,31 +540,31 @@ public:
 	 * @param xlm The xline manager it was added to
 	 * @return EVENT_CONTINUE to let other modules decide, EVENT_STOP to halt the command and not process it
 	 */
-	virtual EventReturn OnAddXLine(CommandSource &source, const XLine *x, XLineManager *xlm) ATTR_NOT_NULL(3, 4) { throw NotImplementedException(); }
+	virtual EventReturn OnAddXLine(CommandSource &source, const XLine *x, XLineManager *xlm) { throw NotImplementedException(); }
 
 	/** Called before a XLine is deleted
 	 * @param source The source of the XLine
 	 * @param x The XLine
 	 * @param xlm The xline manager it was deleted from
 	 */
-	virtual void OnDelXLine(CommandSource &source, const XLine *x, XLineManager *xlm) ATTR_NOT_NULL(4) { throw NotImplementedException(); }
+	virtual void OnDelXLine(CommandSource &source, const XLine *x, XLineManager *xlm) { throw NotImplementedException(); }
 
 	/** Called when a user is checked for whether they are a services oper
 	 * @param u The user
 	 * @return EVENT_ALLOW to allow, anything else to deny
 	 */
-	virtual EventReturn IsServicesOper(User *u) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual EventReturn IsServicesOper(User *u) { throw NotImplementedException(); }
 
 	/** Called when a server quits
 	 * @param server The server
 	 */
-	virtual void OnServerQuit(Server *server) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnServerQuit(Server *server) { throw NotImplementedException(); }
 
 	/** Called when a user quits, or is killed
 	 * @param u The user
 	 * @param msg The quit message
 	 */
-	virtual void OnUserQuit(User *u, const Anope::string &msg) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnUserQuit(User *u, const Anope::string &msg) { throw NotImplementedException(); }
 
 	/** Called when a user is quit, before and after being internally removed from
 	 * This is different from OnUserQuit, which takes place at the time of the quit.
@@ -574,43 +572,43 @@ public:
 	 * all lists (channels, user list, etc)
 	 * @param u The user
 	 */
-	virtual void OnPreUserLogoff(User *u) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
-	virtual void OnPostUserLogoff(User *u) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnPreUserLogoff(User *u) { throw NotImplementedException(); }
+	virtual void OnPostUserLogoff(User *u) { throw NotImplementedException(); }
 
 	/** Called when a new bot is made
 	 * @param bi The bot
 	 */
-	virtual void OnBotCreate(BotInfo *bi) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnBotCreate(BotInfo *bi) { throw NotImplementedException(); }
 
 	/** Called when a bot is changed
 	 * @param bi The bot
 	 */
-	virtual void OnBotChange(BotInfo *bi) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnBotChange(BotInfo *bi) { throw NotImplementedException(); }
 
 	/** Called when a bot is deleted
 	 * @param bi The bot
 	 */
-	virtual void OnBotDelete(BotInfo *bi) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnBotDelete(BotInfo *bi) { throw NotImplementedException(); }
 
 	/** Called after an access entry is deleted from a channel
 	 * @param ci The channel
 	 * @param source The source of the command
 	 * @param access The access entry that was removed
 	 */
-	virtual void OnAccessDel(ChannelInfo *ci, CommandSource &source, ChanAccess *access) ATTR_NOT_NULL(2, 4) { throw NotImplementedException(); }
+	virtual void OnAccessDel(ChannelInfo *ci, CommandSource &source, ChanAccess *access) { throw NotImplementedException(); }
 
 	/** Called when access is added
 	 * @param ci The channel
 	 * @param source The source of the command
 	 * @param access The access changed
 	 */
-	virtual void OnAccessAdd(ChannelInfo *ci, CommandSource &source, ChanAccess *access) ATTR_NOT_NULL(2, 4) { throw NotImplementedException(); }
+	virtual void OnAccessAdd(ChannelInfo *ci, CommandSource &source, ChanAccess *access) { throw NotImplementedException(); }
 
 	/** Called when the access list is cleared
 	 * @param ci The channel
 	 * @param u The user who cleared the access
 	 */
-	virtual void OnAccessClear(ChannelInfo *ci, CommandSource &source) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnAccessClear(ChannelInfo *ci, CommandSource &source) { throw NotImplementedException(); }
 
 	/** Called when a level for a channel is changed
 	 * @param source The source of the command
@@ -618,63 +616,63 @@ public:
 	 * @param priv The privilege changed
 	 * @param what The new level
 	 */
-	virtual void OnLevelChange(CommandSource &source, ChannelInfo *ci, const Anope::string &priv, int16_t what) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual void OnLevelChange(CommandSource &source, ChannelInfo *ci, const Anope::string &priv, int16_t what) { throw NotImplementedException(); }
 
 	/** Called right before a channel is dropped
 	 * @param source The user dropping the channel
 	 * @param ci The channel
 	 */
-	virtual EventReturn OnChanDrop(CommandSource &source, ChannelInfo *ci) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual EventReturn OnChanDrop(CommandSource &source, ChannelInfo *ci) { throw NotImplementedException(); }
 
 	/** Called when a channel is registered
 	 * @param ci The channel
 	 */
-	virtual void OnChanRegistered(ChannelInfo *ci) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnChanRegistered(ChannelInfo *ci) { throw NotImplementedException(); }
 
 	/** Called when a channel is suspended
 	 * @param ci The channel
 	 */
-	virtual void OnChanSuspend(ChannelInfo *ci) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnChanSuspend(ChannelInfo *ci) { throw NotImplementedException(); }
 
 	/** Called when a channel is unsuspended
 	 * @param ci The channel
 	 */
-	virtual void OnChanUnsuspend(ChannelInfo *ci) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnChanUnsuspend(ChannelInfo *ci) { throw NotImplementedException(); }
 
 	/** Called when a channel is being created, for any reason
 	 * @param ci The channel
 	 */
-	virtual void OnCreateChan(ChannelInfo *ci) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnCreateChan(ChannelInfo *ci) { throw NotImplementedException(); }
 
 	/** Called when a channel is being deleted, for any reason
 	 * @param ci The channel
 	 */
-	virtual void OnDelChan(ChannelInfo *ci) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnDelChan(ChannelInfo *ci) { throw NotImplementedException(); }
 
 	/** Called when a new channel is created
 	 * Note that this channel may not be introduced to the uplink at this point.
 	 * @param c The channel
 	 */
-	virtual void OnChannelCreate(Channel *c) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnChannelCreate(Channel *c) { throw NotImplementedException(); }
 
 	/** Called when a channel is deleted
 	 * @param c The channel
 	 */
-	virtual void OnChannelDelete(Channel *c) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnChannelDelete(Channel *c) { throw NotImplementedException(); }
 
 	/** Called after adding an akick to a channel
 	 * @param source The source of the command
 	 * @param ci The channel
 	 * @param ak The akick
 	 */
-	virtual void OnAkickAdd(CommandSource &source, ChannelInfo *ci, const AutoKick *ak) ATTR_NOT_NULL(3, 4) { throw NotImplementedException(); }
+	virtual void OnAkickAdd(CommandSource &source, ChannelInfo *ci, const AutoKick *ak) { throw NotImplementedException(); }
 
 	/** Called before removing an akick from a channel
 	 * @param source The source of the command
 	 * @param ci The channel
 	 * @param ak The akick
 	 */
-	virtual void OnAkickDel(CommandSource &source, ChannelInfo *ci, const AutoKick *ak) ATTR_NOT_NULL(3, 4) { throw NotImplementedException(); }
+	virtual void OnAkickDel(CommandSource &source, ChannelInfo *ci, const AutoKick *ak) { throw NotImplementedException(); }
 
 	/** Called after a user join a channel when we decide whether to kick them or not
 	 * @param u The user
@@ -684,7 +682,7 @@ public:
 	 * @param reason The reason for the kick
 	 * @return EVENT_STOP to prevent the user from joining by kicking/banning the user
 	 */
-	virtual EventReturn OnCheckKick(User *u, Channel *c, Anope::string &mask, Anope::string &reason) ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual EventReturn OnCheckKick(User *u, Channel *c, Anope::string &mask, Anope::string &reason) { throw NotImplementedException(); }
 
 	/** Called when a user requests info for a channel
 	 * @param source The user requesting info
@@ -692,109 +690,109 @@ public:
 	 * @param info Data to show the user requesting information
 	 * @param show_hidden true if we should show the user everything
 	 */
-	virtual void OnChanInfo(CommandSource &source, ChannelInfo *ci, InfoFormatter &info, bool show_hidden) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual void OnChanInfo(CommandSource &source, ChannelInfo *ci, InfoFormatter &info, bool show_hidden) { throw NotImplementedException(); }
 
 	/** Checks if access has the channel privilege 'priv'.
 	 * @param access THe access struct
 	 * @param priv The privilege being checked for
 	 * @return EVENT_ALLOW for yes, EVENT_STOP to stop all processing
 	 */
-	virtual EventReturn OnCheckPriv(const ChanAccess *access, const Anope::string &priv) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual EventReturn OnCheckPriv(const ChanAccess *access, const Anope::string &priv) { throw NotImplementedException(); }
 
 	/** Check whether an access group has a privilege
 	 * @param group The group
 	 * @param priv The privilege
 	 * @return MOD_ALLOW to allow, MOD_STOP to stop
 	 */
-	virtual EventReturn OnGroupCheckPriv(const AccessGroup *group, const Anope::string &priv) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual EventReturn OnGroupCheckPriv(const AccessGroup *group, const Anope::string &priv) { throw NotImplementedException(); }
 
 	/** Called when a nick is dropped
 	 * @param source The source of the command
 	 * @param na The nick
 	 */
-	virtual void OnNickDrop(CommandSource &source, NickAlias *na) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual void OnNickDrop(CommandSource &source, NickAlias *na) { throw NotImplementedException(); }
 
 	/** Called when a user groups their nick
 	 * @param u The user grouping
 	 * @param target The target they're grouping to
 	 */
-	virtual void OnNickGroup(User *u, NickAlias *target) ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual void OnNickGroup(User *u, NickAlias *target) { throw NotImplementedException(); }
 
 	/** Called when a user identifies to a nick
 	 * @param u The user
 	 */
-	virtual void OnNickIdentify(User *u) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnNickIdentify(User *u) { throw NotImplementedException(); }
 
 	/** Called when a user is logged into an account
 	 * @param u The user
 	 */
-	virtual void OnUserLogin(User *u) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnUserLogin(User *u) { throw NotImplementedException(); }
 
 	/** Called when a nick logs out
 	 * @param u The nick
 	 */
-	virtual void OnNickLogout(User *u) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnNickLogout(User *u) { throw NotImplementedException(); }
 
 	/** Called when a nick is registered
 	 * @param user The user registering the nick, of any
 	 * @param The nick
 	 * @param pass The password of the newly registered nick
 	 */
-	virtual void OnNickRegister(User *user, NickAlias *na, const Anope::string &pass) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual void OnNickRegister(User *user, NickAlias *na, const Anope::string &pass) { throw NotImplementedException(); }
 
 	/** Called when a nick is confirmed. This will never be called if registration confirmation is not enabled.
 	 * @param user The user confirming the nick
-	 * @param nc The account being confirmed
+	 * @param The account being confirmed
 	 */
-	virtual void OnNickConfirm(User *user, NickCore *nc) ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual void OnNickConfirm(User *user, NickCore *) { throw NotImplementedException(); }
 
 	/** Called when a nick is suspended
 	 * @param na The nick alias
 	 */
-	virtual void OnNickSuspend(NickAlias *na) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnNickSuspend(NickAlias *na) { throw NotImplementedException(); }
 
 	/** Called when a nick is unsuspended
 	 * @param na The nick alias
 	 */
-	virtual void OnNickUnsuspended(NickAlias *na) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnNickUnsuspended(NickAlias *na) { throw NotImplementedException(); }
 
 	/** Called on delnick()
 	 * @ param na pointer to the nickalias
 	 */
-	virtual void OnDelNick(NickAlias *na) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnDelNick(NickAlias *na) { throw NotImplementedException(); }
 
 	/** Called when a nickcore is created
 	 * @param nc The nickcore
 	 */
-	virtual void OnNickCoreCreate(NickCore *nc) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnNickCoreCreate(NickCore *nc) { throw NotImplementedException(); }
 
 	/** Called on delcore()
 	 * @param nc pointer to the NickCore
 	 */
-	virtual void OnDelCore(NickCore *nc) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnDelCore(NickCore *nc) { throw NotImplementedException(); }
 
 	/** Called on change_core_display()
 	 * @param nc pointer to the NickCore
 	 * @param newdisplay the new display
 	 */
-	virtual void OnChangeCoreDisplay(NickCore *nc, const Anope::string &newdisplay) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnChangeCoreDisplay(NickCore *nc, const Anope::string &newdisplay) { throw NotImplementedException(); }
 
 	/** called from NickCore::ClearCert()
 	 * @param nc pointer to the NickCore
 	 */
-	virtual void OnNickClearCert(NickCore *nc) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnNickClearCert(NickCore *nc) { throw NotImplementedException(); }
 
 	/** Called when a user adds an entry to their cert list
 	 * @param nc The nick
 	 * @param entry The entry
 	 */
-	virtual void OnNickAddCert(NickCore *nc, const Anope::string &entry) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnNickAddCert(NickCore *nc, const Anope::string &entry) { throw NotImplementedException(); }
 
 	/** Called from NickCore::EraseCert()
 	 * @param nc pointer to the NickCore
 	 * @param entry The fingerprint
 	 */
-	virtual void OnNickEraseCert(NickCore *nc, const Anope::string &entry) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnNickEraseCert(NickCore *nc, const Anope::string &entry) { throw NotImplementedException(); }
 
 	/** Called when a user requests info for a nick
 	 * @param source The user requesting info
@@ -802,55 +800,55 @@ public:
 	 * @param info Data to show the user requesting information
 	 * @param show_hidden true if we should show the user everything
 	 */
-	virtual void OnNickInfo(CommandSource &source, NickAlias *na, InfoFormatter &info, bool show_hidden) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual void OnNickInfo(CommandSource &source, NickAlias *na, InfoFormatter &info, bool show_hidden) { throw NotImplementedException(); }
 
 	/** Called when a user uses botserv/info on a bot or channel.
 	 */
-	virtual void OnBotInfo(CommandSource &source, BotInfo *bi, ChannelInfo *ci, InfoFormatter &info) ATTR_NOT_NULL(4) { throw NotImplementedException(); }
+	virtual void OnBotInfo(CommandSource &source, BotInfo *bi, ChannelInfo *ci, InfoFormatter &info) { throw NotImplementedException(); }
 
 	/** Check whether a username and password is correct
 	 * @param u The user trying to identify, if applicable.
 	 * @param req The login request
 	 */
-	virtual void OnCheckAuthentication(User *u, IdentifyRequest *req) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual void OnCheckAuthentication(User *u, IdentifyRequest *req) { throw NotImplementedException(); }
 
 	/** Called when a user does /ns update
 	 * @param u The user
 	 */
-	virtual void OnNickUpdate(User *u) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnNickUpdate(User *u) { throw NotImplementedException(); }
 
 	/** Called when we get informed about a users SSL fingerprint
 	 *  when we call this, the fingerprint should already be stored in the user struct
 	 * @param u pointer to the user
 	 */
-	virtual void OnFingerprint(User *u) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnFingerprint(User *u) { throw NotImplementedException(); }
 
 	/** Called when a user becomes (un)away
 	 * @param message The message, is .empty() if unaway
 	 */
-	virtual void OnUserAway(User *u, const Anope::string &message) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnUserAway(User *u, const Anope::string &message) { throw NotImplementedException(); }
 
 	/** Called when a user invites one of our users to a channel
 	 * @param source The user doing the inviting
 	 * @param c The channel the user is inviting to
 	 * @param targ The user being invited
 	 */
-	virtual void OnInvite(User *source, Channel *c, User *targ) ATTR_NOT_NULL(2, 3, 4) { throw NotImplementedException(); }
+	virtual void OnInvite(User *source, Channel *c, User *targ) { throw NotImplementedException(); }
 
 	/** Called when a vhost is deleted
 	 * @param na The nickalias of the vhost
 	 */
-	virtual void OnDeleteVHost(NickAlias *na) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnDeleteVhost(NickAlias *na) { throw NotImplementedException(); }
 
 	/** Called when a vhost is set
 	 * @param na The nickalias of the vhost
 	 */
-	virtual void OnSetVHost(NickAlias *na) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnSetVhost(NickAlias *na) { throw NotImplementedException(); }
 
 	/** Called when a users host changes
 	 * @param u The user
 	 */
-	virtual void OnSetDisplayedHost(User *u) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnSetDisplayedHost(User *) { throw NotImplementedException(); }
 
 	/** Called when a memo is sent
 	 * @param source The source of the memo
@@ -858,14 +856,14 @@ public:
 	 * @param mi Memo info for target
 	 * @param m The memo
 	 */
-	virtual void OnMemoSend(const Anope::string &source, const Anope::string &target, MemoInfo *mi, Memo *m) ATTR_NOT_NULL(4, 5) { throw NotImplementedException(); }
+	virtual void OnMemoSend(const Anope::string &source, const Anope::string &target, MemoInfo *mi, Memo *m) { throw NotImplementedException(); }
 
 	/** Called when a memo is deleted
 	 * @param target The target the memo is being deleted from (nick or channel)
 	 * @param mi The memo info
 	 * @param m The memo
 	 */
-	virtual void OnMemoDel(const Anope::string &target, MemoInfo *mi, const Memo *m) ATTR_NOT_NULL(3, 4) { throw NotImplementedException(); }
+	virtual void OnMemoDel(const Anope::string &target, MemoInfo *mi, const Memo *m) { throw NotImplementedException(); }
 
 	/** Called when a mode is set on a channel
 	 * @param c The channel
@@ -874,7 +872,7 @@ public:
 	 * @param param The mode param, if there is one
 	 * @return EVENT_STOP to make mlock/secureops etc checks not happen
 	 */
-	virtual EventReturn OnChannelModeSet(Channel *c, MessageSource &setter, ChannelMode *mode, const Anope::string &param) ATTR_NOT_NULL(2, 4) { throw NotImplementedException(); }
+	virtual EventReturn OnChannelModeSet(Channel *c, MessageSource &setter, ChannelMode *mode, const Anope::string &param) { throw NotImplementedException(); }
 
 	/** Called when a mode is unset on a channel
 	 * @param c The channel
@@ -883,67 +881,67 @@ public:
 	 * @param param The mode param, if there is one
 	 * @return EVENT_STOP to make mlock/secureops etc checks not happen
 	 */
-	virtual EventReturn OnChannelModeUnset(Channel *c, MessageSource &setter, ChannelMode *mode, const Anope::string &param) ATTR_NOT_NULL(2, 4) { throw NotImplementedException(); }
+	virtual EventReturn OnChannelModeUnset(Channel *c, MessageSource &setter, ChannelMode *mode, const Anope::string &param) { throw NotImplementedException(); }
 
 	/** Called when a mode is set on a user
 	 * @param setter who/what is setting the mode
 	 * @param u The user
 	 * @param mname The mode name
 	 */
-	virtual void OnUserModeSet(const MessageSource &setter, User *u, const Anope::string &mname) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual void OnUserModeSet(const MessageSource &setter, User *u, const Anope::string &mname) { throw NotImplementedException(); }
 
 	/** Called when a mode is unset from a user
 	 * @param setter who/what is setting the mode
 	 * @param u The user
 	 * @param mname The mode name
 	 */
-	virtual void OnUserModeUnset(const MessageSource &setter, User *u, const Anope::string &mname) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual void OnUserModeUnset(const MessageSource &setter, User *u, const Anope::string &mname) { throw NotImplementedException(); }
 
 	/** Called when a channel mode is introduced into Anope
 	 * @param cm The mode
 	 */
-	virtual void OnChannelModeAdd(ChannelMode *cm) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnChannelModeAdd(ChannelMode *cm) { throw NotImplementedException(); }
 
 	/** Called when a user mode is introduced into Anope
 	 * @param um The mode
 	 */
-	virtual void OnUserModeAdd(UserMode *um) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnUserModeAdd(UserMode *um) { throw NotImplementedException(); }
 
 	/** Called when a mode is about to be mlocked
 	 * @param ci The channel the mode is being locked on
 	 * @param lock The mode lock
 	 * @return EVENT_CONTINUE to let other modules decide, EVENT_STOP to deny the mlock.
 	 */
-	virtual EventReturn OnMLock(ChannelInfo *ci, ModeLock *lock) ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual EventReturn OnMLock(ChannelInfo *ci, ModeLock *lock) { throw NotImplementedException(); }
 
 	/** Called when a mode is about to be unlocked
 	 * @param ci The channel the mode is being unlocked from
 	 * @param lock The mode lock
 	 * @return EVENT_CONTINUE to let other modules decide, EVENT_STOP to deny the mlock.
 	 */
-	virtual EventReturn OnUnMLock(ChannelInfo *ci, ModeLock *lock) ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual EventReturn OnUnMLock(ChannelInfo *ci, ModeLock *lock) { throw NotImplementedException(); }
 
 	/** Called after a module is loaded
 	 * @param u The user loading the module, can be NULL
 	 * @param m The module
 	 */
-	virtual void OnModuleLoad(User *u, Module *m) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual void OnModuleLoad(User *u, Module *m) { throw NotImplementedException(); }
 
 	/** Called before a module is unloaded
 	 * @param u The user, can be NULL
 	 * @param m The module
 	 */
-	virtual void OnModuleUnload(User *u, Module *m) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual void OnModuleUnload(User *u, Module *m) { throw NotImplementedException(); }
 
 	/** Called when a server is synced
 	 * @param s The server, can be our uplink server
 	 */
-	virtual void OnServerSync(Server *s) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnServerSync(Server *s) { throw NotImplementedException(); }
 
 	/** Called when we sync with our uplink
 	 * @param s Our uplink
 	 */
-	virtual void OnUplinkSync(Server *s) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnUplinkSync(Server *s) { throw NotImplementedException(); }
 
 	/** Called when we receive a PRIVMSG for one of our clients
 	 * @param u The user sending the PRIVMSG
@@ -952,7 +950,7 @@ public:
 	 * @param tags Message tags
 	 * @return EVENT_STOP to halt processing
 	 */
-	virtual EventReturn OnBotPrivmsg(User *u, BotInfo *bi, Anope::string &message, const Anope::map<Anope::string> &tags) ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual EventReturn OnBotPrivmsg(User *u, BotInfo *bi, Anope::string &message, const Anope::map<Anope::string> &tags) { throw NotImplementedException(); }
 
 	/** Called when we receive a NOTICE for one of our clients
 	 * @param u The user sending the NOTICE
@@ -960,7 +958,7 @@ public:
 	 * @param tags Message tags
 	 * @param message The message
 	 */
-	virtual void OnBotNotice(User *u, BotInfo *bi, Anope::string &message, const Anope::map<Anope::string> &tags) ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual void OnBotNotice(User *u, BotInfo *bi, Anope::string &message, const Anope::map<Anope::string> &tags) { throw NotImplementedException(); }
 
 	/** Called when we receive a PRIVMSG for a registered channel we are in
 	 * @param u The source of the message
@@ -968,12 +966,12 @@ public:
 	 * @param msg The message
 	 * @param tags Message tags
 	 */
-	virtual void OnPrivmsg(User *u, Channel *c, Anope::string &msg, const Anope::map<Anope::string> &tags) ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual void OnPrivmsg(User *u, Channel *c, Anope::string &msg, const Anope::map<Anope::string> &tags) { throw NotImplementedException(); }
 
 	/** Called when a message is logged
 	 * @param l The log message
 	 */
-	virtual void OnLog(Log *l) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnLog(Log *l) { throw NotImplementedException(); }
 
 	/** Called when a log message is actually logged to a given log info
 	 * The message has already passed validation checks by the LogInfo
@@ -981,13 +979,13 @@ public:
 	 * @param l The log message
 	 * @param msg The final formatted message, derived from 'l'
 	 */
-	virtual void OnLogMessage(LogInfo *li, const Log *l, const Anope::string &msg) ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual void OnLogMessage(LogInfo *li, const Log *l, const Anope::string &msg) { throw NotImplementedException(); }
 
 	/** Called when a DNS request (question) is received.
 	 * @param req The dns request
 	 * @param reply The reply that will be sent
 	 */
-	virtual void OnDnsRequest(DNS::Query &req, DNS::Query *reply) ATTR_NOT_NULL(3) { throw NotImplementedException(); }
+	virtual void OnDnsRequest(DNS::Query &req, DNS::Query *reply) { throw NotImplementedException(); }
 
 	/** Called when a channels modes are being checked to see if they are allowed,
 	 * mostly to ensure mlock/+r are set.
@@ -1000,7 +998,7 @@ public:
 	 * for a newly created channel to set the correct modes, topic,
 	 * set.
 	 */
-	virtual void OnChannelSync(Channel *c) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnChannelSync(Channel *c) { throw NotImplementedException(); }
 
 	/** Called to set the correct modes on the user on the given channel
 	 * @param user The user
@@ -1009,13 +1007,13 @@ public:
 	 * @param give_modes If giving modes is desired
 	 * @param take_modes If taking modes is desired
 	 */
-	virtual void OnSetCorrectModes(User *user, Channel *chan, AccessGroup &access, bool &give_modes, bool &take_modes) ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual void OnSetCorrectModes(User *user, Channel *chan, AccessGroup &access, bool &give_modes, bool &take_modes) { throw NotImplementedException(); }
 
-	virtual void OnSerializeCheck(Serialize::Type *st) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
-	virtual void OnSerializableConstruct(Serializable *st) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
-	virtual void OnSerializableDestruct(Serializable *st) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
-	virtual void OnSerializableUpdate(Serializable *st) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
-	virtual void OnSerializeTypeCreate(Serialize::Type *st) ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual void OnSerializeCheck(Serialize::Type *) { throw NotImplementedException(); }
+	virtual void OnSerializableConstruct(Serializable *) { throw NotImplementedException(); }
+	virtual void OnSerializableDestruct(Serializable *) { throw NotImplementedException(); }
+	virtual void OnSerializableUpdate(Serializable *) { throw NotImplementedException(); }
+	virtual void OnSerializeTypeCreate(Serialize::Type *) { throw NotImplementedException(); }
 
 	/** Called when a chanserv/set command is used
 	 * @param source The source of the command
@@ -1024,7 +1022,7 @@ public:
 	 * @param setting The setting passed to the command. Probably ON/OFF.
 	 * @return EVENT_ALLOW to bypass access checks, EVENT_STOP to halt immediately.
 	 */
-	virtual EventReturn OnSetChannelOption(CommandSource &source, Command *cmd, ChannelInfo *ci, const Anope::string &setting) ATTR_NOT_NULL(3, 4) { throw NotImplementedException(); }
+	virtual EventReturn OnSetChannelOption(CommandSource &source, Command *cmd, ChannelInfo *ci, const Anope::string &setting) { throw NotImplementedException(); }
 
 	/** Called when a nickserv/set command is used.
 	 * @param source The source of the command
@@ -1033,7 +1031,7 @@ public:
 	 * @param setting The setting passed to the command. Probably ON/OFF.
 	 * @return EVENT_STOP to halt immediately
 	 */
-	virtual EventReturn OnSetNickOption(CommandSource &source, Command *cmd, NickCore *nc, const Anope::string &setting) ATTR_NOT_NULL(3, 4) { throw NotImplementedException(); }
+	virtual EventReturn OnSetNickOption(CommandSource &source, Command *cmd, NickCore *nc, const Anope::string &setting) { throw NotImplementedException(); }
 
 	/** Called whenever a message is received from the uplink
 	 * @param source The source of the message
@@ -1048,9 +1046,9 @@ public:
 	 * @param u The user
 	 * @param cm The mode
 	 */
-	virtual EventReturn OnCanSet(User *u, const ChannelMode *cm) ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual EventReturn OnCanSet(User *u, const ChannelMode *cm) { throw NotImplementedException(); }
 
-	virtual EventReturn OnCheckDelete(Channel *c)  ATTR_NOT_NULL(2) { throw NotImplementedException(); }
+	virtual EventReturn OnCheckDelete(Channel *) { throw NotImplementedException(); }
 
 	/** Called every options:expiretimeout seconds. Should be used to expire nicks,
 	 * channels, etc.
@@ -1063,7 +1061,7 @@ public:
 	 * @param na The nick they are on
 	 * @return EVENT_STOP to force the user off of the nick
 	 */
-	virtual EventReturn OnNickValidate(User *u, NickAlias *na) ATTR_NOT_NULL(2, 3) { throw NotImplementedException(); }
+	virtual EventReturn OnNickValidate(User *u, NickAlias *na) { throw NotImplementedException(); }
 };
 
 enum Implementation
@@ -1083,7 +1081,7 @@ enum Implementation
 	I_OnUserLogin, I_OnNickLogout, I_OnNickRegister, I_OnNickConfirm, I_OnNickSuspend, I_OnNickUnsuspended, I_OnDelNick, I_OnNickCoreCreate,
 	I_OnDelCore, I_OnChangeCoreDisplay, I_OnNickClearCert,
 	I_OnNickAddCert, I_OnNickEraseCert, I_OnNickInfo, I_OnBotInfo, I_OnCheckAuthentication, I_OnNickUpdate,
-	I_OnFingerprint, I_OnUserAway, I_OnInvite, I_OnDeleteVHost, I_OnSetVHost, I_OnSetDisplayedHost, I_OnMemoSend, I_OnMemoDel,
+	I_OnFingerprint, I_OnUserAway, I_OnInvite, I_OnDeleteVhost, I_OnSetVhost, I_OnSetDisplayedHost, I_OnMemoSend, I_OnMemoDel,
 	I_OnChannelModeSet, I_OnChannelModeUnset, I_OnUserModeSet, I_OnUserModeUnset, I_OnChannelModeAdd, I_OnUserModeAdd,
 	I_OnMLock, I_OnUnMLock, I_OnModuleLoad, I_OnModuleUnload, I_OnServerSync, I_OnUplinkSync, I_OnBotPrivmsg, I_OnBotNotice,
 	I_OnPrivmsg, I_OnLog, I_OnLogMessage, I_OnDnsRequest, I_OnCheckModes, I_OnChannelSync, I_OnSetCorrectModes,

include/modules/encryption.h

@@ -13,135 +13,26 @@
 
 namespace Encryption
 {
-	/** Base class for encryption contexts. */
+	typedef std::pair<const unsigned char *, size_t> Hash;
+	typedef std::pair<const uint32_t *, size_t> IV;
+
 	class Context
 	{
 	public:
 		virtual ~Context() = default;
-
-		/** Updates the encryption context with the specified data.
-		 * @param str The data to update the context with.
-		 */
-		inline void Update(const Anope::string &str)
-		{
-			Update(reinterpret_cast<const unsigned char *>(str.c_str()), str.length());
-		}
-
-		/** Updates the encryption context with the specified data.
-		 * @param data The data to update the context with.
-		 * @param len The length of the data.
-		 */
 		virtual void Update(const unsigned char *data, size_t len) = 0;
-
-		/** Finalises the encryption context and returns the digest. */
-		virtual Anope::string Finalize() = 0;
+		virtual void Finalize() = 0;
+		virtual Hash GetFinalizedHash() = 0;
 	};
 
-	/** Provider of encryption contexts. */
 	class Provider
 		: public Service
 	{
 	public:
-		/** The byte size of the block cipher. */
-		const size_t block_size;
-
-		/** The byte size of the resulting digest. */
-		const size_t digest_size;
-
-		/** Creates a provider of encryption contexts.
-		 * @param creator The module that created this provider.
-		 * @param algorithm The name of the encryption algorithm.
-		 * @param bs The byte size of the block cipher.
-		 * @param ds The byte size of the resulting digest.
-		 */
-		Provider(Module *creator, const Anope::string &algorithm, size_t bs, size_t ds)
-			: Service(creator, "Encryption::Provider", algorithm)
-			, block_size(bs)
-			, digest_size(ds)
-		{
-		}
-
+		Provider(Module *creator, const Anope::string &sname) : Service(creator, "Encryption::Provider", sname) { }
 		virtual ~Provider() = default;
 
-		/** Checks whether a plain text value matches a hash created by this provider. */
-		virtual bool Compare(const Anope::string &hash, const Anope::string &plain)
-		{
-			return !hash.empty() && hash.equals_cs(ToPrintable(Encrypt(plain)));
-		}
-
-		/** Called on initialising a encryption provider to check it works properly. */
-		void Check(const Anope::map<Anope::string> &checks)
-		{
-			for (const auto &[hash, plain] : checks)
-			{
-				if (!Compare(hash, plain))
-					throw ModuleException("BUG: unable to generate " + this->name + " hashes safely! Please report this!");
-			}
-			Log(LOG_DEBUG) << "The " << this->name << " encryption provider appears to be working correctly.";
-		}
-
-		/** Creates a new encryption context. */
-		virtual std::unique_ptr<Context> CreateContext() = 0;
-
-		/** Quickly encrypts the specified values and returns the digest. */
-		template<typename... Args>
-		Anope::string Encrypt(Args &&...args)
-		{
-			auto context = CreateContext();
-			context->Update(std::forward<Args>(args)...);
-			return context->Finalize();
-		}
-
-		/** Calculates the  RFC 2104 hash-based message authentication code for the specified data. */
-		inline Anope::string HMAC(const Anope::string &key, const Anope::string &data)
-		{
-			if (!block_size)
-				return {};
-
-			auto keybuf = key.length() > block_size ? Encrypt(key) : key;
-			keybuf.resize(block_size);
-
-			Anope::string hmac1;
-			Anope::string hmac2;
-			for (size_t i = 0; i < block_size; ++i)
-			{
-				hmac1.push_back(static_cast<char>(keybuf[i] ^ 0x5C));
-				hmac2.push_back(static_cast<char>(keybuf[i] ^ 0x36));
-			}
-			hmac2.append(data);
-			hmac1.append(Encrypt(hmac2));
-
-			return Encrypt(hmac1);
-		}
-
-		/** Converts a hash to its printable form. */
-		virtual Anope::string ToPrintable(const Anope::string &hash)
-		{
-			return Anope::Hex(hash);
-		}
-	};
-
-	/** Helper template for creating simple providers of encryption contexts. */
-	template <typename T>
-	class SimpleProvider final
-		: public Provider
-	{
-	public:
-		/** Creates a simple provider of encryption contexts.
-		 * @param creator The module that created this provider.
-		 * @param algorithm The name of the encryption algorithm.
-		 * @param bs The byte size of the block cipher.
-		 * @param ds The byte size of the resulting digest.
-		 */
-		SimpleProvider(Module *creator, const Anope::string &algorithm, size_t bs, size_t ds)
-			: Provider(creator, algorithm, bs, ds)
-		{
-		}
-
-		/** @copydoc Encryption::Provider::CreateContext. */
-		std::unique_ptr<Context> CreateContext() override
-		{
-			return std::make_unique<T>();
-		}
+		virtual Context *CreateContext(IV * = NULL) = 0;
+		virtual IV GetDefaultIV() = 0;
 	};
 }

include/modules/hs_request.h

@@ -1,23 +0,0 @@
-/*
- *
- * (C) 2003-2024 Anope Team
- * Contact us at team@anope.org
- *
- * Please read COPYING and README for further details.
- */
-
-#pragma once
-
-class HostRequest
-{
-protected:
-	HostRequest() = default;
-
-public:
-	Anope::string nick;
-	Anope::string ident;
-	Anope::string host;
-	time_t time = 0;
-
-	virtual ~HostRequest() = default;
-};

include/modules/info.h

@@ -1,49 +0,0 @@
-/*
- *
- * (C) 2003-2024 Anope Team
- * Contact us at team@anope.org
- *
- * Please read COPYING and README for further details.
- */
-
-#pragma once
-
-class OperInfo
-{
-protected:
-	OperInfo() = default;
-
-	OperInfo(const Anope::string &t, const Anope::string &i, const Anope::string &a, time_t c)
-		: target(t)
-		, info(i)
-		, adder(a)
-		, created(c)
-	{
-	}
-
-public:
-	Anope::string target;
-	Anope::string info;
-	Anope::string adder;
-	time_t created = 0;
-
-	virtual ~OperInfo() = default;
-};
-
-class OperInfoList
-	: public Serialize::Checker<std::vector<OperInfo *>>
-{
-public:
-	OperInfoList()
-		: Serialize::Checker<std::vector<OperInfo *>>("OperInfo")
-	{
-	}
-
-	virtual ~OperInfoList()
-	{
-		for (auto *info : *(*this))
-			delete info;
-	}
-
-	virtual OperInfo *Create() = 0;
-};

include/modules/ns_cert.h

@@ -79,5 +79,4 @@ public:
 	CertService(Module *c) : Service(c, "CertService", "certs") { }
 
 	virtual NickCore *FindAccountFromCert(const Anope::string &cert) = 0;
-	virtual void ReplaceCert(const Anope::string &oldcert, const Anope::string &newcert) = 0;
 };

include/modules/os_oper.h

@@ -1,46 +0,0 @@
-/*
- *
- * (C) 2011-2024 Anope Team
- * Contact us at team@anope.org
- *
- * Please read COPYING and README for further details.
- */
-
-#pragma once
-
-struct MyOper final
-	: Oper
-	, Serializable
-{
-	MyOper(const Anope::string &n, OperType *o) : Oper(n, o), Serializable("Oper") { }
-
-	void Serialize(Serialize::Data &data) const override
-	{
-		data.Store("name", this->name);
-		data.Store("type", this->ot->GetName());
-	}
-
-	static Serializable *Unserialize(Serializable *obj, Serialize::Data &data)
-	{
-		Anope::string stype, sname;
-
-		data["type"] >> stype;
-		data["name"] >> sname;
-
-		OperType *ot = OperType::Find(stype);
-		if (ot == NULL)
-			return NULL;
-		NickCore *nc = NickCore::Find(sname);
-		if (nc == NULL)
-			return NULL;
-
-		MyOper *myo;
-		if (obj)
-			myo = anope_dynamic_static_cast<MyOper *>(obj);
-		else
-			myo = new MyOper(nc->display, ot);
-		nc->o = myo;
-		Log(LOG_NORMAL, "operserv/oper") << "Tied oper " << nc->display << " to type " << ot->GetName();
-		return myo;
-	}
-};

include/modules/os_session.h

@@ -62,12 +62,12 @@ static ServiceReference<SessionService> session_service("SessionService", "sessi
 
 void Exception::Serialize(Serialize::Data &data) const
 {
-	data.Store("mask", this->mask);
-	data.Store("limit", this->limit);
-	data.Store("who", this->who);
-	data.Store("reason", this->reason);
-	data.Store("time", this->time);
-	data.Store("expires", this->expires);
+	data["mask"] << this->mask;
+	data["limit"] << this->limit;
+	data["who"] << this->who;
+	data["reason"] << this->reason;
+	data["time"] << this->time;
+	data["expires"] << this->expires;
 }
 
 Serializable *Exception::Unserialize(Serializable *obj, Serialize::Data &data)

include/modules/pseudoclients/global.h

@@ -8,68 +8,21 @@
 
 #pragma once
 
-#define GLOBAL_NO_MESSAGE     _("You do not have any messages queued and did not specify a message to send.")
-#define GLOBAL_QUEUE_CONFLICT _("You can not send a single message while you have messages queued.")
-
 class GlobalService
 	: public Service
 {
 public:
-	GlobalService(Module *m)
-		: Service(m, "GlobalService", "Global")
+	GlobalService(Module *m) : Service(m, "GlobalService", "Global")
 	{
 	}
 
 	/** Retrieves the bot which sends global messages unless otherwise specified. */
-	virtual Reference<BotInfo> GetDefaultSender() const = 0;
+	virtual Reference<BotInfo> GetDefaultSender() = 0;
 
-	/** Clears any queued messages for the specified account.
-	 * @param nc The account to clear queued messages for.
+	/** Send out a global message to all users
+	 * @param sender Our client which should send the global
+	 * @param source The sender of the global
+	 * @param message The message
 	 */
-	virtual void ClearQueue(NickCore *nc) = 0;
-
-	/** Retrieves the size of the messages queue for the specified user.
-	 * @param nc The account to count queued messages for.
-	 */
-	inline size_t CountQueue(NickCore* nc) const
-	{
-		auto *q = GetQueue(nc);
-		return q ? q->size() : 0;
-	}
-
-	/** Retrieves the messages queue for the specified user.
-	 * @param nc The account to retrieve queued messages for.
-	 */
-	virtual const std::vector<Anope::string> *GetQueue(NickCore* nc) const = 0;
-
-	/** Queues a message to be sent later.
-	 * @param nc The account to queue the message for.
-	 * @param message The message to queue.
-	 * @return The new number of messages in the queue.
-	 */
-	virtual size_t Queue(NickCore *nc, const Anope::string &message) = 0;
-
-	/** Sends a single message to all users on the network.
-	 * @param message The message to send.
-	 * @param source If non-nullptr then the source of the message.
-	 * @param sender If non-nullptr then the bot to send the message from.
-	 * @param server If non-nullptr then the server to send messages to.
-	 * @return If the message was sent then true; otherwise, false.
-	 */
-	virtual bool SendSingle(const Anope::string &message, CommandSource *source = nullptr, BotInfo *sender = nullptr, Server *server = nullptr) = 0;
-
-	/** Sends a message queue to all users on the network.
-	 * @param source The source of the message.
-	 * @param sender If non-nullptr then the bot to send the message from.
-	 * @param server If non-nullptr then the server to send messages to.
-	 * @return If the message queue was sent then true; otherwise, false.
-	 */
-	virtual bool SendQueue(CommandSource &source, BotInfo *sender = nullptr, Server *server = nullptr) = 0;
-
-	/** Unqueues a message from the message queue.
-	 * @param nc The account to unqueue the message from.
-	 * @param idx The index of the item to remove.
-	 * @return Whether the message was removed from the queue.
-	 */
-	virtual bool Unqueue(NickCore *nc, size_t idx) = 0;
+	virtual void SendGlobal(BotInfo *sender, const Anope::string &source, const Anope::string &message) = 0;
 };

include/modules/pseudoclients/nickserv.h

@@ -19,5 +19,4 @@ public:
 	virtual void Validate(User *u) = 0;
 	virtual void Collide(User *u, NickAlias *na) = 0;
 	virtual void Release(NickAlias *na) = 0;
-	virtual bool IsGuestNick(const Anope::string &nick) const = 0;
 };

include/modules/sql.h

@@ -8,8 +8,6 @@
 
 #pragma once
 
-#include <stdexcept>
-
 namespace SQL
 {
 
@@ -19,7 +17,7 @@ namespace SQL
 	public:
 		typedef std::map<Anope::string, std::stringstream *> Map;
 		Map data;
-		std::map<Anope::string, Serialize::DataType> types;
+		std::map<Anope::string, Type> types;
 
 		~Data()
 		{
@@ -34,6 +32,14 @@ namespace SQL
 			return *ss;
 		}
 
+		std::set<Anope::string> KeySet() const override
+		{
+			std::set<Anope::string> keys;
+			for (const auto &[key, _] : this->data)
+				keys.insert(key);
+			return keys;
+		}
+
 		size_t Hash() const override
 		{
 			size_t hash = 0;
@@ -60,17 +66,17 @@ namespace SQL
 			this->data.clear();
 		}
 
-		void SetType(const Anope::string &key, Serialize::DataType dt) override
+		void SetType(const Anope::string &key, Type t) override
 		{
-			this->types[key] = dt;
+			this->types[key] = t;
 		}
 
-		Serialize::DataType GetType(const Anope::string &key) const override
+		Type GetType(const Anope::string &key) const override
 		{
-			auto it = this->types.find(key);
+			std::map<Anope::string, Type>::const_iterator it = this->types.find(key);
 			if (it != this->types.end())
 				return it->second;
-			return Serialize::DataType::TEXT;
+			return DT_TEXT;
 		}
 	};
 
@@ -120,12 +126,13 @@ namespace SQL
 
 		template<typename T> void SetValue(const Anope::string &key, const T &value, bool escape = true)
 		{
-			auto str = Anope::TryString(value);
-			if (!str.has_value())
-				return;
-
-			this->parameters[key].data = str.value();
-			this->parameters[key].escape = escape;
+			try
+			{
+				Anope::string string_value = stringify(value);
+				this->parameters[key].data = string_value;
+				this->parameters[key].escape = escape;
+			}
+			catch (const ConvertException &ex) { }
 		}
 	};
 

include/protocol.h

@@ -16,17 +16,6 @@
 #include "service.h"
 #include "modes.h"
 
-/** Thrown when a protocol error happens. */
-class CoreExport ProtocolException final
-	: public ModuleException
-{
-public:
-	ProtocolException(const Anope::string &message)
-		: ModuleException(message)
-	{
-	}
-};
-
 /* Encapsulates the IRCd protocol we are speaking. */
 class CoreExport IRCDProto
 	: public Service
@@ -41,9 +30,9 @@ public:
 
 	virtual ~IRCDProto();
 
-	virtual void SendNotice(const MessageSource &source, const Anope::string &dest, const Anope::string &msg, const Anope::map<Anope::string> &tags = {});
-	virtual void SendPrivmsg(const MessageSource &source, const Anope::string &dest, const Anope::string &msg, const Anope::map<Anope::string> &tags = {});
-	virtual void SendTagmsg(const MessageSource &source, const Anope::string &dest, const Anope::map<Anope::string> &tags);
+	virtual void SendNoticeInternal(const MessageSource &, const Anope::string &dest, const Anope::string &msg, const Anope::map<Anope::string> &tags = {});
+	virtual void SendPrivmsgInternal(const MessageSource &, const Anope::string &dest, const Anope::string &msg, const Anope::map<Anope::string> &tags = {});
+	virtual void SendCTCPInternal(const MessageSource &, const Anope::string &dest, const Anope::string &buf);
 
 	/** Parses an incoming message from the IRC server.
 	 * @param message The message to parse.
@@ -74,9 +63,6 @@ public:
 	/* Can we force join or part users? */
 	bool CanSVSJoin = false;
 
-	/** Can we force servers to remove opers? */
-	bool CanSVSNOOP = false;
-
 	/* Can we set vhosts on users? */
 	bool CanSetVHost = false;
 
@@ -101,6 +87,9 @@ public:
 	/* See ns_cert */
 	bool CanCertFP = false;
 
+	/* Can users log out before being fully connected? */
+	bool CanSVSLogout = false;
+
 	/* Whether this IRCd requires unique IDs for each user or server. See TS6/P10. */
 	bool RequiresID = false;
 
@@ -110,40 +99,16 @@ public:
 	/** Can we ask the server to unban a user? */
 	bool CanClearBans = false;
 
-	/** Can we send tag messages? */
-	bool CanTagMessage = false;
-
-	/* The maximum length of a channel name. */
-	size_t MaxChannel = 0;
-
-	/* The maximum length of a hostname. */
-	size_t MaxHost = 0;
+	/* The maximum number of modes we are allowed to set with one MODE command */
+	unsigned MaxModes = 3;
 
 	/* The maximum number of bytes a line may have */
-	size_t MaxLine = 512;
-
-	/* The maximum number of modes we are allowed to set with one MODE command */
-	size_t MaxModes = 3;
-
-	/* The maximum length of a nickname. */
-	size_t MaxNick = 0;
-
-	/* The maximum length of a username. */
-	size_t MaxUser = 0;
-
+	unsigned MaxLine = 512;
 
 	/* Retrieves the next free UID or SID */
 	virtual Anope::string UID_Retrieve();
 	virtual Anope::string SID_Retrieve();
 
-	/** Extracts a timestamp from a string. */
-	virtual time_t ExtractTimestamp(const Anope::string &str);
-
-	/** Sends an error to the uplink before disconnecting.
-	 * @param reason The error message.
-	 */
-	virtual void SendError(const Anope::string &reason);
-
 	/** Sets the server in NOOP mode. If NOOP mode is enabled, no users
 	 * will be able to oper on the server.
 	 * @param s The server
@@ -162,8 +127,8 @@ public:
 	 * @param vident The ident to set
 	 * @param vhost The vhost to set
 	 */
-	virtual void SendVHost(User *u, const Anope::string &vident, const Anope::string &vhost) { }
-	virtual void SendVHostDel(User *) { }
+	virtual void SendVhost(User *u, const Anope::string &vident, const Anope::string &vhost) { }
+	virtual void SendVhostDel(User *) { }
 
 	/** Sets an akill. This is a recursive function that can be called multiple times
 	 * for the same xline, but for different users, if the xline is not one that can be
@@ -199,14 +164,14 @@ public:
 	template <typename... Args>
 	void SendMode(const MessageSource &source, Channel *chan, const Anope::string &modes, Args &&...args)
 	{
-		SendModeInternal(source, chan, modes, { Anope::ToString(args)... });
+		SendModeInternal(source, chan, modes, { stringify(args)... });
 	}
 
 	virtual void SendModeInternal(const MessageSource &source, User *u, const Anope::string &modes, const std::vector<Anope::string> &values);
 	template <typename... Args>
 	void SendMode(const MessageSource &source, User *u, const Anope::string &modes, Args &&...args)
 	{
-		SendModeInternal(source, u, modes, { Anope::ToString(args)... });
+		SendModeInternal(source, u, modes, { stringify(args)... });
 	}
 
 	/** Introduces a client to the rest of the network
@@ -216,6 +181,11 @@ public:
 
 	virtual void SendKick(const MessageSource &source, const Channel *chan, User *user, const Anope::string &msg);
 
+	virtual void SendNotice(const MessageSource &source, const Anope::string &dest, const char *fmt, ...) ATTR_FORMAT(4, 5);
+	virtual void SendPrivmsg(const MessageSource &source, const Anope::string &dest, const char *fmt, ...) ATTR_FORMAT(4, 5);
+	virtual void SendAction(const MessageSource &source, const Anope::string &dest, const char *fmt, ...) ATTR_FORMAT(4, 5);
+	virtual void SendCTCP(const MessageSource &source, const Anope::string &dest, const char *fmt, ...) ATTR_FORMAT(4, 5);
+
 	virtual void SendGlobalNotice(BotInfo *bi, const Server *dest, const Anope::string &msg) = 0;
 	virtual void SendGlobalPrivmsg(BotInfo *bi, const Server *desc, const Anope::string &msg) = 0;
 
@@ -240,9 +210,9 @@ public:
 	 * @param bi The source of the message
 	 * @param u The user to join
 	 * @param chan The channel to join the user to
-	 * @param key Channel key
+	 * @param param Channel key?
 	 */
-	virtual void SendSVSJoin(const MessageSource &source, User *u, const Anope::string &chan, const Anope::string &key) { }
+	virtual void SendSVSJoin(const MessageSource &source, User *u, const Anope::string &chan, const Anope::string &param) { }
 
 	/** Force parts a user that isn't ours from a channel.
 	 * @param source The source of the message
@@ -288,7 +258,7 @@ public:
 	template <typename... Args>
 	void SendNumeric(int numeric, const Anope::string &dest, Args &&...args)
 	{
-		SendNumericInternal(numeric, dest, { Anope::ToString(args)... });
+		SendNumericInternal(numeric, dest, { stringify(args)... });
 	}
 
 	virtual void SendLogin(User *u, NickAlias *na) = 0;
@@ -297,7 +267,7 @@ public:
 	/** Send a channel creation message to the uplink.
 	 * On most TS6 IRCds this is a SJOIN with no nick
 	 */
-	virtual void SendChannel(Channel *c) = 0;
+	virtual void SendChannel(Channel *c) { }
 
 	/** Make the user an IRC operator
 	 * Normally this is a simple +o, though some IRCds require us to send the oper type
@@ -324,6 +294,17 @@ public:
 
 	virtual Anope::string NormalizeMask(const Anope::string &mask);
 
+	/** Retrieves the maximum length of a channel name. */
+	virtual size_t GetMaxChannel();
+
+	/** Retrieves the maximum length of a hostname. */
+	virtual size_t GetMaxHost();
+
+	/** Retrieves the maximum length of a nickname. */
+	virtual size_t GetMaxNick();
+
+	/** Retrieves the maximum length of a username. */
+	virtual size_t GetMaxUser();
 };
 
 class CoreExport MessageSource final

include/regchannel.h

@@ -16,7 +16,7 @@
 #include "serialize.h"
 #include "bots.h"
 
-typedef Anope::unordered_map<ChannelInfo *> registered_channel_map;
+typedef Anope::hash_map<ChannelInfo *> registered_channel_map;
 
 extern CoreExport Serialize::Checker<registered_channel_map> RegisteredChannelList;
 

include/serialize.h

@@ -18,44 +18,23 @@
 
 namespace Serialize
 {
-	enum class DataType
-		: uint8_t
-	{
-		BOOL,
-		FLOAT,
-		INT,
-		TEXT,
-		UINT,
-	};
-
 	class Data
 	{
 	public:
+		enum Type
+		{
+			DT_TEXT,
+			DT_INT
+		};
+
 		virtual ~Data() = default;
 
 		virtual std::iostream &operator[](const Anope::string &key) = 0;
-
-		template <typename T>
-		void Store(const Anope::string &key, const T &value)
-		{
-			using Type = std::remove_cv_t<std::remove_reference_t<T>>;
-
-			if constexpr (std::is_same_v<Type, bool>)
-				SetType(key, DataType::BOOL);
-			else if constexpr (std::is_floating_point_v<Type>)
-				SetType(key, DataType::FLOAT);
-			else if constexpr (std::is_integral_v<Type> && std::is_signed_v<Type>)
-				SetType(key, DataType::INT);
-			else if constexpr (std::is_integral_v<Type> && std::is_unsigned_v<Type>)
-				SetType(key, DataType::UINT);
-
-			this->operator[](key) << value;
-		}
-
+		virtual std::set<Anope::string> KeySet() const { throw CoreException("Not supported"); }
 		virtual size_t Hash() const { throw CoreException("Not supported"); }
 
-		virtual void SetType(const Anope::string &key, DataType dt) { }
-		virtual DataType GetType(const Anope::string &key) const { return DataType::TEXT; }
+		virtual void SetType(const Anope::string &key, Type t) { }
+		virtual Type GetType(const Anope::string &key) const { return DT_TEXT; }
 	};
 
 	extern void RegisterTypes();

include/service.h

@@ -98,8 +98,10 @@ public:
 
 	void Register()
 	{
-		if (!Services[this->type].emplace(this->name, this).second)
+		std::map<Anope::string, Service *> &smap = Services[this->type];
+		if (smap.find(this->name) != smap.end())
 			throw ModuleException("Service " + this->type + " with name " + this->name + " already exists");
+		smap[this->name] = this;
 	}
 
 	void Unregister()

include/services.h

@@ -11,36 +11,40 @@
 
 #pragma once
 
-#include <cstdarg>
-#include <cstddef>
-#include <cstdint>
-#include <cstdio>
-#include <cstdlib>
-#include <cstring>
-
-#include <algorithm>
-#include <bitset>
-#include <deque>
-#include <exception>
-#include <fstream>
-#include <iostream>
-#include <list>
-#include <map>
-#include <set>
-#include <sstream>
-#include <vector>
-
-#ifndef _WIN32
-# include <unistd.h>
-#endif
-
-#include "defs.h"
 #include "sysconf.h"
 
 #define BUFSIZE 1024
 
+#include <cstdio>
+#include <cstdlib>
+#include <cstdarg>
+#include <stdexcept>
+
+#include <cstring>
+
+#ifndef _WIN32
+#include <unistd.h>
+#endif
+
+/* Pull in the various bits of STL */
+#include <cstdint>
+#include <cstddef>
+#include <iostream>
+#include <fstream>
+#include <sstream>
+#include <map>
+#include <exception>
+#include <list>
+#include <vector>
+#include <deque>
+#include <bitset>
+#include <set>
+#include <algorithm>
+#include <iterator>
+
+#include "defs.h"
+
 #define _(x) x
-#define N_(x, y) x, y
 
 #ifndef _WIN32
 # define DllExport __attribute__ ((visibility ("default")))

include/sockets.h

@@ -164,15 +164,15 @@ public:
 	 * @param sz How much to read
 	 * @return Number of bytes received
 	 */
-	virtual ssize_t Recv(Socket *s, char *buf, size_t sz);
+	virtual int Recv(Socket *s, char *buf, size_t sz);
 
 	/** Write something to the socket
 	 * @param s The socket
 	 * @param buf The data to write
 	 * @param size The length of the data
 	 */
-	virtual ssize_t Send(Socket *s, const char *buf, size_t sz);
-	ssize_t Send(Socket *s, const Anope::string &buf);
+	virtual int Send(Socket *s, const char *buf, size_t sz);
+	int Send(Socket *s, const Anope::string &buf);
 
 	/** Accept a connection from a socket
 	 * @param s The socket
@@ -503,7 +503,7 @@ public:
 	 * @param sz The size of the buffer
 	 * @return The amount of data read
 	 */
-	ssize_t Read(char *data, size_t sz);
+	int Read(char *data, size_t sz);
 
 	/** Mark the write end of this pipe (non)blocking
 	 * @param state true to enable blocking, false to disable blocking

include/sysconf.h.cmake

@@ -20,24 +20,6 @@
 // Whether Anope was built in debug mode.
 #cmakedefine01 DEBUG_BUILD
 
-// The default config directory.
-#define DEFAULT_CONF_DIR "@CONF_DIR@"
-
-// The default data directory.
-#define DEFAULT_DATA_DIR "@DATA_DIR@"
-
-// The default locale directory.
-#define DEFAULT_LOCALE_DIR "@LOCALE_DIR@"
-
-// The default log directory.
-#define DEFAULT_LOG_DIR "@LOG_DIR@"
-
-// The default module directory.
-#define DEFAULT_MODULE_DIR "@MODULE_DIR@"
-
-// Whether the clock_gettime() function is available.
-#cmakedefine01 HAVE_CLOCK_GETTIME
-
 // Whether Anope was built with localization support.
 #cmakedefine01 HAVE_LOCALIZATION
 
@@ -51,8 +33,6 @@
 
 #if defined __GNUC__
 # define ATTR_FORMAT(STRINGPOS, FIRSTPOS) __attribute__((format(printf, STRINGPOS, FIRSTPOS)))
-# define ATTR_NOT_NULL(...) __attribute__((nonnull(__VA_ARGS__)))
 #else
 # define ATTR_FORMAT(STRINGPOS, FIRSTPOS)
-# define ATTR_NOT_NULL(...)
 #endif

include/timers.h

@@ -18,7 +18,7 @@ class CoreExport Timer
 private:
 	/** The owner of the timer, if any
 	 */
-	Module *owner = nullptr;
+	Module *owner;
 
 	/** The triggering time
 	 */

include/uplink.h

@@ -23,25 +23,25 @@ namespace Uplink
 	template<typename... Args>
 	void Send(const Anope::map<Anope::string> &tags, const MessageSource &source, const Anope::string &command, Args &&...args)
 	{
-		SendInternal(tags, source, command, { Anope::ToString(args)... });
+		SendInternal(tags, source, command, { stringify(args)... });
 	}
 
 	template<typename... Args>
 	void Send(const Anope::map<Anope::string> &tags, const Anope::string &command, Args &&...args)
 	{
-		SendInternal(tags, Me, command, { Anope::ToString(args)... });
+		SendInternal(tags, Me, command, { stringify(args)... });
 	}
 
 	template<typename... Args>
 	void Send(const MessageSource &source, const Anope::string &command, Args &&...args)
 	{
-		SendInternal({}, source, command, { Anope::ToString(args)... });
+		SendInternal({}, source, command, { stringify(args)... });
 	}
 
 	template<typename... Args>
 	void Send(const Anope::string &command, Args &&...args)
 	{
-		SendInternal({}, Me, command, { Anope::ToString(args)... });
+		SendInternal({}, Me, command, { stringify(args)... });
 	}
 }
 

include/users.h

@@ -19,7 +19,7 @@
 #include "account.h"
 #include "sockets.h"
 
-typedef Anope::unordered_map<User *> user_map;
+typedef Anope::hash_map<User *> user_map;
 
 extern CoreExport user_map UserListByNick, UserListByUID;
 
@@ -107,14 +107,14 @@ protected:
 	 * @param suid The unique identifier of the user.
 	 * @param nc The account the user is identified as, if any
 	 */
-	User(const Anope::string &snick, const Anope::string &sident, const Anope::string &shost, const Anope::string &svhost, const Anope::string &sip, Server *sserver, const Anope::string &srealname, time_t ts, const Anope::string &smodes, const std::vector<Anope::string> &smodeparams, const Anope::string &suid, NickCore *nc);
+	User(const Anope::string &snick, const Anope::string &sident, const Anope::string &shost, const Anope::string &svhost, const Anope::string &sip, Server *sserver, const Anope::string &srealname, time_t ts, const Anope::string &smodes, const Anope::string &suid, NickCore *nc);
 
 	/** Destroy a user.
 	 */
 	virtual ~User();
 
 public:
-	static User *OnIntroduce(const Anope::string &snick, const Anope::string &sident, const Anope::string &shost, const Anope::string &svhost, const Anope::string &sip, Server *sserver, const Anope::string &srealname, time_t ts, const Anope::string &smodes, const Anope::string &suid, NickCore *nc, const std::vector<Anope::string> &smodeparams = {});
+	static User *OnIntroduce(const Anope::string &snick, const Anope::string &sident, const Anope::string &shost, const Anope::string &svhost, const Anope::string &sip, Server *sserver, const Anope::string &srealname, time_t ts, const Anope::string &smodes, const Anope::string &suid, NickCore *nc);
 
 	/** Update the nickname of a user record accordingly, should be
 	 * called from ircd protocol.
@@ -190,7 +190,6 @@ public:
 	 * @param ... any number of parameters
 	 */
 	void SendMessage(BotInfo *source, const char *fmt, ...) ATTR_FORMAT(3, 4);
-	void SendMessage(BotInfo *source, int count, const char *singular, const char *plural, ...) ATTR_FORMAT(5, 6);
 	void SendMessage(BotInfo *source, const Anope::string &msg) override;
 	void SendMessage(CommandSource &source, const Anope::string &msg) override;
 
@@ -216,11 +215,6 @@ public:
 	 */
 	NickCore *Account() const;
 
-	/** Get the account nick the user is logged in using
-	 * @return The account nick or NULL
-	 */
-	NickAlias *AccountNick() const;
-
 	/** Check if the user is identified for their nick
 	 * @param check_nick True to check if the user is identified to the nickname they are on too
 	 * @return true or false
@@ -308,10 +302,10 @@ public:
 
 	/** Set a string of modes on a user internally
 	 * @param setter who/what is setting the mode
-	 * @param umodes The mode letters
-	 * @param umodeparams The mode values
+	 * @param umodes The modes
 	 */
-	void SetModesInternal(const MessageSource &source, const Anope::string &umodes, const std::vector<Anope::string> &umodeparams = {});
+	void SetModesInternal(const MessageSource &source, const char *umodes, ...) ATTR_FORMAT(3, 4);
+	void SetModesInternal(const MessageSource &source, const Anope::string &umodes);
 
 	/** Get modes set for this user.
 	 * @return A string of modes set on the user

include/version.cpp

@@ -42,7 +42,7 @@ static std::string get_git_hash(const std::string &git_dir)
 	}
 	fd.close();
 
-	return filebuf.substr(0, 7);
+	return "g" + filebuf.substr(0, 7);
 }
 
 static bool read_version_sh(const std::string &version_sh, std::map<std::string, std::string> &versions)

language/update.sh

@@ -21,6 +21,7 @@ find ../ \
 	\) \
 	-exec \
 		xgettext \
+			--escape \
 			--language=C++ \
 			--sort-output \
 			--default-domain=Anope \
@@ -29,7 +30,6 @@ find ../ \
 			--from-code=utf-8 \
 			--keyword \
 			--keyword=_ \
-			--keyword=N_:1,2 \
 			{} +
 
 for f in *.po

modules/CMakeLists.txt

@@ -19,13 +19,18 @@ if(EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/../conanbuildinfo.cmake")
     file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/extra/${NAME}.cpp" DESTINATION "${CMAKE_CURRENT_SOURCE_DIR}")
   endfunction()
 
-  enable_extra("enc_argon2" "ARGON2")
   enable_extra("mysql" "LIBMYSQLCLIENT")
   enable_extra("regex_pcre2" "PCRE2")
   enable_extra("sqlite" "SQLITE3")
   enable_extra("ssl_openssl" "OPENSSL")
   # this uses Wldap so should always be available
   copy_extra("ldap")
+  # these don't actually have extra dependencies, but require a module which does
+  copy_extra("sql_authentication")
+  copy_extra("sql_log")
+  copy_extra("sql_oper")
+  copy_extra("ldap_authentication")
+  copy_extra("ldap_oper")
 
   # Package extra dlls
   file(GLOB EXTRA_DLLS "${Anope_SOURCE_DIR}/extradll/bin/*.dll" "${Anope_SOURCE_DIR}/extradll/lib/*.dll")
@@ -94,9 +99,7 @@ macro(build_modules SRC)
             target_link_libraries(${SO} ${PROGRAM_NAME})
           endif()
           # Set the module to be installed to the module directory under the data directory
-          install(TARGETS ${SO}
-            DESTINATION ${MODULE_DIR}
-            LIBRARY)
+          install(TARGETS ${SO} DESTINATION ${LIB_DIR}/modules)
         endif()
       endif()
     endforeach()
@@ -170,9 +173,7 @@ macro(build_subdir)
   endif()
 
   # Set the module to be installed to the module directory under the data directory
-  install(TARGETS ${SO}
-    DESTINATION ${MODULE_DIR}
-    LIBRARY)
+  install(TARGETS ${SO} DESTINATION ${LIB_DIR}/modules)
 endmacro()
 
 include_directories(${CMAKE_CURRENT_SOURCE_DIR})

modules/botserv/botserv.cpp

@@ -57,34 +57,29 @@ public:
 		BotInfo *bi = user->server == Me ? dynamic_cast<BotInfo *>(user) : NULL;
 		if (bi && Config->GetModule(this)->Get<bool>("smartjoin"))
 		{
-			if (IRCD->CanClearBans)
+			/* We check for bans */
+			for (const auto &entry : c->GetModeList("BAN"))
 			{
-				// We can ask the IRCd to clear bans.
-				IRCD->SendClearBans(bi, c, bi);
-			}
-			else
-			{
-				// We have to check for bans.
-				for (const auto &entry : c->GetModeList("BAN"))
-				{
-					Entry ban("BAN", entry);
-					if (ban.Matches(user))
-						c->RemoveMode(NULL, "BAN", ban.GetMask());
-				}
+				Entry ban("BAN", entry);
+				if (ban.Matches(user))
+					c->RemoveMode(NULL, "BAN", ban.GetMask());
 			}
 
 			Anope::string Limit;
 			unsigned limit = 0;
-			if (c->GetParam("LIMIT", Limit))
-				limit = Anope::Convert<unsigned>(Limit, limit);
+			try
+			{
+				if (c->GetParam("LIMIT", Limit))
+					limit = convertTo<unsigned>(Limit);
+			}
+			catch (const ConvertException &) { }
 
 			/* Should we be invited? */
 			if (c->HasMode("INVITE") || (limit && c->users.size() >= limit))
 			{
 				ChannelMode *cm = ModeManager::FindChannelModeByName("OP");
 				char symbol = cm ? anope_dynamic_static_cast<ChannelModeStatus *>(cm)->symbol : 0;
-				const auto message = Anope::printf("%s invited %s into the channel.", user->nick.c_str(), user->nick.c_str());
-				IRCD->SendNotice(bi, (symbol ? Anope::string(symbol) : "") + c->name, message);
+				IRCD->SendNotice(bi, (symbol ? Anope::string(symbol) : "") + c->name, "%s invited %s into the channel.", user->nick.c_str(), user->nick.c_str());
 			}
 
 			ModeManager::ProcessModes();
@@ -153,11 +148,11 @@ public:
 				"It has been created for users that can't host or\n"
 				"configure a bot, or for use on networks that don't\n"
 				"allow user bots. Available commands are listed\n"
-				"below; to use them, type \002%s \037command\037\002. For\n"
+				"below; to use them, type \002%s%s \037command\037\002. For\n"
 				"more information on a specific command, type\n"
-				"\002%s %s \037command\037\002.\n"),
-				BotServ->nick.c_str(), BotServ->GetQueryCommand().c_str(),
-				BotServ->GetQueryCommand().c_str(), source.command.c_str());
+				"\002%s%s %s \037command\037\002.\n"),
+				BotServ->nick.c_str(), Config->StrictPrivmsg.c_str(), BotServ->nick.c_str(),
+				Config->StrictPrivmsg.c_str(), BotServ->nick.c_str(), source.command.c_str());
 		}
 
 		return EVENT_CONTINUE;

modules/botserv/bs_assign.cpp

@@ -28,7 +28,7 @@ public:
 
 		if (Anope::ReadOnly)
 		{
-			source.Reply(READ_ONLY_MODE);
+			source.Reply(_("Sorry, bot assignment is temporarily disabled."));
 			return;
 		}
 
@@ -97,7 +97,7 @@ public:
 	{
 		if (Anope::ReadOnly)
 		{
-			source.Reply(READ_ONLY_MODE);
+			source.Reply(_("Sorry, bot assignment is temporarily disabled."));
 			return;
 		}
 
@@ -164,7 +164,7 @@ public:
 
 		if (Anope::ReadOnly)
 		{
-			source.Reply(READ_ONLY_MODE);
+			source.Reply(_("Sorry, bot modification is temporarily disabled."));
 			return;
 		}
 

modules/botserv/bs_badwords.cpp

@@ -21,9 +21,9 @@ struct BadWordImpl final
 
 	void Serialize(Serialize::Data &data) const override
 	{
-		data.Store("ci", this->chan);
-		data.Store("word", this->word);
-		data.Store("type", this->type);
+		data["ci"] << this->chan;
+		data["word"] << this->word;
+		data.SetType("type", Serialize::Data::DT_INT); data["type"] << this->type;
 	}
 
 	static Serializable *Unserialize(Serializable *obj, Serialize::Data &);
@@ -222,7 +222,7 @@ private:
 
 					const BadWord *b = bw->GetBadWord(Number - 1);
 					ListFormatter::ListEntry entry;
-					entry["Number"] = Anope::ToString(Number);
+					entry["Number"] = stringify(Number);
 					entry["Word"] = b->word;
 					entry["Type"] = b->type == BW_SINGLE ? "(SINGLE)" : (b->type == BW_START ? "(START)" : (b->type == BW_END ? "(END)" : ""));
 					this->list.AddEntry(entry);
@@ -241,7 +241,7 @@ private:
 					continue;
 
 				ListFormatter::ListEntry entry;
-				entry["Number"] = Anope::ToString(i + 1);
+				entry["Number"] = stringify(i + 1);
 				entry["Word"] = b->word;
 				entry["Type"] = b->type == BW_SINGLE ? "(SINGLE)" : (b->type == BW_START ? "(START)" : (b->type == BW_END ? "(END)" : ""));
 				list.AddEntry(entry);
@@ -407,7 +407,7 @@ public:
 
 		if (Anope::ReadOnly)
 		{
-			source.Reply(READ_ONLY_MODE);
+			source.Reply(_("Sorry, bad words list modification is temporarily disabled."));
 			return;
 		}
 
@@ -430,7 +430,7 @@ public:
 		source.Reply(_("Maintains the \002bad words list\002 for a channel. The bad\n"
 				"words list determines which words are to be kicked\n"
 				"when the bad words kicker is enabled. For more information,\n"
-				"type \002%s HELP KICK %s\002.\n"
+				"type \002%s%s HELP KICK %s\002.\n"
 				" \n"
 				"The \002ADD\002 command adds the given word to the\n"
 				"bad words list. If SINGLE is specified, a kick will be\n"
@@ -440,7 +440,7 @@ public:
 				"will be done if a user says a word that ends with\n"
 				"\037word\037. If you don't specify anything, a kick will\n"
 				"be issued every time \037word\037 is said by a user.\n"
-				" \n"), source.service->GetQueryCommand().c_str(), source.command.c_str());
+				" \n"), Config->StrictPrivmsg.c_str(), source.service->nick.c_str(), source.command.c_str());
 		source.Reply(_("The \002DEL\002 command removes the given word from the\n"
 				"bad words list.  If a list of entry numbers is given, those\n"
 				"entries are deleted.  (See the example for LIST below.)\n"

modules/botserv/bs_bot.cpp

@@ -28,21 +28,21 @@ private:
 			return;
 		}
 
-		if (nick.length() > IRCD->MaxNick)
+		if (nick.length() > IRCD->GetMaxNick())
 		{
-			source.Reply(_("Bot nicks may only be %zu characters long."), IRCD->MaxNick);
+			source.Reply(_("Bot nicks may only be %zu characters long."), IRCD->GetMaxNick());
 			return;
 		}
 
-		if (user.length() > IRCD->MaxUser)
+		if (user.length() > IRCD->GetMaxUser())
 		{
-			source.Reply(_("Bot idents may only be %zu characters long."), IRCD->MaxUser);
+			source.Reply(_("Bot idents may only be %zu characters long."), IRCD->GetMaxUser());
 			return;
 		}
 
-		if (host.length() > IRCD->MaxHost)
+		if (host.length() > IRCD->GetMaxHost())
 		{
-			source.Reply(_("Bot hosts may only be %zu characters long."), IRCD->MaxHost);
+			source.Reply(_("Bot hosts may only be %zu characters long."), IRCD->GetMaxHost());
 			return;
 		}
 
@@ -118,21 +118,21 @@ private:
 			return;
 		}
 
-		if (nick.length() > IRCD->MaxNick)
+		if (nick.length() > IRCD->GetMaxNick())
 		{
-			source.Reply(_("Bot nicks may only be %zu characters long."), IRCD->MaxNick);
+			source.Reply(_("Bot nicks may only be %zu characters long."), IRCD->GetMaxNick());
 			return;
 		}
 
-		if (user.length() > IRCD->MaxUser)
+		if (user.length() > IRCD->GetMaxUser())
 		{
-			source.Reply(_("Bot idents may only be %zu characters long."), IRCD->MaxUser);
+			source.Reply(_("Bot idents may only be %zu characters long."), IRCD->GetMaxUser());
 			return;
 		}
 
-		if (host.length() > IRCD->MaxHost)
+		if (host.length() > IRCD->GetMaxHost())
 		{
-			source.Reply(_("Bot hosts may only be %zu characters long."), IRCD->MaxHost
+			source.Reply(_("Bot hosts may only be %zu characters long."), IRCD->GetMaxHost()
 				);
 			return;
 		}
@@ -276,7 +276,7 @@ public:
 
 		if (Anope::ReadOnly)
 		{
-			source.Reply(READ_ONLY_MODE);
+			source.Reply(_("Sorry, bot modification is temporarily disabled."));
 			return;
 		}
 

modules/botserv/bs_control.cpp

@@ -56,7 +56,7 @@ public:
 			return;
 		}
 
-		IRCD->SendPrivmsg(*ci->bi, ci->name, text);
+		IRCD->SendPrivmsg(*ci->bi, ci->name, "%s", text.c_str());
 		ci->bi->lastmsg = Anope::CurTime;
 
 		bool override = !source.AccessFor(ci).HasPriv("SAY");
@@ -111,7 +111,11 @@ public:
 			return;
 		}
 
-		IRCD->SendPrivmsg(*ci->bi, ci->name, Anope::FormatCTCP("ACTION", message));
+		message = message.replace_all_cs("\1", "");
+		if (message.empty())
+			return;
+
+		IRCD->SendAction(*ci->bi, ci->name, "%s", message.c_str());
 		ci->bi->lastmsg = Anope::CurTime;
 
 		bool override = !source.AccessFor(ci).HasPriv("SAY");

modules/botserv/bs_info.cpp

@@ -50,12 +50,12 @@ public:
 
 		if (bi)
 		{
-			source.Reply(_("Information about bot \002%s\002:"), bi->nick.c_str());
+			source.Reply(_("Information for bot \002%s\002:"), bi->nick.c_str());
 			info[_("Mask")] = bi->GetIdent() + "@" + bi->host;
 			info[_("Real name")] = bi->realname;
 			info[_("Created")] = Anope::strftime(bi->created, source.GetAccount());
 			info[_("Options")] = bi->oper_only ? _("Private") : _("None");
-			info[_("Used on")] = Anope::printf(Language::Translate(source.nc, N_("%u channel", "%u channels")), bi->GetChannelCount());
+			info[_("Used on")] = stringify(bi->GetChannelCount()) + " channel(s)";
 
 			FOREACH_MOD(OnBotInfo, (source, bi, ci, info));
 

modules/botserv/bs_kick.cpp

@@ -53,28 +53,26 @@ struct KickerDataImpl final
 			if (kd == NULL)
 				return;
 
-			data.Store("kickerdata:amsgs", kd->amsgs);
-			data.Store("kickerdata:badwords", kd->badwords);
-			data.Store("kickerdata:bolds", kd->bolds);
-			data.Store("kickerdata:caps", kd->caps);
-			data.Store("kickerdata:colors", kd->colors);
-			data.Store("kickerdata:flood", kd->flood);
-			data.Store("kickerdata:italics", kd->italics);
-			data.Store("kickerdata:repeat", kd->repeat);
-			data.Store("kickerdata:reverses", kd->reverses);
-			data.Store("kickerdata:underlines", kd->underlines);
-			data.Store("capsmin", kd->capsmin);
-			data.Store("capspercent", kd->capspercent);
-			data.Store("floodlines", kd->floodlines);
-			data.Store("floodsecs", kd->floodsecs);
-			data.Store("repeattimes", kd->repeattimes);
-			data.Store("dontkickops", kd->dontkickops);
-			data.Store("dontkickvoices", kd->dontkickvoices);
+			data["kickerdata:amsgs"] << kd->amsgs;
+			data["kickerdata:badwords"] << kd->badwords;
+			data["kickerdata:bolds"] << kd->bolds;
+			data["kickerdata:caps"] << kd->caps;
+			data["kickerdata:colors"] << kd->colors;
+			data["kickerdata:flood"] << kd->flood;
+			data["kickerdata:italics"] << kd->italics;
+			data["kickerdata:repeat"] << kd->repeat;
+			data["kickerdata:reverses"] << kd->reverses;
+			data["kickerdata:underlines"] << kd->underlines;
 
-			std::ostringstream oss;
+			data.SetType("capsmin", Serialize::Data::DT_INT); data["capsmin"] << kd->capsmin;
+			data.SetType("capspercent", Serialize::Data::DT_INT); data["capspercent"] << kd->capspercent;
+			data.SetType("floodlines", Serialize::Data::DT_INT); data["floodlines"] << kd->floodlines;
+			data.SetType("floodsecs", Serialize::Data::DT_INT); data["floodsecs"] << kd->floodsecs;
+			data.SetType("repeattimes", Serialize::Data::DT_INT); data["repeattimes"] << kd->repeattimes;
+			data.SetType("dontkickops", Serialize::Data::DT_INT); data["dontkickops"] << kd->dontkickops;
+			data.SetType("dontkickvoices", Serialize::Data::DT_INT); data["dontkickvoices"] << kd->dontkickvoices;
 			for (auto ttbtype : kd->ttb)
-				oss << ttbtype << " ";
-			data.Store("ttb", oss.str());
+				data["ttb"] << ttbtype << " ";
 		}
 
 		void ExtensibleUnserialize(Extensible *e, Serializable *s, Serialize::Data &data) override
@@ -108,10 +106,11 @@ struct KickerDataImpl final
 			data["ttb"] >> ttb;
 			spacesepstream sep(ttb);
 			for (int i = 0; sep.GetToken(tok) && i < TTB_SIZE; ++i)
-			{
-				if (auto n = Anope::TryConvert<int16_t>(tok))
-					kd->ttb[i] = n.value();
-			}
+				try
+				{
+					kd->ttb[i] = convertTo<int16_t>(tok);
+				}
+				catch (const ConvertException &) { }
 
 			kd->Check(ci);
 		}
@@ -153,11 +152,11 @@ public:
 			}
 		}
 
-		source.Reply(_("Type \002%s HELP %s \037option\037\002 for more information\n"
+		source.Reply(_("Type \002%s%s HELP %s \037option\037\002 for more information\n"
 				"on a specific option.\n"
 				" \n"
 				"Note: access to this command is controlled by the\n"
-				"level SET."), source.service->GetQueryCommand().c_str(), this_name.c_str());
+				"level SET."), Config->StrictPrivmsg.c_str(), source.service->nick.c_str(), this_name.c_str());
 
 		return true;
 	}
@@ -184,7 +183,7 @@ protected:
 		ci = ChannelInfo::Find(chan);
 
 		if (Anope::ReadOnly)
-			source.Reply(READ_ONLY_MODE);
+			source.Reply(_("Sorry, kicker configuration is temporarily disabled."));
 		else if (ci == NULL)
 			source.Reply(CHAN_X_NOT_REGISTERED, params[0].c_str());
 		else if (option.empty())
@@ -207,13 +206,21 @@ protected:
 		{
 			if (!ttb.empty())
 			{
-				kd->ttb[ttb_idx] = Anope::Convert<int16_t>(ttb, -1);
-				if (kd->ttb[ttb_idx] < 0)
+				int16_t i;
+
+				try
+				{
+					i = convertTo<int16_t>(ttb);
+					if (i < 0)
+						throw ConvertException();
+				}
+				catch (const ConvertException &)
 				{
-					kd->ttb[ttb_idx] = 0;
 					source.Reply(_("\002%s\002 cannot be taken as times to ban."), ttb.c_str());
 					return;
 				}
+
+				kd->ttb[ttb_idx] = i;
 			}
 			else
 				kd->ttb[ttb_idx] = 0;
@@ -308,12 +315,12 @@ public:
 				"option tells the bot to kick users who say certain words\n"
 				"on the channels.\n"
 				"You can define bad words for your channel using the\n"
-				"\002BADWORDS\002 command. Type \002%s HELP BADWORDS\002 for\n"
+				"\002BADWORDS\002 command. Type \002%s%s HELP BADWORDS\002 for\n"
 				"more information.\n"
 				" \n"
 				"\037ttb\037 is the number of times a user can be kicked\n"
 				"before it gets banned. Don't give ttb to disable\n"
-				"the ban system once activated."), source.service->GetQueryCommand().c_str());
+				"the ban system once activated."), Config->StrictPrivmsg.c_str(), source.service->nick.c_str());
 		return true;
 	}
 };
@@ -379,8 +386,13 @@ public:
 
 			if (!ttb.empty())
 			{
-				kd->ttb[TTB_CAPS] = Anope::Convert<int16_t>(ttb, -1);
-				if (kd->ttb[TTB_CAPS] < 0)
+				try
+				{
+					kd->ttb[TTB_CAPS] = convertTo<int16_t>(ttb);
+					if (kd->ttb[TTB_CAPS] < 0)
+						throw ConvertException();
+				}
+				catch (const ConvertException &)
 				{
 					kd->ttb[TTB_CAPS] = 0;
 					source.Reply(_("\002%s\002 cannot be taken as times to ban."), ttb.c_str());
@@ -390,11 +402,21 @@ public:
 			else
 				kd->ttb[TTB_CAPS] = 0;
 
-			kd->capsmin = Anope::Convert(min, 0);
+			kd->capsmin = 10;
+			try
+			{
+				kd->capsmin = convertTo<int16_t>(min);
+			}
+			catch (const ConvertException &) { }
 			if (kd->capsmin < 1)
 				kd->capsmin = 10;
 
-			kd->capspercent = Anope::Convert(percent, 0);
+			kd->capspercent = 25;
+			try
+			{
+				kd->capspercent = convertTo<int16_t>(percent);
+			}
+			catch (const ConvertException &) { }
 			if (kd->capspercent < 1 || kd->capspercent > 100)
 				kd->capspercent = 25;
 
@@ -496,25 +518,42 @@ public:
 
 			if (!ttb.empty())
 			{
-				kd->ttb[TTB_FLOOD] = Anope::Convert<int16_t>(ttb, -1);
-				if (kd->ttb[TTB_FLOOD] < 0)
+				int16_t i;
+
+				try
+				{
+					i = convertTo<int16_t>(ttb);
+					if (i < 0)
+						throw ConvertException();
+				}
+				catch (const ConvertException &)
 				{
-					kd->ttb[TTB_FLOOD] = 0;
 					source.Reply(_("\002%s\002 cannot be taken as times to ban."), ttb.c_str());
 					return;
 				}
+
+				kd->ttb[TTB_FLOOD] = i;
 			}
 			else
 				kd->ttb[TTB_FLOOD] = 0;
 
-			kd->floodlines = Anope::Convert(lines, -1);
+			kd->floodlines = 6;
+			try
+			{
+				kd->floodlines = convertTo<int16_t>(lines);
+			}
+			catch (const ConvertException &) { }
 			if (kd->floodlines < 2)
 				kd->floodlines = 6;
 
-			kd->floodsecs = Anope::Convert(secs, -1);
+			kd->floodsecs = 10;
+			try
+			{
+				kd->floodsecs = convertTo<int16_t>(secs);
+			}
+			catch (const ConvertException &) { }
 			if (kd->floodsecs < 1)
 				kd->floodsecs = 10;
-
 			if (kd->floodsecs > Config->GetModule(me)->Get<time_t>("keepdata"))
 				kd->floodsecs = Config->GetModule(me)->Get<time_t>("keepdata");
 
@@ -612,18 +651,31 @@ public:
 
 			if (!ttb.empty())
 			{
-				kd->ttb[TTB_REPEAT] = Anope::Convert(ttb, -1);
-				if (kd->ttb[TTB_REPEAT] < 0)
+				int16_t i;
+
+				try
+				{
+					i = convertTo<int16_t>(ttb);
+					if (i < 0)
+						throw ConvertException();
+				}
+				catch (const ConvertException &)
 				{
-					kd->ttb[TTB_REPEAT] = 0;
 					source.Reply(_("\002%s\002 cannot be taken as times to ban."), ttb.c_str());
 					return;
 				}
+
+				kd->ttb[TTB_REPEAT] = i;
 			}
 			else
 				kd->ttb[TTB_REPEAT] = 0;
 
-			kd->repeattimes = Anope::Convert<int16_t>(times, -1);
+			kd->repeattimes = 3;
+			try
+			{
+				kd->repeattimes = convertTo<int16_t>(times);
+			}
+			catch (const ConvertException &) { }
 			if (kd->repeattimes < 1)
 				kd->repeattimes = 3;
 
@@ -774,7 +826,7 @@ public:
 
 		if (Anope::ReadOnly)
 		{
-			source.Reply(READ_ONLY_MODE);
+			source.Reply(_("Sorry, bot option setting is temporarily disabled."));
 			return;
 		}
 
@@ -840,7 +892,7 @@ public:
 
 		if (Anope::ReadOnly)
 		{
-			source.Reply(READ_ONLY_MODE);
+			source.Reply(_("Sorry, bot option setting is temporarily disabled."));
 			return;
 		}
 
@@ -1218,9 +1270,11 @@ public:
 		/* If it's a /me, cut the CTCP part because the ACTION will cause
 		 * problems with the caps or badwords kicker
 		 */
-		Anope::string ctcpname, ctcpbody;
-		if (Anope::ParseCTCP(msg, ctcpname, ctcpbody) && ctcpname.equals_ci("ACTION"))
-			realbuf = ctcpbody;
+		if (realbuf.substr(0, 8).equals_ci("\1ACTION ") && realbuf[realbuf.length() - 1] == '\1')
+		{
+			realbuf.erase(0, 8);
+			realbuf.erase(realbuf.length() - 1);
+		}
 
 		if (realbuf.empty())
 			return;

modules/botserv/bs_set.cpp

@@ -58,8 +58,8 @@ public:
 				}
 			}
 		}
-		source.Reply(_("Type \002%s HELP %s \037option\037\002 for more information on a\n"
-				"particular option."), source.service->GetQueryCommand().c_str(), this_name.c_str());
+		source.Reply(_("Type \002%s%s HELP %s \037option\037\002 for more information on a\n"
+				"particular option."), Config->StrictPrivmsg.c_str(), source.service->nick.c_str(), this_name.c_str());
 
 		return true;
 	}
@@ -118,7 +118,7 @@ public:
 
 		if (Anope::ReadOnly)
 		{
-			source.Reply(READ_ONLY_MODE);
+			source.Reply(_("Sorry, changing bot options is temporarily disabled."));
 			return;
 		}
 

modules/chanserv/chanserv.cpp

@@ -52,7 +52,7 @@ public:
 			 * @param chan The channel
 			 */
 			ChanServTimer(Reference<BotInfo> &cs, ExtensibleItem<bool> &i, Module *m, Channel *chan)
-				: Timer(m, Config->GetModule(m)->Get<time_t>("inhabit", "1m"))
+				: Timer(m, Config->GetModule(m)->Get<time_t>("inhabit", "15s"))
 				, ChanServ(cs)
 				, inhabit(i)
 				, c(chan)
@@ -262,9 +262,9 @@ public:
 			"malicious users from \"taking over\" channels by limiting\n"
 			"who is allowed channel operator privileges. Available\n"
 			"commands are listed below; to use them, type\n"
-			"\002%s \037command\037\002. For more information on a\n"
-			"specific command, type \002%s HELP \037command\037\002.\n"),
-			ChanServ->nick.c_str(), ChanServ->nick.c_str(), ChanServ->GetQueryCommand().c_str(), ChanServ->GetQueryCommand().c_str());
+			"\002%s%s \037command\037\002. For more information on a\n"
+			"specific command, type \002%s%s HELP \037command\037\002.\n"),
+			ChanServ->nick.c_str(), ChanServ->nick.c_str(),  Config->StrictPrivmsg.c_str(), ChanServ->nick.c_str(), Config->StrictPrivmsg.c_str(), ChanServ->nick.c_str());
 		return EVENT_CONTINUE;
 	}
 
@@ -382,11 +382,8 @@ public:
 		return EVENT_CONTINUE;
 	}
 
-	void OnUplinkSync(Server* s) override
+	void OnPostInit() override
 	{
-		// We need to do this when the uplink is synced as we may not know if
-		// the mode exists before then on some IRCds (e.g. InspIRCd).
-
 		if (!persist)
 			return;
 

modules/chanserv/cs_access.cpp

@@ -37,13 +37,18 @@ public:
 
 	Anope::string AccessSerialize() const override
 	{
-		return Anope::ToString(this->level);
+		return stringify(this->level);
 	}
 
 	void AccessUnserialize(const Anope::string &data) override
 	{
-		if (auto l = Anope::TryConvert<int>(data))
-			this->level = l.value();
+		try
+		{
+			this->level = convertTo<int>(data);
+		}
+		catch (const ConvertException &)
+		{
+		}
 	}
 
 	bool operator>(const ChanAccess &other) const override
@@ -87,13 +92,14 @@ class CommandCSAccess final
 	void DoAdd(CommandSource &source, ChannelInfo *ci, const std::vector<Anope::string> &params)
 	{
 		Anope::string mask = params[2];
-		Anope::string description = params.size() > 4 ? params[4] : "";
 		Privilege *p = NULL;
 		int level = ACCESS_INVALID;
 
-		if (auto lvl = Anope::TryConvert<int>(params[3]))
-			level = lvl.value();
-		else
+		try
+		{
+			level = convertTo<int>(params[3]);
+		}
+		catch (const ConvertException &)
 		{
 			p = PrivilegeManager::FindPrivilege(params[3]);
 			if (p != NULL && defaultLevels[p->name])
@@ -173,11 +179,7 @@ class CommandCSAccess final
 			{
 				User *targ = User::Find(mask, true);
 				if (targ != NULL)
-				{
 					mask = "*!*@" + targ->GetDisplayedHost();
-					if (description.empty())
-						description = targ->nick;
-				}
 				else
 				{
 					source.Reply(NICK_X_NOT_REGISTERED, mask.c_str());
@@ -205,7 +207,7 @@ class CommandCSAccess final
 			}
 		}
 
-		unsigned access_max = Config->GetModule("chanserv")->Get<unsigned>("accessmax", "1000");
+		unsigned access_max = Config->GetModule("chanserv")->Get<unsigned>("accessmax", "1024");
 		if (access_max && ci->GetDeepAccessCount() >= access_max)
 		{
 			source.Reply(_("Sorry, you can only have %d access entries on a channel, including access entries from other channels."), access_max);
@@ -221,7 +223,7 @@ class CommandCSAccess final
 		access->level = level;
 		access->last_seen = 0;
 		access->created = Anope::CurTime;
-		access->description = description;
+		access->description = params.size() > 4 ? params[4] : "";
 		ci->AddAccess(access);
 
 		FOREACH_MOD(OnAccessAdd, (ci, source, access));
@@ -400,7 +402,7 @@ class CommandCSAccess final
 					}
 
 					ListFormatter::ListEntry entry;
-					entry["Number"] = Anope::ToString(number);
+					entry["Number"] = stringify(number);
 					entry["Level"] = access->AccessSerialize();
 					entry["Mask"] = access->Mask();
 					entry["By"] = access->creator;
@@ -440,7 +442,7 @@ class CommandCSAccess final
 				}
 
 				ListFormatter::ListEntry entry;
-				entry["Number"] = Anope::ToString(i + 1);
+				entry["Number"] = stringify(i + 1);
 				entry["Level"] = access->AccessSerialize();
 				entry["Mask"] = access->Mask();
 				entry["By"] = access->creator;
@@ -565,7 +567,7 @@ public:
 		else if (!has_access)
 			source.Reply(ACCESS_DENIED);
 		else if (Anope::ReadOnly && !is_list)
-			source.Reply(READ_ONLY_MODE);
+			source.Reply(_("Sorry, channel access list modification is temporarily disabled."));
 		else if (cmd.equals_ci("ADD"))
 			this->DoAdd(source, ci, params);
 		else if (cmd.equals_ci("DEL"))
@@ -630,8 +632,8 @@ public:
 		Anope::string cmd;
 		if (Command::FindCommandFromService("chanserv/levels", bi, cmd))
 			source.Reply(_("\002User access levels\002 can be seen by using the\n"
-					"\002%s\002 command; type \002%s HELP LEVELS\002 for\n"
-					"information."), cmd.c_str(), bi->GetQueryCommand().c_str());
+					"\002%s\002 command; type \002%s%s HELP LEVELS\002 for\n"
+					"information."), cmd.c_str(), Config->StrictPrivmsg.c_str(), bi->nick.c_str());
 		return true;
 	}
 };
@@ -650,9 +652,11 @@ class CommandCSLevels final
 			level = ACCESS_FOUNDER;
 		else
 		{
-			if (auto lvl = Anope::TryConvert<int>(lev))
-				level = lvl.value();
-			else
+			try
+			{
+				level = convertTo<int>(lev);
+			}
+			catch (const ConvertException &)
 			{
 				this->OnSyntaxError(source, "SET");
 				return;
@@ -665,10 +669,7 @@ class CommandCSLevels final
 		{
 			Privilege *p = PrivilegeManager::FindPrivilege(what);
 			if (p == NULL)
-			{
-				source.Reply(_("Setting \002%s\002 not known.  Type \002%s HELP LEVELS\002 for a list of valid settings."),
-					what.c_str(), source.service->GetQueryCommand().c_str());
-			}
+				source.Reply(_("Setting \002%s\002 not known.  Type \002%s%s HELP LEVELS\002 for a list of valid settings."), what.c_str(), Config->StrictPrivmsg.c_str(), source.service->nick.c_str());
 			else
 			{
 				bool override = !source.AccessFor(ci).HasPriv("FOUNDER");
@@ -709,8 +710,7 @@ class CommandCSLevels final
 			return;
 		}
 
-		source.Reply(_("Setting \002%s\002 not known.  Type \002%s HELP LEVELS\002 for a list of valid settings."),
-			what.c_str(), source.service->GetQueryCommand().c_str());
+		source.Reply(_("Setting \002%s\002 not known.  Type \002%s%s HELP LEVELS\002 for a list of valid settings."), what.c_str(), Config->StrictPrivmsg.c_str(), source.service->nick.c_str());
 	}
 
 	static void DoList(CommandSource &source, ChannelInfo *ci)
@@ -734,7 +734,7 @@ class CommandCSLevels final
 			else if (j == ACCESS_FOUNDER)
 				entry["Level"] = Language::Translate(source.GetAccount(), _("(founder only)"));
 			else
-				entry["Level"] = Anope::ToString(j);
+				entry["Level"] = stringify(j);
 
 			list.AddEntry(entry);
 		}

modules/chanserv/cs_akick.cpp

@@ -311,7 +311,7 @@ class CommandCSAKick final
 						lastused = UNKNOWN;
 
 					ListFormatter::ListEntry entry;
-					entry["Number"] = Anope::ToString(number);
+					entry["Number"] = stringify(number);
 					if (akick->nc)
 						entry["Mask"] = akick->nc->display;
 					else
@@ -351,7 +351,7 @@ class CommandCSAKick final
 					lastused = UNKNOWN;
 
 				ListFormatter::ListEntry entry;
-				entry["Number"] = Anope::ToString(i + 1);
+				entry["Number"] = stringify(i + 1);
 				if (akick->nc)
 					entry["Mask"] = akick->nc->display;
 				else
@@ -466,7 +466,7 @@ public:
 		else if (!has_access)
 			source.Reply(ACCESS_DENIED);
 		else if (!cmd.equals_ci("LIST") && !cmd.equals_ci("VIEW") && !cmd.equals_ci("ENFORCE") && Anope::ReadOnly)
-			source.Reply(READ_ONLY_MODE);
+			source.Reply(_("Sorry, channel autokick list modification is temporarily disabled."));
 		else if (cmd.equals_ci("ADD"))
 			this->DoAdd(source, ci, params);
 		else if (cmd.equals_ci("DEL"))

modules/chanserv/cs_clone.cpp

@@ -24,7 +24,7 @@ class CommandCSClone final
 	static void CopyAccess(CommandSource &source, ChannelInfo *ci, ChannelInfo *target_ci)
 	{
 		std::set<Anope::string> masks;
-		unsigned access_max = Config->GetModule("chanserv")->Get<unsigned>("accessmax", "1000");
+		unsigned access_max = Config->GetModule("chanserv")->Get<unsigned>("accessmax", "1024");
 		unsigned count = 0;
 
 		for (unsigned i = 0; i < target_ci->GetAccessCount(); ++i)

modules/chanserv/cs_drop.cpp

@@ -20,7 +20,7 @@ private:
 public:
 	CommandCSDrop(Module *creator)
 		: Command(creator, "chanserv/drop", 1, 2)
-		, dropcode(creator, "channel-dropcode")
+		, dropcode(creator, "dropcode")
 	{
 		this->SetDesc(_("Cancel the registration of a channel"));
 		this->SetSyntax(_("\037channel\037 [\037code\037]"));
@@ -32,7 +32,7 @@ public:
 
 		if (Anope::ReadOnly && !source.HasPriv("chanserv/administration"))
 		{
-			source.Reply(READ_ONLY_MODE);
+			source.Reply(_("Sorry, channel de-registration is temporarily disabled.")); // XXX: READ_ONLY_MODE?
 			return;
 		}
 
@@ -50,16 +50,16 @@ public:
 		}
 
 		auto *code = dropcode.Get(ci);
-		if (params.size() < 2 || ((!code || !code->equals_ci(params[1])) && (!source.HasPriv("chanserv/drop/override") || params[1] != "OVERRIDE")))
+		if (params.size() < 2 || !code || !code->equals_ci(params[1]))
 		{
 			if (!code)
 			{
-				code = ci->Extend<Anope::string>("channel-dropcode");
+				code = ci->Extend<Anope::string>("dropcode");
 				*code = Anope::Random(15);
 			}
 
-			source.Reply(CONFIRM_DROP, ci->name.c_str(), source.service->GetQueryCommand().c_str(),
-				ci->name.c_str(), code->c_str());
+			source.Reply(_("Please confirm that you want to drop \002%s\002 with \002DROP %s %s\002"),
+				chan.c_str(), chan.c_str(), code->c_str());
 			return;
 		}
 
@@ -94,10 +94,6 @@ public:
 			source.Reply(_("Unregisters the named channel.  Can only be used by\n"
 					"the \002channel founder\002."));
 
-		source.Reply(" ");
-		if (source.HasPriv("chanserv/drop/override"))
-			source.Reply(_("Additionally, Services Operators with the \037chanserv/drop/override\037 permission can\n"
-				"replace \037code\037 with \002OVERRIDE\002 to drop without a confirmation code."));
 		return true;
 	}
 };

modules/chanserv/cs_enforce.cpp

@@ -166,8 +166,14 @@ private:
 			return;
 		}
 
-		auto l = Anope::Convert<int>(l_str, -1);
-		if (l < 0)
+		int l;
+		try
+		{
+			l = convertTo<int>(l_str);
+			if (l < 0)
+				throw ConvertException();
+		}
+		catch (const ConvertException &)
 		{
 			source.Reply(_("The limit on %s is not valid."), ci->name.c_str());
 			return;

modules/chanserv/cs_entrymsg.cpp

@@ -32,10 +32,10 @@ struct EntryMsgImpl final
 
 	void Serialize(Serialize::Data &data) const override
 	{
-		data.Store("ci", this->chan);
-		data.Store("creator", this->creator);
-		data.Store("message", this->message);
-		data.Store("when", this->when);
+		data["ci"] << this->chan;
+		data["creator"] << this->creator;
+		data["message"] << this->message;
+		data.SetType("when", Serialize::Data::DT_INT); data["when"] << this->when;
 	}
 
 	static Serializable *Unserialize(Serializable *obj, Serialize::Data &data);
@@ -123,7 +123,7 @@ private:
 			EntryMsg *msg = (*messages)->at(i);
 
 			ListFormatter::ListEntry entry;
-			entry["Number"] = Anope::ToString(i + 1);
+			entry["Number"] = stringify(i + 1);
 			entry["Creator"] = msg->creator;
 			entry["Created"] = Anope::strftime(msg->when, NULL, true);
 			entry["Message"] = msg->message;
@@ -162,16 +162,21 @@ private:
 			source.Reply(_("Entry message list for \002%s\002 is empty."), ci->name.c_str());
 		else
 		{
-			auto i = Anope::Convert<unsigned>(message, 0);
-			if (i > 0 && i <= (*messages)->size())
+			try
 			{
-				delete (*messages)->at(i - 1);
-				if ((*messages)->empty())
-					ci->Shrink<EntryMessageList>("entrymsg");
-				Log(source.AccessFor(ci).HasPriv("SET") ? LOG_COMMAND : LOG_OVERRIDE, source, this, ci) << "to remove a message";
-				source.Reply(_("Entry message \002%i\002 for \002%s\002 deleted."), i, ci->name.c_str());
+				unsigned i = convertTo<unsigned>(message);
+				if (i > 0 && i <= (*messages)->size())
+				{
+					delete (*messages)->at(i - 1);
+					if ((*messages)->empty())
+						ci->Shrink<EntryMessageList>("entrymsg");
+					Log(source.AccessFor(ci).HasPriv("SET") ? LOG_COMMAND : LOG_OVERRIDE, source, this, ci) << "to remove a message";
+					source.Reply(_("Entry message \002%i\002 for \002%s\002 deleted."), i, ci->name.c_str());
+				}
+				else
+					throw ConvertException();
 			}
-			else
+			catch (const ConvertException &)
 			{
 				source.Reply(_("Entry message \002%s\002 not found on channel \002%s\002."), message.c_str(), ci->name.c_str());
 			}

modules/chanserv/cs_flags.cpp

@@ -79,7 +79,7 @@ FlagsAccessProvider *FlagsAccessProvider::ap;
 class CommandCSFlags final
 	: public Command
 {
-	void DoModify(CommandSource &source, ChannelInfo *ci, Anope::string mask, const Anope::string &flags, Anope::string description)
+	void DoModify(CommandSource &source, ChannelInfo *ci, Anope::string mask, const Anope::string &flags, const Anope::string &description)
 	{
 		if (flags.empty())
 		{
@@ -131,11 +131,7 @@ class CommandCSFlags final
 			{
 				User *targ = User::Find(mask, true);
 				if (targ != NULL)
-				{
 					mask = "*!*@" + targ->GetDisplayedHost();
-					if (description.empty())
-						description = targ->nick;
-				}
 				else
 				{
 					source.Reply(NICK_X_NOT_REGISTERED, mask.c_str());
@@ -179,7 +175,7 @@ class CommandCSFlags final
 			}
 		}
 
-		unsigned access_max = Config->GetModule("chanserv")->Get<unsigned>("accessmax", "1000");
+		unsigned access_max = Config->GetModule("chanserv")->Get<unsigned>("accessmax", "1024");
 		if (access_max && ci->GetDeepAccessCount() >= access_max)
 		{
 			source.Reply(_("Sorry, you can only have %d access entries on a channel, including access entries from other channels."), access_max);
@@ -335,7 +331,7 @@ class CommandCSFlags final
 
 			ListFormatter::ListEntry entry;
 			++count;
-			entry["Number"] = Anope::ToString(i + 1);
+			entry["Number"] = stringify(i + 1);
 			entry["Mask"] = access->Mask();
 			entry["Flags"] = flags;
 			entry["Creator"] = access->creator;
@@ -415,7 +411,7 @@ public:
 		if (!has_access)
 			source.Reply(ACCESS_DENIED);
 		else if (Anope::ReadOnly && !is_list)
-			source.Reply(READ_ONLY_MODE);
+			source.Reply(_("Sorry, channel access list modification is temporarily disabled."));
 		else if (is_list)
 			this->DoList(source, ci, params);
 		else if (cmd.equals_ci("CLEAR"))

modules/chanserv/cs_info.cpp

@@ -58,7 +58,7 @@ public:
 
 		if (show_all)
 		{
-			info[_("Ban type")] = Anope::ToString(ci->bantype);
+			info[_("Ban type")] = stringify(ci->bantype);
 		}
 
 		FOREACH_MOD(OnChanInfo, (source, ci, info, show_all));

modules/chanserv/cs_list.cpp

@@ -36,10 +36,12 @@ public:
 			sepstream(pattern.substr(1), '-').GetToken(n1, 0);
 			sepstream(pattern, '-').GetToken(n2, 1);
 
-			auto num1 = Anope::TryConvert<int>(n1);
-			auto num2 = Anope::TryConvert<int>(n2);
-
-			if (!num1.has_value() || !num2.has_value())
+			try
+			{
+				from = convertTo<int>(n1);
+				to = convertTo<int>(n2);
+			}
+			catch (const ConvertException &)
 			{
 				source.Reply(LIST_INCORRECT_RANGE);
 				source.Reply(_("To search for channels starting with #, search for the channel\n"
@@ -47,8 +49,6 @@ public:
 				return;
 			}
 
-			from = num1.value();
-			to = num2.value();
 			pattern = "*";
 		}
 

modules/chanserv/cs_log.cpp

@@ -37,14 +37,14 @@ struct LogSettingImpl final
 
 	void Serialize(Serialize::Data &data) const override
 	{
-		data.Store("ci", chan);
-		data.Store("service_name", service_name);
-		data.Store("command_service", command_service);
-		data.Store("command_name", command_name);
-		data.Store("method", method);
-		data.Store("extra", extra);
-		data.Store("creator", creator);
-		data.Store("created", created);
+		data["ci"] << chan;
+		data["service_name"] << service_name;
+		data["command_service"] << command_service;
+		data["command_name"] << command_name;
+		data["method"] << method;
+		data["extra"] << extra;
+		data["creator"] << creator;
+		data.SetType("created", Serialize::Data::DT_INT); data["created"] << created;
 	}
 
 	static Serializable *Unserialize(Serializable *obj, Serialize::Data &data)
@@ -135,7 +135,7 @@ public:
 					const LogSetting *log = (*ls)->at(i);
 
 					ListFormatter::ListEntry entry;
-					entry["Number"] = Anope::ToString(i + 1);
+					entry["Number"] = stringify(i + 1);
 					entry["Service"] = log->command_service;
 					entry["Command"] = !log->command_name.empty() ? log->command_name : log->service_name;
 					entry["Method"] = log->method;
@@ -391,11 +391,11 @@ public:
 					/* Sending a channel message or notice in response to a fantasy command */;
 				else if (log->method.equals_ci("MESSAGE") && l->ci->c)
 				{
-					IRCD->SendPrivmsg(l->ci->WhoSends(), log->extra + l->ci->c->name, buffer);
+					IRCD->SendPrivmsg(l->ci->WhoSends(), log->extra + l->ci->c->name, "%s", buffer.c_str());
 					l->ci->WhoSends()->lastmsg = Anope::CurTime;
 				}
 				else if (log->method.equals_ci("NOTICE") && l->ci->c)
-					IRCD->SendNotice(l->ci->WhoSends(), log->extra + l->ci->c->name, buffer);
+					IRCD->SendNotice(l->ci->WhoSends(), log->extra + l->ci->c->name, "%s", buffer.c_str());
 			}
 		}
 	}

modules/chanserv/cs_mode.cpp

@@ -205,12 +205,12 @@ struct ModeLocksImpl final
 
 void ModeLockImpl::Serialize(Serialize::Data &data) const
 {
-	data.Store("ci", this->ci);
-	data.Store("set", this->set);
-	data.Store("name", this->name);
-	data.Store("param", this->param);
-	data.Store("setter", this->setter);
-	data.Store("created", this->created);
+	data["ci"] << this->ci;
+	data["set"] << this->set;
+	data["name"] << this->name;
+	data["param"] << this->param;
+	data["setter"] << this->setter;
+	data.SetType("created", Serialize::Data::DT_INT); data["created"] << this->created;
 }
 
 Serializable *ModeLockImpl::Unserialize(Serializable *obj, Serialize::Data &data)
@@ -336,7 +336,7 @@ class CommandCSMode final
 							continue;
 						}
 
-						if (modelocks->GetMLock().size() >= Config->GetModule(this->owner)->Get<unsigned>("max", "50"))
+						if (modelocks->GetMLock().size() >= Config->GetModule(this->owner)->Get<unsigned>("max", "32"))
 						{
 							source.Reply(_("The mode lock list of \002%s\002 is full."), ci->name.c_str());
 							continue;
@@ -658,8 +658,7 @@ class CommandCSMode final
 							}
 							else
 							{
-								std::vector<Anope::string> v = ci->c->GetModeList(cm->name);
-								for (const auto &mode :  v)
+								for (const auto &mode :  ci->c->GetModeList(cm->name))
 								{
 									if (Anope::Match(mode, param))
 										ci->c->RemoveMode(NULL, cm, mode);
@@ -717,7 +716,7 @@ class CommandCSMode final
 		std::vector<Anope::string> new_params;
 		new_params.push_back(params[0]);
 		new_params.emplace_back("SET");
-		new_params.push_back("-" + Anope::ToString(cm->mchar));
+		new_params.push_back("-" + stringify(cm->mchar));
 		new_params.emplace_back("*");
 		this->DoSet(source, ci, new_params);
 	}

modules/chanserv/cs_register.cpp

@@ -33,7 +33,7 @@ public:
 		ChannelInfo *ci = ChannelInfo::Find(params[0]);
 
 		if (Anope::ReadOnly)
-			source.Reply(READ_ONLY_MODE);
+			source.Reply(_("Sorry, channel registration is temporarily disabled."));
 		else if (nc->HasExt("UNCONFIRMED"))
 			source.Reply(_("You must confirm your account before you can register a channel."));
 		else if (chan[0] == '&')
@@ -100,9 +100,9 @@ public:
 		Anope::string cmd;
 		if (Command::FindCommandFromService("chanserv/access", bi, cmd))
 			source.Reply(_(" \n"
-				"See the \002%s\002 command (\002%s HELP ACCESS\002) for\n"
+				"See the \002%s\002 command (\002%s%s HELP ACCESS\002) for\n"
 				"information on giving a subset of these privileges to\n"
-				"other channel users.\n"), cmd.c_str(), bi->GetQueryCommand().c_str());
+				"other channel users.\n"), cmd.c_str(), Config->StrictPrivmsg.c_str(), bi->nick.c_str());
 		source.Reply(_(" \n"
 			"NOTICE: In order to register a channel, you must have\n"
 			"first registered your nickname."));

modules/chanserv/cs_seen.cpp

@@ -19,7 +19,7 @@ enum TypeInfo
 static bool simple;
 struct SeenInfo;
 static SeenInfo *FindInfo(const Anope::string &nick);
-typedef Anope::unordered_map<SeenInfo *> database_map;
+typedef Anope::hash_map<SeenInfo *> database_map;
 database_map database;
 
 struct SeenInfo final
@@ -46,13 +46,13 @@ struct SeenInfo final
 
 	void Serialize(Serialize::Data &data) const override
 	{
-		data.Store("nick", nick);
-		data.Store("vhost", vhost);
-		data.Store("type", type);
-		data.Store("nick2", nick2);
-		data.Store("channel", channel);
-		data.Store("message", message);
-		data.Store("last", last);
+		data["nick"] << nick;
+		data["vhost"] << vhost;
+		data["type"] << type;
+		data["nick2"] << nick2;
+		data["channel"] << channel;
+		data["message"] << message;
+		data.SetType("last", Serialize::Data::DT_INT); data["last"] << last;
 	}
 
 	static Serializable *Unserialize(Serializable *obj, Serialize::Data &data)
@@ -270,9 +270,9 @@ public:
 		if (simple)
 			return this->SimpleSeen(source, params);
 
-		if (target.length() > IRCD->MaxNick)
+		if (target.length() > IRCD->GetMaxNick())
 		{
-			source.Reply(_("Nick too long, max length is %zu characters."), IRCD->MaxNick);
+			source.Reply(_("Nick too long, max length is %zu characters."), IRCD->GetMaxNick());
 			return;
 		}
 

modules/chanserv/cs_set.cpp

@@ -59,8 +59,8 @@ public:
 				c->OnServHelp(source);
 			}
 		}
-		source.Reply(_("Type \002%s HELP %s \037option\037\002 for more information on a\n"
-				"particular option."), source.service->GetQueryCommand().c_str(), this_name.c_str());
+		source.Reply(_("Type \002%s%s HELP %s \037option\037\002 for more information on a\n"
+				"particular option."), Config->StrictPrivmsg.c_str(), source.service->nick.c_str(), this_name.c_str());
 		return true;
 	}
 };
@@ -165,16 +165,19 @@ public:
 			return;
 		}
 
-		auto new_type = Anope::Convert<int16_t>(params[1], -1);
-		if (new_type < 0 || new_type > 3)
+		try
+		{
+			int16_t new_type = convertTo<int16_t>(params[1]);
+			if (new_type < 0 || new_type > 3)
+				throw ConvertException("Invalid range");
+			Log(source.AccessFor(ci).HasPriv("SET") ? LOG_COMMAND : LOG_OVERRIDE, source, this, ci) << "to change the ban type to " << new_type;
+			ci->bantype = new_type;
+			source.Reply(_("Ban type for channel %s is now #%d."), ci->name.c_str(), ci->bantype);
+		}
+		catch (const ConvertException &)
 		{
 			source.Reply(_("\002%s\002 is not a valid ban type."), params[1].c_str());
-			return;
 		}
-
-		Log(source.AccessFor(ci).HasPriv("SET") ? LOG_COMMAND : LOG_OVERRIDE, source, this, ci) << "to change the ban type to " << new_type;
-		ci->bantype = new_type;
-		source.Reply(_("Ban type for channel %s is now #%d."), ci->name.c_str(), ci->bantype);
 	}
 
 	bool OnHelp(CommandSource &source, const Anope::string &) override
@@ -513,13 +516,12 @@ public:
 				/* Set the perm mode */
 				if (cm)
 				{
+					if (ci->c && !ci->c->HasMode("PERM"))
+						ci->c->SetMode(NULL, cm);
 					/* Add it to the channels mlock */
 					ModeLocks *ml = ci->Require<ModeLocks>("modelocks");
 					if (ml)
 						ml->SetMLock(cm, true, "", source.GetNick());
-
-					if (ci->c && !ci->c->HasMode("PERM"))
-						ci->c->SetMode(NULL, cm);
 				}
 				/* No botserv bot, no channel mode, give them ChanServ.
 				 * Yes, this works fine with no BotServ.
@@ -557,13 +559,12 @@ public:
 				/* Unset perm mode */
 				if (cm)
 				{
+					if (ci->c && ci->c->HasMode("PERM"))
+						ci->c->RemoveMode(NULL, cm);
 					/* Remove from mlock */
 					ModeLocks *ml = ci->GetExt<ModeLocks>("modelocks");
 					if (ml)
 						ml->RemoveMLock(cm, true);
-
-					if (ci->c && ci->c->HasMode("PERM"))
-						ci->c->RemoveMode(NULL, cm);
 				}
 				/* No channel mode, no BotServ, but using ChanServ as the botserv bot
 				 * which was assigned when persist was set on
@@ -1070,7 +1071,7 @@ class CSSet final
 				if (!last_value.empty())
 					modes += "," + last_value;
 			}
-			data.Store("last_modes", modes);
+			data["last_modes"] << modes;
 		}
 
 		void ExtensibleUnserialize(Extensible *e, Serializable *s, Serialize::Data &data) override
@@ -1148,7 +1149,7 @@ public:
 		if (c->ci && keep_modes.HasExt(c->ci))
 		{
 			Channel::ModeList ml = c->ci->last_modes;
-			for (const auto &[last_mode, last_value] : ml)
+			for (const auto &[last_mode, last_value] : c->ci->last_modes)
 				c->SetMode(c->ci->WhoSends(), last_mode, last_value);
 		}
 	}

modules/chanserv/cs_set_misc.cpp

@@ -15,7 +15,6 @@
 static Module *me;
 
 static Anope::map<Anope::string> descriptions;
-static Anope::map<uint16_t> numerics;
 
 struct CSMiscData;
 static Anope::map<ExtensibleItem<CSMiscData> *> items;
@@ -47,9 +46,9 @@ struct CSMiscData final
 
 	void Serialize(Serialize::Data &sdata) const override
 	{
-		sdata.Store("ci", this->object);
-		sdata.Store("name", this->name);
-		sdata.Store("data", this->data);
+		sdata["ci"] << this->object;
+		sdata["name"] << this->name;
+		sdata["data"] << this->data;
 	}
 
 	static Serializable *Unserialize(Serializable *obj, Serialize::Data &data)
@@ -190,7 +189,6 @@ public:
 	void OnReload(Configuration::Conf *conf) override
 	{
 		descriptions.clear();
-		numerics.clear();
 
 		for (int i = 0; i < conf->CountBlock("command"); ++i)
 		{
@@ -206,31 +204,9 @@ public:
 				continue;
 
 			descriptions[cname] = desc;
-
-			auto numeric = block->Get<unsigned>("misc_numeric");
-			if (numeric >= 1 && numeric <= 999)
-				numerics["cs_set_misc:" + GetAttribute(cname)] = numeric;
 		}
 	}
 
-	void OnJoinChannel(User *user, Channel *c) override
-	{
-		if (!c->ci || !user->server->IsSynced() || numerics.empty())
-			return;
-
-		for (const auto &[name, ext] : items)
-		{
-			auto *data = ext->Get(c->ci);
-			if (!data)
-				continue;
-
-			auto numeric = numerics.find(name);
-			if (numeric != numerics.end())
-				IRCD->SendNumeric(numeric->second, user->GetUID(), c->ci->name, data->data);
-		}
-	}
-
-
 	void OnChanInfo(CommandSource &source, ChannelInfo *ci, InfoFormatter &info, bool) override
 	{
 		for (const auto &[_, e] : items)