- Windows: Fix strange linking bug. Outgoing connects from a Windows

IRCd caused a garbled SERVER protocol message, causing 'cannot find
  server' errors and killing of users. Reported by Sunkat (#4183).

include/h.h

@@ -772,5 +772,7 @@ extern void free_pending_net(aClient *sptr);
 extern aPendingNet *find_pending_net_by_numeric_butone(int numeric, aClient *exempt);
 extern aClient *find_pending_net_duplicates(aClient *cptr, aClient **srv, int *numeric);
 extern aClient *find_non_pending_net_duplicates(aClient *cptr);
+extern MODVAR char serveropts[];
+extern MODVAR char *IsupportStrings[];
 extern void finish_auth(aClient *acptr);
 extern void read_packet(int fd, int revents, void *data);

src/hash.c

@@ -759,7 +759,6 @@ EVENT(e_clean_out_throttling_buckets)
 
 	if (!t || (TStime() - t > 30))
 	{
-		extern char serveropts[];
 		extern Module *Modules;
 		char *p = serveropts + strlen(serveropts);
 		Module *mi;

src/modules/m_nick.c

@@ -1085,7 +1085,6 @@ int _register_user(aClient *cptr, aClient *sptr, char *nick, char *username, cha
 				    me.name, parv[0],
 				    me.name, version, umodestring, cmodestring);
 		{
-			extern MODVAR char *IsupportStrings[];
 			int i;
 			for (i = 0; IsupportStrings[i]; i++)
 				sendto_one(sptr, rpl_str(RPL_ISUPPORT), me.name, nick, IsupportStrings[i]);

src/modules/m_protoctl.c

@@ -44,8 +44,6 @@
 
 DLLFUNC int m_protoctl(aClient *cptr, aClient *sptr, int parc, char *parv[]);
 
-extern MODVAR char      serveropts[];
-
 #define MSG_PROTOCTL 	"PROTOCTL"	
 #define TOK_PROTOCTL 	"_"	
 

src/modules/m_server.c

@@ -130,8 +130,6 @@ char buf[512];
 
 void _send_server_message(aClient *sptr)
 {
-extern char serveropts[];
-
 	if (sptr->serv->flags.server_sent)
 	{
 #ifdef DEBUGMODE
@@ -699,7 +697,6 @@ CMD_FUNC(m_server_remote)
 int	m_server_synch(aClient *cptr, long numeric, ConfigItem_link *aconf)
 {
 	char		*inpath = get_client_name(cptr, TRUE);
-	extern MODVAR char 	serveropts[];
 	aClient		*acptr;
 	char buf[BUFSIZE];
 	int incoming = IsUnknown(cptr) ? 1 : 0;

src/s_bsd.c

@@ -794,7 +794,6 @@ void completed_connection(int fd, int revents, void *data)
 {
 	aClient *cptr = data;
 	ConfigItem_link *aconf = cptr->serv ? cptr->serv->conf : NULL;
-	extern char serveropts[];
 	SetHandshake(cptr);
 
 	if (!aconf)

src/s_serv.c

@@ -175,8 +175,6 @@ char *p;
 */
 CMD_FUNC(m_version)
 {
-	extern char serveropts[];
-	extern char *IsupportStrings[];
 	int reply, i;
 
 	/* Only allow remote VERSIONs if registered -- Syzop */

src/win32/debug.c

@@ -35,7 +35,6 @@ extern OSVERSIONINFO VerInfo;
 extern char OSName[256];
 extern char backupbuf[8192];
 extern char *buildid;
-extern char serveropts[];
 extern char *extraflags;
 extern BOOL IsService;
 void CleanUp(void);