1
0
mirror of https://github.com/unrealircd/unrealircd.git synced 2026-07-03 05:13:13 +02:00

Fix wrong security-group example in release notes for auto oper up.

This should be:
security-group Syzop { certfp "1234etc."; }
As this is wrong:
security-group Syzop { mask { certfp "1234etc."; } }

Reported by Han`.

This also makes us throw a config error on the wrong case.
This commit is contained in:
Bram Matthys
2022-06-05 08:42:05 +02:00
parent 28d3875aa9
commit 8fe7b1bc41
2 changed files with 16 additions and 1 deletions
+1 -1
View File
@@ -72,7 +72,7 @@ on set::modes-on-join. Also update various example.*conf files.
[certificate fingerprint](https://www.unrealircd.org/docs/Certificate_fingerprint)
authentication for example:
```
security-group Syzop { mask { certfp "1234etc."; } }
security-group Syzop { certfp "1234etc."; }
oper Syzop {
auto-login yes;
mask { security-group Syzop; }
+15
View File
@@ -162,6 +162,8 @@ int unreal_mask_match_string(const char *name, ConfigItem_mask *mask)
#define CheckNullX(x) if ((!(x)->value) || (!(*((x)->value)))) { config_error("%s:%i: missing parameter", (x)->file->filename, (x)->line_number); *errors = *errors + 1; return 0; }
int test_match_item(ConfigFile *conf, ConfigEntry *cep, int *errors)
{
ConfigEntry *cepp;
if (!strcmp(cep->name, "webirc") || !strcmp(cep->name, "exclude-webirc"))
{
CheckNullX(cep);
@@ -206,6 +208,19 @@ int test_match_item(ConfigFile *conf, ConfigEntry *cep, int *errors)
} else
if (!strcmp(cep->name, "mask") || !strcmp(cep->name, "include-mask") || !strcmp(cep->name, "exclude-mask"))
{
for (cepp = cep->items; cepp; cepp = cepp->next)
{
if (!strcmp(cepp->name, "mask"))
continue;
if (cepp->items || cepp->value)
{
config_error("%s:%i: security-group::mask should contain hostmasks only. "
"Perhaps you meant to use it in security-group { %s ... } directly?",
cepp->file->filename, cepp->line_number,
cepp->name);
*errors = *errors + 1;
}
}
} else
if (!strcmp(cep->name, "ip"))
{