2abef3cdfb
Don't check for NULL client in match_user() since it cannot or should not be.
...
(raises false expectations)
[skip ci]
2021-11-06 13:33:37 +01:00
700c579ee7
Fix possible crash in set::part-instead-of-quit-on-comment-change.
2021-11-06 13:27:45 +01:00
c35174db32
Cleanup: don't check for NULL if they can't be NULL (variables
...
already dereferenced before)
[skip ci]
2021-11-06 13:26:57 +01:00
75b213c0db
Fix theoretical bug in case a 3rd party module CommandOverride's "CYCLE" and
...
reads parv[1] after calling the command.
(Then it would have pointed to local storage which is wrong)
2021-11-06 13:10:17 +01:00
50b14305cf
Get rid of if (module) in HistoryBackendAdd() as it is never NULL.
...
[skip ci]
2021-11-06 13:04:32 +01:00
4cf2940605
Fix-for-fix from a few minutes ago:
...
Ah okay, the `continue` in the switch was used as a `break 2`.
Changed to a `return` now as no memory is allocated anyway and
nothing further needs to be done. Also makes it immediately clear
(if you read the code) that processing ends there.
2021-11-06 13:01:12 +01:00
01c9891757
Fix some more memory leaks (all config related, and a debug one)
...
[skip ci]
2021-11-06 12:55:45 +01:00
ff967957f4
Fix two small memory leaks in extjwt (sfilename, b64sig) and change another
...
one (extjwt_hash_val) to just a simply safe_free() as well which is less
error prone (just needs the value to be initialized to NULL at the beginning
but that is already done).
2021-11-06 12:45:07 +01:00
10d2701bfe
fclose() before return in geoip_csv.c
2021-11-06 12:39:18 +01:00
3c977a4a73
Fix issue when using an URL multiple times in the config.
...
Was using AddListItem() with the two arguments swapped.
2021-11-06 12:36:32 +01:00
cae44de110
Fix memory leak if no log { } block that logs to disk and we default
...
to creating one, also missed a filter.
2021-11-06 12:34:27 +01:00
5ae33809de
Fix read-after-free in SVSNICK and remote NICK if there is any module
...
checking 'mtags' in HOOKTYPE_POST_LOCAL_NICKCHANGE.
[skip ci]
2021-11-06 11:31:40 +01:00
1e3f6e0128
Need to use ARRAY_SIZEOF() here, of course. (Not that it this bug
...
will be triggered realisticly)
[skip ci]
2021-11-06 11:28:33 +01:00
dccab58090
Code cleanup: this just looks too weird otherwise.
...
[skip ci]
2021-11-06 11:19:51 +01:00
509b96b5f7
Clean up: some unimportant control flow issues, eg using 'continue'
...
instead of 'break' in a while(0) loop.
2021-11-06 11:10:17 +01:00
abb575bdb6
S2S traffic: Fix using wrong variable in a loop, causing an OOB read.
2021-11-06 10:16:37 +01:00
e0b9118efe
Don't show empty 'via' for link.LINK_DENIED_DUPLICATE_SID_LINKED.
...
Reported by fo in https://bugs.unrealircd.org/view.php?id=5989
2021-11-05 14:54:10 +01:00
a52a7304a2
Check for SID collision in SID command as well. We already checked in
...
PROTOCTL SERVERS=xxx which all servers send, so if these are all
UnrealIRCd servers then we should not reach this, BUT.. you never know
and non-unreal servers don't send this, so it matters for eg services.
2021-11-05 14:47:02 +01:00
4ef341769d
Don't forward (spam) link.SERVER_LINKED_REMOTE.
...
Otherwise you get 1 from each server, which can be quite a pain
on a large network.
Reported by fo in https://bugs.unrealircd.org/view.php?id=5988
2021-11-05 14:31:10 +01:00
714461b655
Fix TLS debug error missing IP.
...
Reported in https://bugs.unrealircd.org/view.php?id=5993
2021-11-05 14:02:28 +01:00
0698b04057
Update extban names in modules.default.conf ( #175 )
2021-11-03 08:54:42 +01:00
888eb40273
Update modules.optional.conf to only use settings for loaded modules ( #176 )
...
This so you can just load the whole file but still use blacklist-module to not use some of it. Not sure if that is always a great idea, but it is now an option.
2021-11-03 08:53:57 +01:00
2e30b40d9c
Fix incorrect SAPART server notice / log message ( #177 )
2021-11-03 08:52:23 +01:00
edb33baa22
Make it so set::level-on-join can also specify a mode letter such
...
as 'v' instead of like 'voice'. This is needed because third party
modules can now add access levels as well (eg: X).
2021-11-03 08:44:39 +01:00
571451b1e8
Fix set::level-on-join "none" no longer working
2021-11-03 08:22:35 +01:00
1b308c7ca0
Remove seemingly needless looping on SQUITs, as suggested by
...
Polsaker in https://github.com/unrealircd/unrealircd/pull/158
Have not tested this thoroughly on a larg(er) network, but if
there is any time to apply this patch, then it is now during
6.0.0 beta.
2021-11-01 17:32:58 +01:00
e08627ead2
Update 'Server protocol' section in release notes.
...
[skip ci]
2021-11-01 11:08:35 +01:00
01815adfba
Fix about 8 log messages that were incomplete (due to invalid var expansion)
2021-11-01 10:11:46 +01:00
99436ee83c
Fix memory leak in /WHOIS
2021-11-01 09:23:45 +01:00
9b842140fc
Fix missing comma
2021-11-01 07:31:05 +01:00
d128510ee4
More fixes for $client.detail -> $client.details
2021-11-01 07:11:56 +01:00
a70eac3293
Fix referencing wrong file in a comment in snomasks.default.conf.
...
Reported by DeviL.
[skip ci]
2021-11-01 07:11:43 +01:00
f3db0d5971
Correct chgcmd snotice behaviour ( #173 )
...
Fix CHG commands snomask messages ($target.detail -> $target.details)
2021-11-01 07:09:49 +01:00
7dd40614dd
Fix showing wrong oper login name and operclass in WHOIS (to opers).
2021-10-31 17:34:10 +01:00
8f3ef69fae
Updates for Windows BuildBot
...
[skip ci]
2021-10-31 17:33:53 +01:00
44e420dc58
Add GeoIP / geoip_classic to Windows build.
...
Also fix an issue with convert_to_absolute_path() and remotely fetched files.
2021-10-31 14:16:39 +01:00
3653de5dfb
Move debug notices to debug and suggest not to log them by default.
...
Also, add a note about AddressSanitizer in the release notes.
(this will be in 6.0.0-beta1)
2021-10-31 09:04:17 +01:00
b29a9be288
** UnrealIRCd 6.0.0-beta1 **
2021-10-31 08:40:09 +01:00
c196e31c60
Fix using wrong numeric for certfp in /WHOIS
2021-10-31 07:35:02 +01:00
ca36a5256c
Some text updates UnrealIRCd 5 -> UnrealIRCd 6
2021-10-31 07:20:57 +01:00
9fcb4ddbe9
Fix some log messages, reported by delta.
2021-10-30 18:41:09 +02:00
ca238cd76b
Make valid_server_name() use valid_host() to accept more characters.
...
And use the same function when testing the me { } block.
Reported by gerard.
2021-10-30 18:18:07 +02:00
57cb9ebc20
Consistently use $existing_client instead of $other_client.
...
Fixes some expansion issues (too), as reported by delta.
2021-10-30 17:41:15 +02:00
e3b7ad8fc4
Fix crash in SENDSNO
2021-10-30 17:25:58 +02:00
e3023cc926
Update release notes
...
[skip ci]
2021-10-30 12:36:15 +02:00
58c3e2940b
Add link to JSON logging wiki article with screenshot
...
[skip ci]
2021-10-30 12:11:08 +02:00
5e47073eba
Use sections in release notes (convert the remaining ones)
...
[skip ci]
2021-10-30 11:32:56 +02:00
aba5817cc0
More release notes updates
...
[skip ci]
2021-10-30 11:29:00 +02:00
bfe97a4bde
Re-order items in release notes
...
[skip ci]
2021-10-30 11:17:39 +02:00
4be62698c2
Update release notes
...
[skip ci]
2021-10-30 11:15:05 +02:00
Bram Matthys