pegasus/weechat
1
0
Fork 0
mirror of https://github.com/weechat/weechat.git synced 2026-06-29 22:36:38 +02:00
Code Activity

script: remove trailing "J" (line feed char) in source of scripts displayed

Browse Source 
Regression was indirectly caused by commit
d18f68e497 in core that allows to display all
control chars in buffers.

But the fix is in script plugin: when the script is downloaded and read line by
line, trailing "\r" and "\n" are removed, and therefore not displayed.
This commit is contained in:
Sébastien Helleu
2023-05-22 20:40:45 +02:00
parent c0b3f63985
commit 126d3559ca
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ChangeLog.adoc
+1
View File
@@ -88,6 +88,7 @@ Bug fixes::
* irc: add messages 415 (cannot send message to channel) and 742 (mode cannot be set)
* lua: fix crash with print when the value to print is not a string (issue #1904, issue #1905)
* ruby: fix crash on quit when a child process is still running (issue #1889, issue #1915)
* script: remove trailing "J" (line feed char) in source of scripts displayed
* spell: check buffer pointer received in info "spell_dict"
* trigger: make default triggers "cmd_pass", "cmd_pass_register" and "server_pass" compatible with multiline input (issue #1935)
* typing: fix crash when pointer buffer is not received in callback for signal "input_text_changed" (issue #1869)
src/plugins/script/script-action.c
+9
View File
@@ -993,6 +993,15 @@ script_action_show_source_process_cb (const void *pointer, void *data,
ptr_line = fgets (line, sizeof (line) - 1, file);
if (ptr_line)
{
/* remove trailing '\r' and '\n' */
length = strlen (line) - 1;
while ((length >= 0)
&& ((line[length] == '\n')
|| (line[length] == '\r')))
{
line[length] = '\0';
length--;
}
weechat_printf_y (script_buffer,
script_buffer_detail_script_last_line++,
"%s", ptr_line);