cmake: remove unnecessary add_dependencies()

In a handful of places we explicitly use add_dependencies() where the
exact same libraries are also (implicitly) added as dependencies via
target_link_libraries().

Remove the folder, which helps us remove some duplication with follow-up
patches.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>

src/gui/curses/headless/CMakeLists.txt

@@ -52,11 +52,6 @@ add_executable(${EXECUTABLE}
   ${WEECHAT_CURSES_MAIN_HEADLESS_SRC}
 )
 
-add_dependencies(${EXECUTABLE}
-  weechat_gui_headless
-  weechat_ncurses_fake
-)
-
 target_link_libraries(${EXECUTABLE}
   weechat_core
   weechat_plugins

src/gui/curses/normal/CMakeLists.txt

@@ -57,8 +57,6 @@ set(EXECUTABLE weechat)
 
 add_executable(${EXECUTABLE} ${WEECHAT_CURSES_MAIN_SRC})
 
-add_dependencies(${EXECUTABLE} weechat_gui_curses_normal)
-
 list(APPEND EXTRA_LIBS ${NCURSES_LIBRARY})
 
 target_link_libraries(${EXECUTABLE}

tests/fuzz/CMakeLists.txt

@@ -88,13 +88,6 @@ list(APPEND FUZZ_TARGET_LINK
   ${LIBZSTD_LDFLAGS}
   -rdynamic
 )
-list(APPEND FUZZ_TARGET_DEPS
-  weechat_core
-  weechat_plugins
-  weechat_gui_common
-  weechat_gui_headless
-  weechat_ncurses_fake
-)
 
 # fuzz targets
 set(FUZZ_CORE_TARGETS calc eval crypto secure string utf8 util)
@@ -103,5 +96,4 @@ foreach(fuzz_target ${FUZZ_CORE_TARGETS})
   add_executable(weechat_core_${fuzz_target}_fuzzer core/${fuzz_target}-fuzzer.cc)
   target_link_libraries(weechat_core_${fuzz_target}_fuzzer ${FUZZ_TARGET_LINK} coverage_config)
   set_target_properties(weechat_core_${fuzz_target}_fuzzer PROPERTIES LINK_OPTIONS "$ENV{LIB_FUZZING_ENGINE}")
-  add_dependencies(weechat_core_${fuzz_target}_fuzzer ${FUZZ_TARGET_DEPS})
 endforeach()

tests/unit/CMakeLists.txt

@@ -240,14 +240,6 @@ target_link_libraries(tests
   ${CPPUTEST_LIBRARIES}
   -rdynamic
 )
-add_dependencies(tests
-  weechat_core
-  weechat_plugins
-  weechat_gui_common
-  weechat_gui_headless
-  weechat_ncurses_fake
-  weechat_unit_tests_core
-)
 
 # test for cmake (ctest)
 add_test(NAME unit