pegasus/weechat
1
0
Fork 0
mirror of https://github.com/weechat/weechat.git synced 2026-06-12 14:14:48 +02:00
Code Activity

core: Prevent use of uninitialized memory when setting invalid color

Browse Source 
If a color option value is null and is tried being set to an invalid
color, the value was set to uninitialized memory which can lead to a
segfault.

Can be reproduced with this script:
https://gist.github.com/trygveaa/6ddb3a52f525a7fd8e0908bafa83e07c

The option doesn't have to be set from a script, it also happens with
the /set command.
This commit is contained in:
Trygve Aaberge
2022-10-23 14:01:41 +02:00
committed by Sébastien Helleu
parent 09839150a8
commit 6f1635ae4e
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/wee-config-file.c
+8
View File
@@ -1480,6 +1480,14 @@ config_file_option_set (struct t_config_option *option, const char *value,
else
rc = WEECHAT_CONFIG_OPTION_SET_OK_SAME_VALUE;
}
else
{
if (old_value_was_null)
{
free (option->value);
option->value = NULL;
}
}
}
break;
case CONFIG_NUM_OPTION_TYPES: