pegasus/weechat
1
0
Fork 0
mirror of https://github.com/weechat/weechat.git synced 2026-06-26 04:46:37 +02:00
Code Activity

irc: use parsed command parameters in "ping" command callback

Browse Source
This commit is contained in:
Sébastien Helleu
2021-10-14 22:42:07 +02:00
parent 7a88e007a5
commit 8ea41d91c9
2 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/plugins/irc/irc-protocol.c
+9 -3
View File
@@ -2528,10 +2528,16 @@ IRC_PROTOCOL_CALLBACK(part)
IRC_PROTOCOL_CALLBACK(ping)
{
IRC_PROTOCOL_MIN_ARGS(2);
char *str_params;
irc_server_sendf (server, 0, NULL, "PONG :%s",
(argv_eol[1][0] == ':') ? argv_eol[1] + 1 : argv_eol[1]);
IRC_PROTOCOL_MIN_PARAMS(1);
str_params = irc_protocol_string_params (params, 0, num_params - 1);
irc_server_sendf (server, 0, NULL, "PONG :%s", str_params);
if (str_params)
free (str_params);
return WEECHAT_RC_OK;
}
tests/unit/plugins/irc/test-irc-protocol.cpp
+2 -2
View File
@@ -1526,9 +1526,9 @@ TEST(IrcProtocolWithServer, ping)
{
SRV_INIT;
/* not enough arguments, no response */
/* not enough parameters, no response */
RECV("PING");
CHECK_ERROR_ARGS("ping", 1, 2);
CHECK_ERROR_PARAMS("ping", 0, 1);
CHECK_SENT(NULL);
RECV("PING :123456789");