pegasus/weechat
1
0
Fork 0
mirror of https://github.com/weechat/weechat.git synced 2026-07-01 07:16:37 +02:00
Code Activity

core: fix crash or infinite loop in /allbuf command

Browse Source 
A crash could occur if the command closes buffers.
An infinite loop could occur if the command creates new buffers.
This commit is contained in:
Sébastien Helleu
2023-01-03 17:02:38 +01:00
parent 189eb5dc40
commit 958f39cb95
1 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/wee-command.c
+16
View File
@@ -94,7 +94,9 @@ extern char **environ;
COMMAND_CALLBACK(allbuf)
{
struct t_arraylist *all_buffers;
struct t_gui_buffer *ptr_buffer;
int i, list_size;
/* make C compiler happy */
(void) pointer;
@@ -103,12 +105,26 @@ COMMAND_CALLBACK(allbuf)
COMMAND_MIN_ARGS(2, "");
all_buffers = arraylist_new (gui_buffers_count, 0, 0,
NULL, NULL, NULL, NULL);
for (ptr_buffer = gui_buffers; ptr_buffer;
ptr_buffer = ptr_buffer->next_buffer)
{
arraylist_add (all_buffers, ptr_buffer);
}
list_size = arraylist_size (all_buffers);
for (i = 0; i < list_size; i++)
{
ptr_buffer = (struct t_gui_buffer *)arraylist_get (all_buffers, i);
if (!gui_buffer_valid (ptr_buffer))
continue;
(void) input_data (ptr_buffer, argv_eol[1], NULL);
}
arraylist_free (all_buffers);
return WEECHAT_RC_OK;
}