cmake: remove explicit fPIC handling

With CMP0083 introduced with cmake 3.14, as we set the variable
CMAKE_POSITION_INDEPENDENT_CODE we can rely on the build system to do
the correct thing, across all the targets.

Since we require 3.18 (or 3.16 in the patched Debian/Ubuntu version),
which sets the policy to NEW we're all set.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>

src/plugins/CMakeLists.txt

@@ -39,9 +39,6 @@ add_library(weechat_plugins STATIC ${LIB_PLUGINS_SRC})
 target_link_libraries(weechat_plugins coverage_config)
 
 add_definitions(${CMAKE_SHARED_LIBRARY_C_FLAGS})
-if(NOT CYGWIN)
-  add_definitions(-fPIC)
-endif()
 add_library(weechat_plugins_scripts STATIC ${LIB_PLUGINS_SCRIPTS_SRC})
 
 include(CheckIncludeFiles)

tests/fuzz/CMakeLists.txt

@@ -36,10 +36,6 @@ include_directories(
   ${CMAKE_CURRENT_SOURCE_DIR}
 )
 
-if(NOT CYGWIN)
-  add_definitions(-fPIC)
-endif()
-
 list(APPEND FUZZ_TARGET_LINK
   weechat_core
   weechat_plugins

tests/unit/CMakeLists.txt

@@ -29,10 +29,6 @@ include_directories(
   ${CMAKE_CURRENT_SOURCE_DIR}
 )
 
-if(NOT CYGWIN)
-  add_definitions(-fPIC)
-endif()
-
 if(ENABLE_PYTHON)
   add_definitions(-DHAVE_PYTHON)
 endif()