pegasus/weechat
1
0
Fork 0
mirror of https://github.com/weechat/weechat.git synced 2026-06-12 14:14:48 +02:00
Code Activity

irc: use parsed command parameters in "349" command callback

Browse Source
This commit is contained in:
Sébastien Helleu
2021-10-16 13:11:54 +02:00
parent 027ecc6b0e
commit cee4bf7e3c
2 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/plugins/irc/irc-protocol.c
+12 -9
View File
@@ -5223,22 +5223,22 @@ IRC_PROTOCOL_CALLBACK(348)
* Callback for the IRC command "349": end of channel exception list.
*
* Command looks like:
* :server 349 mynick #channel :End of Channel Exception List
* 349 mynick #channel :End of Channel Exception List
*/
IRC_PROTOCOL_CALLBACK(349)
{
char *pos_args;
char *str_params;
struct t_irc_channel *ptr_channel;
struct t_gui_buffer *ptr_buffer;
struct t_irc_modelist *ptr_modelist;
IRC_PROTOCOL_MIN_ARGS(4);
IRC_PROTOCOL_MIN_PARAMS(2);
pos_args = (argc > 4) ?
((argv_eol[4][0] == ':') ? argv_eol[4] + 1 : argv_eol[4]) : NULL;
str_params = (num_params > 2) ?
irc_protocol_string_params (params, 2, num_params - 1) : NULL;
ptr_channel = irc_channel_search (server, argv[3]);
ptr_channel = irc_channel_search (server, params[1]);
ptr_buffer = (ptr_channel && ptr_channel->nicks) ?
ptr_channel->buffer : server->buffer;
ptr_modelist = irc_modelist_search (ptr_channel, 'e');
@@ -5263,11 +5263,14 @@ IRC_PROTOCOL_CALLBACK(349)
weechat_prefix ("network"),
IRC_COLOR_CHAT_DELIMITERS,
IRC_COLOR_CHAT_CHANNEL,
argv[3],
params[1],
IRC_COLOR_CHAT_DELIMITERS,
IRC_COLOR_RESET,
(pos_args) ? " " : "",
(pos_args) ? pos_args : "");
(str_params) ? " " : "",
(str_params) ? str_params : "");
if (str_params)
free (str_params);
return WEECHAT_RC_OK;
}
tests/unit/plugins/irc/test-irc-protocol.cpp
+3 -3
View File
@@ -3078,11 +3078,11 @@ TEST(IrcProtocolWithServer, 349)
{
SRV_INIT_JOIN;
/* not enough arguments */
/* not enough parameters */
RECV(":server 349");
CHECK_ERROR_ARGS("349", 2, 4);
CHECK_ERROR_PARAMS("349", 0, 2);
RECV(":server 349 alice");
CHECK_ERROR_ARGS("349", 3, 4);
CHECK_ERROR_PARAMS("349", 1, 2);
RECV(":server 349 alice #test");
CHECK_CHAN("-- [#test]");